From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932721AbcBIT70 (ORCPT ); Tue, 9 Feb 2016 14:59:26 -0500 Received: from mail-bl2on0088.outbound.protection.outlook.com ([65.55.169.88]:19456 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753799AbcBIT7R (ORCPT ); Tue, 9 Feb 2016 14:59:17 -0500 Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=caviumnetworks.com; Message-ID: <56BA450E.50109@caviumnetworks.com> Date: Tue, 9 Feb 2016 11:59:10 -0800 From: David Daney User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Marc Zyngier CC: David Daney , Will Deacon , , Mark Rutland , Catalin Marinas , , Andrew Pinski , David Daney Subject: Re: [PATCH] arm64: Add workaround for Cavium erratum 27456 References: <1455046156-10582-1-git-send-email-ddaney.cavm@gmail.com> <20160209195222.0882d7f7@arm.com> In-Reply-To: <20160209195222.0882d7f7@arm.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [64.2.3.194] X-ClientProxiedBy: SN1PR0701CA0008.namprd07.prod.outlook.com (25.162.96.18) To CY1PR07MB2133.namprd07.prod.outlook.com (25.164.112.11) X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB2133;2:/5nPNbm9d15JnpDGOrGERIecuCyUcSY4lZL/ffFM71qKcQsPTZqQpv7YD2VA7rCNyW9p+yvOhji5El083nmog9emcDYmiQmwaophd2VWLDyBrA1lsnheckubkuBuKwC+weDBouwO6J5I2IYKg/jbAw==;3:DSs4Bc94X0e1217CeOLKWe2AotGw6XYn8q6UaluTw+q2xAbW5ZHMCwJFG1Ei49NRdNN+ieWMCpTsN4mGn2HFss4+rje39mEtYtc3wUX7hyeDeNzqNKfEG1gV3cVdmG2q;25:ZLqqYFxBI6LsCZld/nywWbvCtPwsLx2nA+Kzr4snV2p4f5HCqywqiFkNZMvNxPDvDcdtopa9infcEqSOu5Jo5oyXpcAYDn2zQ6Sd2+/+1DzZMkaSTn7h8kITpzvKIep+tWcnww2fFXv1T19xVfiAPUj7GfqX0KvA1i+2crTGrP4tnQx/sNvTgZc8x92zLtQZCUC8tZWyjjA0vRdHk8VQe52aEPtSTo+58KKsBkJxKu1d4GdJxArk7eqZqMArSSaDliBdq6eCs739BUkjh79sKLPHx1X/enfa+UPA38feqv0u9bTRuu4vuIFwTdJAhtBX X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR07MB2133; X-MS-Office365-Filtering-Correlation-Id: cc28cb83-fbb2-4e73-3dda-08d3318b7c47 X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB2133;20:hEKaR/ovIBe+muDaElSty4CgfqB/LcV20Vf2u1u6QDRZMLQx1sRICWg9WSBhOJ4LRAzbW+XaUmkJPco73iMm5TyeppZvazSEmdWHt4SxKXPWE8olEgRwo4VJkyx8Sqy3kroi72A/n182FVc1oj8Oh3NsH+4FVb1P8vK9tvkb+YaaJg++lRPjVLY0UHJ4uTK+1hWqwB1I1CSvdMobTTUSjkvClyS3hF8FRGNKBH24uipXoScqbWvMOlWQI12mflfF7QIXo6QmPQPqFnBjOs34uaEEdeoDiNftzrn5+ec/+JZpyEv2D75ymeB2Vg8XrcBcSY9nXQiQlozccfCuvIjRkARHYDqzQUZC5gAbO01r1lBNvUT50XekANMo845zlFwaGdJ1m2BSYqR1j32rE82befwpFeFLRxaKazuJOPmTcMmxwL0tZw599+nogwxCQbcjzIgx7Wu8efvB7QAJ1VUI5HIuwTWV/JD2vnM40S9E3JrpMuNR6OVD/RjngOxexWxNOiMogmdOWkLkBro/eFhwAATPBOTMoQsxv8kOOXQ69xbiNDegxhceUIMj0qnUR8kBvn4q/jWxSfm8zo8qptRr/lWm1oBQoRr0UCfuGQEJN40= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046);SRVR:CY1PR07MB2133;BCL:0;PCL:0;RULEID:;SRVR:CY1PR07MB2133; X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB2133;4:8WCIA3mYSs0pwqhU7WvpWZiaD1jQQqmrC1ffnZTz469b3cqxc8Rb49XQvMb6QC3Nn64BItvuqyojHntjlIwoWqJ1vmWEv1y5q49pK/9wOtsFn1KRby8GXnZ5Yrsp2A5u/F5H+BoCWSaMGq4auWG3G9RRJ841kBbzpUxWRq5wVb7idhSyKPswXf5OWJbok2tQt8fyfVgnWUFmwhW+uSx8sJvdvyvW/7ZIuOXnnK0PuWg4Dy7enX/KtVsEnu33eMt9aaEqq5oZTyGizapxSLNrX18ZEMnuo39AkEtfxervCeCFJTD7U0DSXP5WUNfkL6rz+3EZ+nE86x7doyQkVJGr5kBSfxm3oVh6WPgid2ougMm4LtgmettLGerAwUwx9MKk X-Forefront-PRVS: 08476BC6EF X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(377454003)(479174004)(24454002)(164054003)(33656002)(19580395003)(23756003)(87976001)(19580405001)(83506001)(36756003)(64126003)(40100003)(3846002)(122386002)(92566002)(586003)(77096005)(2950100001)(6116002)(189998001)(5004730100002)(2906002)(4326007)(5008740100001)(47776003)(50466002)(42186005)(1096002)(4001350100001)(54356999)(65956001)(50986999)(76176999)(65816999)(230700001)(110136002)(5001960100002)(53416004)(65806001)(66066001);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR07MB2133;H:dl.caveonetworks.com;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?iso-8859-1?Q?1;CY1PR07MB2133;23:XaC131BYqtzvZZJs9PJNOub0flvtf/gD0MaJwSI?= =?iso-8859-1?Q?nx0VTCGQUE+ERTBR4j1Qmt9doRip83y94l+nYlagPH76ZwbX/nKKxnMdAz?= =?iso-8859-1?Q?G6PApU/XVtVKAVplaPUOtMaa3uvg/YpGb29phtj0HWZaO+AcRmVHLtWrQX?= =?iso-8859-1?Q?lQFZ6uzxHljXRZwAure2zwIhsoDOd2x/15ioPxuYNzKBnZIujaIpto3MuI?= =?iso-8859-1?Q?WCgGgsahO2pP1AH3W/fpgUjwSK6y33IjTlnRnU3EZ1tp2ynQK+ghSh37dr?= =?iso-8859-1?Q?hT+to6lLGcFu41xKqynoateQAckKbIu2PdIE9vnGuBMKqlKjHgATqyLdSO?= =?iso-8859-1?Q?WgCo6f4tSx4mwFDJMm/9QJN/bgYqPLdszkjS+CHZ5STQnJDyijAQCx5Qcw?= =?iso-8859-1?Q?/aMJjDAdDlHdeiCCd4FkxdIvqmUSrYbneOzUuC6pIeX0Wx3vaFs9okwaPx?= =?iso-8859-1?Q?euA/0QOR67QTS8+DlhhCzqjsjzYmsWXh7Y46IIBr4TkqjSJq9emZYWgvbz?= =?iso-8859-1?Q?tuHPAerYvqs1JRLWW4NvFgQK/b3KqvKtsTENS5YS5QJ+SgVuyDYAbcxRSL?= =?iso-8859-1?Q?0n4dw5Gs6pQO3GRHrZhf/X+6bHvG6vaS4QiuMAORDjgqXTRKfL3vqXf/c8?= =?iso-8859-1?Q?ELep4YNP6TkqkmIupmABLlooXV56ThuByi8MigG0mbIdxd6lHt8gVAn15p?= =?iso-8859-1?Q?VCMPqykthAa9yGqvmxat8PXSPz0P0iZ+1K0Tk5VdXiWZDlfIvpSk8NIeL3?= =?iso-8859-1?Q?93W0s6fj78GNjoKS+Yn+IDQokObmM6Vd4lzf0hQMBYN4+ONK/V1J+vfymF?= =?iso-8859-1?Q?Tz+WkUaVyzWFobDCtHuAs4nSua2nTVJiRt/HT3AkQMyP9NbCZYvX7j+fpf?= =?iso-8859-1?Q?TXBTXefjcfbkrv5Gratd0u4mb+qUyErN+Ca8DrKYPQX2llGG1KtVeTqIzP?= =?iso-8859-1?Q?Dq2Y5o35JhIeUzd9/RHdmIR1OhTMU3qYTGxoW1G+/AoBY6XD2CcFRfHtte?= =?iso-8859-1?Q?OEkTeUIvrJUgMk3P7oam6Gfowz0GD9oNCyjMV2g+nWync4ScheC4TnCpJf?= =?iso-8859-1?Q?NtTxNSbx+X11JQhlDQ7pNdWBzD4XdW3SHuSkNVH4jLf7Nc2ONcXKZVbN1G?= =?iso-8859-1?Q?W8FT8+H+Cs8xxpAjY2nnnDzyGuoX+vDaSaM6BHq40VP/AQk4=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB2133;5:Nks+OkD8n06la5E0RW7lBVDfpkpmc4+1+r8yreCioQYMMWWEulWXphhFCbRKPGCmsQk8nhfi/8unNG9UHXXrVYtDXrPYRLh+xp3CBGOPccs0gVIJHSSDhKyGJsctc464kKcIzFhZLeXhkjPU6dobPQ==;24:v57x/VPv2Trx2dM3YtzFoLHZMsdyJ+fuWUYkMR0L8l8XEl9jzwD7EfR6AV5YnWwXnqbHPJtrIufWTf0X7RJ8ILIgSSEmzp2Egl+0piJWSY4= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2016 19:59:13.6661 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR07MB2133 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/09/2016 11:52 AM, Marc Zyngier wrote: > On Tue, 9 Feb 2016 11:29:16 -0800 > David Daney wrote: > > Hi David, > >> From: Andrew Pinski >> >> On ThunderX T88 pass 1.x through 2.1 parts, broadcast TLBI >> instructions may cause the icache to become invalid if it contains >> data for a non-current ASID. >> >> This patch implements the workaround (which flushes the local icache >> when switching the mm) by using code patching. >> >> Signed-off-by: Andrew Pinski >> Signed-off-by: David Daney >> --- >> arch/arm64/Kconfig | 11 +++++++++++ >> arch/arm64/include/asm/cpufeature.h | 3 ++- >> arch/arm64/kernel/cpu_errata.c | 9 +++++++++ >> arch/arm64/mm/proc.S | 12 ++++++++++++ >> 4 files changed, 34 insertions(+), 1 deletion(-) > > It would be good to update Documentation/arm64/silicon-errata.txt to > reflect the fact that there is a workaround available for this erratum. Would you prefer a separate patch for that, or should I roll it into this one and resubmit? David Daney > > Thanks, > > M. > From mboxrd@z Thu Jan 1 00:00:00 1970 From: ddaney@caviumnetworks.com (David Daney) Date: Tue, 9 Feb 2016 11:59:10 -0800 Subject: [PATCH] arm64: Add workaround for Cavium erratum 27456 In-Reply-To: <20160209195222.0882d7f7@arm.com> References: <1455046156-10582-1-git-send-email-ddaney.cavm@gmail.com> <20160209195222.0882d7f7@arm.com> Message-ID: <56BA450E.50109@caviumnetworks.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 02/09/2016 11:52 AM, Marc Zyngier wrote: > On Tue, 9 Feb 2016 11:29:16 -0800 > David Daney wrote: > > Hi David, > >> From: Andrew Pinski >> >> On ThunderX T88 pass 1.x through 2.1 parts, broadcast TLBI >> instructions may cause the icache to become invalid if it contains >> data for a non-current ASID. >> >> This patch implements the workaround (which flushes the local icache >> when switching the mm) by using code patching. >> >> Signed-off-by: Andrew Pinski >> Signed-off-by: David Daney >> --- >> arch/arm64/Kconfig | 11 +++++++++++ >> arch/arm64/include/asm/cpufeature.h | 3 ++- >> arch/arm64/kernel/cpu_errata.c | 9 +++++++++ >> arch/arm64/mm/proc.S | 12 ++++++++++++ >> 4 files changed, 34 insertions(+), 1 deletion(-) > > It would be good to update Documentation/arm64/silicon-errata.txt to > reflect the fact that there is a workaround available for this erratum. Would you prefer a separate patch for that, or should I roll it into this one and resubmit? David Daney > > Thanks, > > M. >