From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38847)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <thuth@redhat.com>) id 1aTFEV-0006gd-9f
	for qemu-devel@nongnu.org; Tue, 09 Feb 2016 15:50:00 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <thuth@redhat.com>) id 1aTFES-0000wq-HW
	for qemu-devel@nongnu.org; Tue, 09 Feb 2016 15:49:59 -0500
Received: from mx1.redhat.com ([209.132.183.28]:38393)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <thuth@redhat.com>) id 1aTFES-0000wW-C8
	for qemu-devel@nongnu.org; Tue, 09 Feb 2016 15:49:56 -0500
References: <cover.1454927009.git.samuel.thibault@ens-lyon.org>
	<c12905d5ab615dfa50e14322da3e37c9be6e2af4.1454927009.git.samuel.thibault@ens-lyon.org>
	<56BA1057.6030409@redhat.com> <20160209195652.GD2673@var.home>
From: Thomas Huth <thuth@redhat.com>
Message-ID: <56BA50EB.4060902@redhat.com>
Date: Tue, 9 Feb 2016 21:49:47 +0100
MIME-Version: 1.0
In-Reply-To: <20160209195652.GD2673@var.home>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCHv7 1/9] slirp: Adding IPv6,
 ICMPv6 Echo and NDP autoconfiguration
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Samuel Thibault <samuel.thibault@gnu.org>
Cc: zhanghailiang <zhang.zhanghailiang@huawei.com>, Li Zhijian <lizhijian@cn.fujitsu.com>, Stefan Hajnoczi <stefanha@gmail.com>, Jason Wang <jasowang@redhat.com>, Dave Gilbert <dgilbert@redhat.com>, Vasiliy Tolstov <v.tolstov@selfip.ru>, qemu-devel@nongnu.org, Gonglei <arei.gonglei@huawei.com>, Jan Kiszka <jan.kiszka@siemens.com>, Huangpeng <peter.huangpeng@huawei.com>, Yang Hongyang <yanghy@cn.fujitsu.com>, Guillaume Subiron <maethor@subiron.org>

On 09.02.2016 20:56, Samuel Thibault wrote:
> Thomas Huth, on Tue 09 Feb 2016 17:14:15 +0100, wrote:
>> A lot of these defines seem to be define in <netinet/icmp6.h> already
>> (as recommended by RFC 3542) ... would it be feasible to use that
>> standard header, instead of redefining here everything?
> 
> I'm wondering how widely available that is.  On windows, for instance?

Ok, good point, I just tried with my MinGW cross-compiler, and the
header is apparently not available there. So never mind, and better keep
the #defines here.

 Thomas