From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36134)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <borntraeger@de.ibm.com>) id 1aTR8A-0005xi-LF
	for qemu-devel@nongnu.org; Wed, 10 Feb 2016 04:32:15 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <borntraeger@de.ibm.com>) id 1aTR87-0004ch-E7
	for qemu-devel@nongnu.org; Wed, 10 Feb 2016 04:32:14 -0500
Received: from e06smtp05.uk.ibm.com ([195.75.94.101]:53658)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <borntraeger@de.ibm.com>) id 1aTR87-0004cc-3f
	for qemu-devel@nongnu.org; Wed, 10 Feb 2016 04:32:11 -0500
Received: from localhost
	by e06smtp05.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <borntraeger@de.ibm.com>;
	Wed, 10 Feb 2016 09:32:10 -0000
Received: from b06cxnps4074.portsmouth.uk.ibm.com
	(d06relay11.portsmouth.uk.ibm.com [9.149.109.196])
	by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id EA4861B0804B
	for <qemu-devel@nongnu.org>; Wed, 10 Feb 2016 09:32:20 +0000 (GMT)
Received: from d06av01.portsmouth.uk.ibm.com (d06av01.portsmouth.uk.ibm.com
	[9.149.37.212])
	by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with
	ESMTP id u1A9W7ld5570982
	for <qemu-devel@nongnu.org>; Wed, 10 Feb 2016 09:32:07 GMT
Received: from d06av01.portsmouth.uk.ibm.com (localhost [127.0.0.1])
	by d06av01.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with
	ESMTP id u1A9W7DX009679
	for <qemu-devel@nongnu.org>; Wed, 10 Feb 2016 02:32:07 -0700
References: <1455036545-14870-1-git-send-email-den@openvz.org>
From: Christian Borntraeger <borntraeger@de.ibm.com>
Message-ID: <56BB0396.3070603@de.ibm.com>
Date: Wed, 10 Feb 2016 10:32:06 +0100
MIME-Version: 1.0
In-Reply-To: <1455036545-14870-1-git-send-email-den@openvz.org>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH 1/1] vl: fix tracing initialization
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Denis V. Lunev" <den@openvz.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>, =?UTF-8?Q?Alex_Benn=c3=a9e?= <alex.bennee@linaro.org>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>

On 02/09/2016 05:49 PM, Denis V. Lunev wrote:
> we should call trace_init_backends() before trace_init_file() for
> CONFIG_TRACE_SIMPLE There is no difference for other cases.
> 
> This problem was introduced by the commit
>     commit 41fc57e44ed64cd4ab5393d83624afd897dabd4f
>     Author: Paolo Bonzini <pbonzini@redhat.com>
>     Date:   Thu Jan 7 16:55:24 2016 +0300
> 
>     trace: split trace_init_file out of trace_init_backends
> 
> 'make check' was failed as a result if configured with
>   --enable-trace-backends=simple
> 
> Spotted by Alex Bennée.
> 
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> CC: Alex Bennée <alex.bennee@linaro.org>
> CC: Paolo Bonzini <pbonzini@redhat.com>
> CC: Stefan Hajnoczi <stefanha@redhat.com>

Tested-by: Christian Borntraeger <borntraeger@de.ibm.com>