From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752384AbcBLLmr (ORCPT ); Fri, 12 Feb 2016 06:42:47 -0500 Received: from lucky1.263xmail.com ([211.157.147.131]:38021 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752253AbcBLLmq (ORCPT ); Fri, 12 Feb 2016 06:42:46 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: shawn.lin@rock-chips.com X-FST-TO: linux-kernel@vger.kernel.org X-SENDER-IP: 220.200.4.41 X-LOGIN-NAME: shawn.lin@rock-chips.com X-UNIQUE-TAG: <1f080b3b3ea035bf8041e7b8961f17b4> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH] mmc: dw_mmc-rockchip: remove dw_mci_rockchip_pmops To: Jaehoon Chung , Ulf Hansson References: <1454470004-21408-1-git-send-email-shawn.lin@rock-chips.com> <56B2EC67.4010909@samsung.com> Cc: shawn.lin@rock-chips.com, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org From: Shawn Lin Message-ID: <56BDC527.9090002@rock-chips.com> Date: Fri, 12 Feb 2016 19:42:31 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <56B2EC67.4010909@samsung.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016/2/4 14:15, Jaehoon Chung wrote: > Hi, Shawn. > > On 02/03/2016 12:26 PM, Shawn Lin wrote: >> dw_mci_rockchip_pmops just copy-paste what dw_mci_pltfm_pmops >> have done. Let's remove it. > > Yep, it's possible to remove. > I'm not sure but i want to know there is no plan to add the specific code of rockchip in suspend/resume. > Could you check this? Jaehoon, :) I can't say "never plan to add anything" in case of some broken Socs need something special to do in the future. But I will that would not happen, and personally we not going to add specific code here. Thanks for sharing your thought. > > Best Regards, > Jaehoon Chung > >> >> Signed-off-by: Shawn Lin >> --- >> >> drivers/mmc/host/dw_mmc-rockchip.c | 22 +--------------------- >> 1 file changed, 1 insertion(+), 21 deletions(-) >> >> diff --git a/drivers/mmc/host/dw_mmc-rockchip.c b/drivers/mmc/host/dw_mmc-rockchip.c >> index d9c92f3..3438ab3 100644 >> --- a/drivers/mmc/host/dw_mmc-rockchip.c >> +++ b/drivers/mmc/host/dw_mmc-rockchip.c >> @@ -276,33 +276,13 @@ static int dw_mci_rockchip_probe(struct platform_device *pdev) >> return dw_mci_pltfm_register(pdev, drv_data); >> } >> >> -#ifdef CONFIG_PM_SLEEP >> -static int dw_mci_rockchip_suspend(struct device *dev) >> -{ >> - struct dw_mci *host = dev_get_drvdata(dev); >> - >> - return dw_mci_suspend(host); >> -} >> - >> -static int dw_mci_rockchip_resume(struct device *dev) >> -{ >> - struct dw_mci *host = dev_get_drvdata(dev); >> - >> - return dw_mci_resume(host); >> -} >> -#endif /* CONFIG_PM_SLEEP */ >> - >> -static SIMPLE_DEV_PM_OPS(dw_mci_rockchip_pmops, >> - dw_mci_rockchip_suspend, >> - dw_mci_rockchip_resume); >> - >> static struct platform_driver dw_mci_rockchip_pltfm_driver = { >> .probe = dw_mci_rockchip_probe, >> .remove = dw_mci_pltfm_remove, >> .driver = { >> .name = "dwmmc_rockchip", >> .of_match_table = dw_mci_rockchip_match, >> - .pm = &dw_mci_rockchip_pmops, >> + .pm = &dw_mci_pltfm_pmops, >> }, >> }; >> >> > > > > -- Best Regards Shawn Lin