From: Vegard Nossum <vegard.nossum@oracle.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
John Youn <johnyoun@synopsys.com>,
Richard Weinberger <richard@nod.at>,
James McMechan <James_McMechan@hotmail.com>,
Alan Stern <stern@rowland.harvard.edu>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
USB list <linux-usb@vger.kernel.org>,
uml-devel <user-mode-linux-devel@lists.sourceforge.net>
Subject: Re: [PATCH 1/3] usb: core: Allow compilation on platforms where NO_DMA=y
Date: Mon, 15 Feb 2016 21:38:18 +0100 [thread overview]
Message-ID: <56C2373A.4010701@oracle.com> (raw)
In-Reply-To: <CAMuHMdVxNS1_coU6EPZcHYKZqGnOPDmHq9_aQGa08jLNP55Nhg@mail.gmail.com>
On 02/15/2016 01:28 PM, Geert Uytterhoeven wrote:
> On Mon, Feb 15, 2016 at 12:49 PM, Vegard Nossum
> <vegard.nossum@oracle.com> wrote:
>> On 02/15/2016 12:21 PM, Geert Uytterhoeven wrote:
>>> If NO_DMA=y:
>>>
>>> ERROR: "dma_pool_destroy" [drivers/usb/core/usbcore.ko] undefined!
>>> ERROR: "bad_dma_ops" [drivers/usb/core/usbcore.ko] undefined!
>>> ERROR: "dma_pool_free" [drivers/usb/core/usbcore.ko] undefined!
>>> ERROR: "dma_pool_alloc" [drivers/usb/core/usbcore.ko] undefined!
>>> ERROR: "dma_pool_create" [drivers/usb/core/usbcore.ko] undefined!
>>>
>>> Add a few checks for CONFIG_HAS_DMA to fix this.
>>>
>>> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
>>> ---
>>> drivers/usb/core/buffer.c | 18 ++++++++++++------
>>> drivers/usb/core/hcd.c | 14 ++++++++++----
>>> 2 files changed, 22 insertions(+), 10 deletions(-)
>>>
[...]
>> Assuming this still lets the platform actually run USB drivers (which it
>> looks like it does -- I still have to test it), then I'm all for it. You
>
> Please give it a try and let me know, as I'm not in a position to test-run
> this on Sun-3.
Hrm, I can't quite get usb-over-ip working, I get this in the UML guest
when trying to attach the host device:
# usbip -d attach -r 192.168.0.20 -b 2-1
usbip: debug: usbip.c:141:[run_command] running command: `attach'
libusbip: debug: vhci_driver.c:242:[usbip_vhci_driver_open] available
ports: 7
libusbip: debug: vhci_driver.c:71:[parse_status] port 0 status 4 speed 0
devid 0
libusbip: debug: vhci_driver.c:72:[parse_status] socket 0 lbusid
0000000000000000
libusbip: debug: vhci_driver.c:71:[parse_status] port 1 status 4 speed 0
devid 0
libusbip: debug: vhci_driver.c:72:[parse_status] socket 0 lbusid
0000000000000000
libusbip: debug: vhci_driver.c:71:[parse_status] port 2 status 4 speed 0
devid 0
libusbip: debug: vhci_driver.c:72:[parse_status] socket 0 lbusid
0000000000000000
libusbip: debug: vhci_driver.c:71:[parse_status] port 3 status 4 speed 0
devid 0
libusbip: debug: vhci_driver.c:72:[parse_status] socket 0 lbusid
0000000000000000
libusbip: debug: vhci_driver.c:71:[parse_status] port 4 status 4 speed 0
devid 0
libusbip: debug: vhci_driver.c:72:[parse_status] socket 0 lbusid
0000000000000000
libusbip: debug: vhci_driver.c:71:[parse_status] port 5 status 4 speed 0
devid 0
libusbip: debug: vhci_driver.c:72:[parse_status] socket 0 lbusid
0000000000000000
libusbip: debug: vhci_driver.c:71:[parse_status] port 6 status 4 speed 0
devid 0
libusbip: debug: vhci_driver.c:72:[parse_status] socket 0 lbusid
0000000000000000
libusbip: debug: vhci_driver.c:71:[parse_status] port 7 status 4 speed 0
devid 0
libusbip: debug: vhci_driver.c:72:[parse_status] socket 0 lbusid
0000000000000000
libusbip: debug: vhci_driver.c:105:[parse_status] exit
libusbip: debug: vhci_driver.c:311:[usbip_vhci_attach_device2] writing:
0 3 131074 5
libusbip: debug: vhci_driver.c:316:[usbip_vhci_attach_device2] attach
attribute path: /sys/devices/platform/vhci_hcd/attach
vhci_hcd: Failed attach request for unsupported USB speed: super-speed
usbip: debug: sysfs_utils.c:23:[write_sysfs_attribute] error writing to
attribute /sys/devices/platform/vhci_hcd/attach
libusbip: debug: vhci_driver.c:320:[usbip_vhci_attach_device2]
write_sysfs_attribute failed
usbip: error: import device
usbip: error: query
That said, I haven't tried if it works with my patches either, so it
might be something else.
I'll dive into it tomorrow.
Vegard
next prev parent reply other threads:[~2016-02-15 20:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-15 11:21 [PATCH 0/3] usb: Allow compilation on platforms where NO_DMA=y Geert Uytterhoeven
2016-02-15 11:21 ` [PATCH 1/3] usb: core: " Geert Uytterhoeven
2016-02-15 11:49 ` Vegard Nossum
2016-02-15 12:28 ` Geert Uytterhoeven
2016-02-15 20:38 ` Vegard Nossum [this message]
2016-02-16 12:35 ` Vegard Nossum
2016-02-15 11:21 ` [PATCH 2/3] usb: host: Some host drivers should depend on HAS_DMA Geert Uytterhoeven
2016-02-15 11:21 ` [PATCH 3/3] usb: dwc2: USB_DWC2 " Geert Uytterhoeven
2016-02-15 23:21 ` John Youn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C2373A.4010701@oracle.com \
--to=vegard.nossum@oracle.com \
--cc=James_McMechan@hotmail.com \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=johnyoun@synopsys.com \
--cc=linux-usb@vger.kernel.org \
--cc=richard@nod.at \
--cc=schwidefsky@de.ibm.com \
--cc=stern@rowland.harvard.edu \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.