From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44633)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1aVaKM-0005Fh-V4
	for qemu-devel@nongnu.org; Tue, 16 Feb 2016 02:45:43 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1aVaKI-00083x-OM
	for qemu-devel@nongnu.org; Tue, 16 Feb 2016 02:45:42 -0500
Received: from mail-wm0-x22f.google.com ([2a00:1450:400c:c09::22f]:38902)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1aVaKI-00083s-FL
	for qemu-devel@nongnu.org; Tue, 16 Feb 2016 02:45:38 -0500
Received: by mail-wm0-x22f.google.com with SMTP id a4so86557957wme.1
	for <qemu-devel@nongnu.org>; Mon, 15 Feb 2016 23:45:38 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
References: <1454784308-21177-1-git-send-email-mst@redhat.com>
	<1454784308-21177-23-git-send-email-mst@redhat.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <56C2D39D.8010005@redhat.com>
Date: Tue, 16 Feb 2016 08:45:33 +0100
MIME-Version: 1.0
In-Reply-To: <1454784308-21177-23-git-send-email-mst@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PULL v2 22/45] ipmi: introduce a struct
	ipmi_sdr_compact
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>, qemu-devel@nongnu.org
Cc: Marcel Apfelbaum <marcel@redhat.com>, Corey Minyard <cminyard@mvista.com>, =?UTF-8?Q?C=c3=a9dric_Le_Goater?= <clg@fr.ibm.com>, Greg Kurz <gkurz@linux.vnet.ibm.com>



On 06/02/2016 20:13, Michael S. Tsirkin wrote:
>  
> -        if (sdr[7] > MAX_SENSORS) {
> +        if (sdr->sensor_owner_number > MAX_SENSORS) {

This is another off-by-one, it should have been >=.  Same for all these
occurrences later in the same file:

hw/ipmi/ipmi_bmc_sim.c:    if ((cmd[2] > MAX_SENSORS) ||
hw/ipmi/ipmi_bmc_sim.c:    if ((cmd[2] > MAX_SENSORS) ||
hw/ipmi/ipmi_bmc_sim.c:    if ((cmd[2] > MAX_SENSORS) ||
hw/ipmi/ipmi_bmc_sim.c:    if ((cmd[2] > MAX_SENSORS) ||
hw/ipmi/ipmi_bmc_sim.c:    if ((cmd[2] > MAX_SENSORS) ||
hw/ipmi/ipmi_bmc_sim.c:    if ((cmd[2] > MAX_SENSORS) ||
hw/ipmi/ipmi_bmc_sim.c:    if ((cmd[2] > MAX_SENSORS) ||

Thanks,

Paolo

>              continue;
>          }