From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Warren <swarren@wwwdotorg.org>
Date: Tue, 16 Feb 2016 16:14:15 -0700
Subject: [U-Boot] [PATCH 10/30] dm: blk: Rename get_device() to
 blk_get_device_str()
In-Reply-To: <1455502619-16093-11-git-send-email-sjg@chromium.org>
References: <1455502619-16093-1-git-send-email-sjg@chromium.org>
 <1455502619-16093-11-git-send-email-sjg@chromium.org>
Message-ID: <56C3AD47.2090907@wwwdotorg.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 02/14/2016 07:16 PM, Simon Glass wrote:
> The current name is too generic. The function returns a block device based
> on a provided string. Rename it to aid searching and make its purpose
> clearer. Also add a few comments.

> +int blk_get_device_str(const char *ifname, const char *dev_str,
> +		       struct blk_desc **dev_desc);

Bikeshed: s/_str/_by_str/? Otherwise it somewhat sounds like it returns 
a "device_str" rather than returns a "device" and searches for it using 
a "str".

Of course, this is a really annoying comment that would cause a large 
amount of work, so feel free to ignore it.