From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Date: Tue, 16 Feb 2016 17:19:23 -0700 Subject: [U-Boot] [PATCH 02/30] dm: pci: Break out the common region display code In-Reply-To: <1455502619-16093-3-git-send-email-sjg@chromium.org> References: <1455502619-16093-1-git-send-email-sjg@chromium.org> <1455502619-16093-3-git-send-email-sjg@chromium.org> Message-ID: <56C3BC8B.5010609@wwwdotorg.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 02/14/2016 07:16 PM, Simon Glass wrote: > Each region is displayed in almost the same way. Break out this common code > into its own function. > diff --git a/drivers/pci/pci_auto_common.c b/drivers/pci/pci_auto_common.c > + if (hose->pci_mem) > + pciauto_show_region("Memory", hose->pci_mem); > + if (hose->pci_prefetch) > + pciauto_show_region("Prefetchable Mem", hose->pci_mem); That parameter should be hose->pci_prefetch > + if (hose->pci_io) > + pciauto_show_region("I/O", hose->pci_io); With that fixed, the "dhcp" failure I mentioned earlier is fixed (the system in question uses PCIe Ethernet).