From: "Jan Beulich" <JBeulich@suse.com>
To: xen-devel <xen-devel@lists.xenproject.org>
Cc: Kevin Tian <kevin.tian@intel.com>, Jun Nakajima <jun.nakajima@intel.com>
Subject: [PATCH 4/5] VMX: fold redundant code
Date: Wed, 17 Feb 2016 09:37:21 -0700 [thread overview]
Message-ID: <56C4AFD102000078000D34AD@prv-mh.provo.novell.com> (raw)
In-Reply-To: <56C4AC2802000078000D3473@prv-mh.provo.novell.com>
[-- Attachment #1: Type: text/plain, Size: 938 bytes --]
No need to do this in two slightly different ways, possibly keeping the
compiler from folding the code for us.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/arch/x86/hvm/vmx/vmx.c
+++ b/xen/arch/x86/hvm/vmx/vmx.c
@@ -3103,6 +3103,7 @@ void vmx_vmexit_handler(struct cpu_user_
&& vector != TRAP_nmi
&& vector != TRAP_machine_check )
{
+ default:
perfc_incr(realmode_exits);
v->arch.hvm_vmx.vmx_emulate = 1;
HVMTRACE_0D(REALMODE_EMULATE);
@@ -3121,12 +3122,6 @@ void vmx_vmexit_handler(struct cpu_user_
case EXIT_REASON_INVEPT:
case EXIT_REASON_INVVPID:
break;
-
- default:
- v->arch.hvm_vmx.vmx_emulate = 1;
- perfc_incr(realmode_exits);
- HVMTRACE_0D(REALMODE_EMULATE);
- return;
}
}
[-- Attachment #2: VMX-fold-realmode-exit-code.patch --]
[-- Type: text/plain, Size: 960 bytes --]
VMX: fold redundant code
No need to do this in two slightly different ways, possibly keeping the
compiler from folding the code for us.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/arch/x86/hvm/vmx/vmx.c
+++ b/xen/arch/x86/hvm/vmx/vmx.c
@@ -3103,6 +3103,7 @@ void vmx_vmexit_handler(struct cpu_user_
&& vector != TRAP_nmi
&& vector != TRAP_machine_check )
{
+ default:
perfc_incr(realmode_exits);
v->arch.hvm_vmx.vmx_emulate = 1;
HVMTRACE_0D(REALMODE_EMULATE);
@@ -3121,12 +3122,6 @@ void vmx_vmexit_handler(struct cpu_user_
case EXIT_REASON_INVEPT:
case EXIT_REASON_INVVPID:
break;
-
- default:
- v->arch.hvm_vmx.vmx_emulate = 1;
- perfc_incr(realmode_exits);
- HVMTRACE_0D(REALMODE_EMULATE);
- return;
}
}
[-- Attachment #3: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-02-17 16:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-17 16:21 [PATCH 0/5] x86: XSA-170 follow-up Jan Beulich
2016-02-17 16:32 ` [PATCH 1/5] x86emul: fix rIP handling Jan Beulich
2016-02-17 17:51 ` Andrew Cooper
2016-02-17 16:35 ` [PATCH 2/5] x86emul: limit-check branch targets Jan Beulich
2016-02-17 17:59 ` Andrew Cooper
2016-02-25 14:52 ` Ping: " Jan Beulich
2016-02-26 9:44 ` Tim Deegan
2016-02-17 16:36 ` [PATCH 3/5] x86emul: simplify IRET logic Jan Beulich
2016-02-17 18:03 ` Andrew Cooper
2016-02-17 16:37 ` Jan Beulich [this message]
2016-02-17 18:05 ` [PATCH 4/5] VMX: fold redundant code Andrew Cooper
2016-02-18 5:26 ` Tian, Kevin
2016-02-17 16:38 ` [PATCH 5/5] x86: drop failsafe callback invocation from assembly Jan Beulich
2016-02-17 19:01 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C4AFD102000078000D34AD@prv-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=jun.nakajima@intel.com \
--cc=kevin.tian@intel.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.