All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anand Jain <anand.jain@oracle.com>
To: dsterba@suse.cz, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v4 12/13] btrfs: introduce device delete by devid
Date: Thu, 18 Feb 2016 14:59:26 +0800	[thread overview]
Message-ID: <56C56BCE.3020009@oracle.com> (raw)
In-Reply-To: <20160217104911.GS4374@twin.jikos.cz>



On 02/17/2016 06:49 PM, David Sterba wrote:
> On Sat, Feb 13, 2016 at 10:01:39AM +0800, Anand Jain wrote:
>> +	if (vol_args->flags & BTRFS_DEVICE_BY_ID) {
>> +		ret = btrfs_rm_device(root, NULL, vol_args->devid);
>> +	} else {
>> +		vol_args->name[BTRFS_PATH_NAME_MAX] = '\0';
>
> 			       BTRFS_SUBVOL_NAME_MAX
>
> Spotted by Chris,
>
> fs/btrfs/ioctl.c:2703: warning: array subscript is above array bounds
>
> my gcc version does not report that. Fixed and for-next pushed.

  mine either. Sorry about that, thanks for the catch.

#define BTRFS_PATH_NAME_MAX 4087
#define BTRFS_SUBVOL_NAME_MAX 4039

  I am fine with using BTRFS_SUBVOL_NAME_MAX for now. But theoretical
  anomaly is that add-device code path will use BTRFS_PATH_NAME_MAX and
  delete device will use BTRFS_SUBVOL_NAME_MAX.. its only theoretical
  as most of the devices path are well below 4k IMO. So its a good
  trade off than other solutions like.. (just for the understanding),

    - Update add device code as well to use btrfs_ioctl_vol_args_v2
      Which means we need to introduce BTRFS_IOC_ADD_DEV_V2 (system
      PATH_MAX is 4096).

    OR

    - Create new btrfs_ioctl_vol_args_v3 with name[BTRFS_PATH_NAME_MAX+1]
    (instead of name[BTRFS_SUBVOL_NAME_MAX+1]) and BTRFS_IOC_RM_DEV_V2
    will be the only consumer of btrfs_ioctl_vol_args_v3 as of now.


Thanks, Anand





  reply	other threads:[~2016-02-18  6:59 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-13  2:01 [PATCH resend 00/13] misc patches plus Introduce device delete by devid Anand Jain
2016-02-13  2:01 ` [PATCH v2 01/13] btrfs: pass the error code to the btrfs_std_error and log ret Anand Jain
2016-02-13  2:01 ` [PATCH 02/13] btrfs: create a helper function to read the disk super Anand Jain
2016-02-13  2:01 ` [PATCH v2 03/13] btrfs: maintain consistency in logging to help debugging Anand Jain
2016-02-13  2:01 ` [PATCH v2 04/13] btrfs: device path change must be logged Anand Jain
2016-02-13  2:01 ` [PATCH 05/13] Btrfs: fix fs logging for multi device Anand Jain
2016-02-13  2:01 ` [PATCH v2 06/13] btrfs: create helper function __check_raid_min_devices() Anand Jain
2016-02-15 14:51   ` David Sterba
2016-02-13  2:01 ` [PATCH 07/13] btrfs: clean up and optimize __check_raid_min_device() Anand Jain
2016-02-13  2:01 ` [PATCH v2 08/13] btrfs: create helper btrfs_find_device_by_user_input() Anand Jain
2016-02-13  2:01 ` [PATCH 09/13] btrfs: make use of btrfs_find_device_by_user_input() Anand Jain
2016-02-15 16:47   ` David Sterba
2016-02-15 16:53     ` David Sterba
2016-02-13  2:01 ` [PATCH v2 10/13] btrfs: enhance btrfs_find_device_by_user_input() to check device path Anand Jain
2016-02-13  2:01 ` [PATCH v2 11/13] btrfs: make use of btrfs_scratch_superblocks() in btrfs_rm_device() Anand Jain
2016-02-13  2:01 ` [PATCH v4 12/13] btrfs: introduce device delete by devid Anand Jain
2016-02-17 10:49   ` David Sterba
2016-02-18  6:59     ` Anand Jain [this message]
2016-02-18  9:53       ` David Sterba
2016-02-13  2:01 ` [PATCH 13/13] btrfs: optimize check for stale device Anand Jain
2016-02-18 15:13   ` David Sterba
2016-02-19  7:10     ` Anand Jain
2016-02-19  9:15       ` Anand Jain
2016-03-22 12:21       ` David Sterba
2016-03-22 16:43         ` Anand Jain
2016-03-09  9:54     ` Anand Jain
2016-03-09 16:33       ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56C56BCE.3020009@oracle.com \
    --to=anand.jain@oracle.com \
    --cc=dsterba@suse.cz \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.