From mboxrd@z Thu Jan 1 00:00:00 1970 From: Corneliu ZUZU Subject: Re: [PATCH] arm/monitor vm-events: Implement guest-request support Date: Fri, 19 Feb 2016 07:44:59 +0200 Message-ID: <56C6ABDB.8080703@bitdefender.com> References: <1455824116-13783-1-git-send-email-czuzu@bitdefender.com> <56C624C9.5040507@bitdefender.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2221293514771762579==" Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Tamas K Lengyel , Razvan Cojocaru Cc: Keir Fraser , Ian Campbell , Andrew Cooper , Xen-devel , Stefano Stabellini , Jan Beulich List-Id: xen-devel@lists.xenproject.org This is a multi-part message in MIME format. --===============2221293514771762579== Content-Type: multipart/alternative; boundary="------------070102000803090305030605" This is a multi-part message in MIME format. --------------070102000803090305030605 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 2/18/2016 11:25 PM, Tamas K Lengyel wrote: > > > On Thu, Feb 18, 2016 at 1:08 PM, Razvan Cojocaru > > wrote: > > On 02/18/2016 09:35 PM, Corneliu ZUZU wrote: > > This patch adds ARM support for guest-request monitor vm-events. > > > > Summary of changes: > > == Moved to common-side: > > * XEN_DOMCTL_MONITOR_EVENT_GUEST_REQUEST handling (moved from X86 > > arch_monitor_domctl_event to common monitor_domctl) > > * hvm_event_guest_request, hvm_event_traps (also added target > vcpu as param) > > * guest-request bits from X86 'struct arch_domain' (to common > 'struct domain') > > == ARM implementations: > > * do_hvm_op now handling of HVMOP_guest_request_vm_event => calls > > hvm_event_guest_request (as on X86) > > * arch_monitor_get_capabilities: updated to reflect support for > > XEN_DOMCTL_MONITOR_EVENT_GUEST_REQUEST > > * vm_event_init_domain (does nothing), vm_event_cleanup_domain > > == Misc: > > * hvm_event_fill_regs renamed to arch_hvm_event_fill_regs, no > longer > > X86-specific. ARM-side implementation of this function > currently does > > nothing, that will be added in a separate patch. > > We should probably take into account what happens with Tamas' > "vm_event: > consolidate hvm_event_fill_regs and p2m_vm_event_fill_regs" patch > here. > That patch already affects hvm_event_fill_regs(). > > > Well it seems one of us will have to rebase depending which patch gets > accepted & merged first. The conflict is minimal so it's not a major > issue. If my patch gets merged first then just have to introduce the > empty function in the ARM header with the new name. > > Tamas > Okay then, for me it's fine either way. Corneliu. --------------070102000803090305030605 Content-Type: text/html; charset=utf-8 Content-Length: 3829 Content-Transfer-Encoding: quoted-printable

On 2/18/2016 11:25 PM, Tamas K Lengyel wrote:

On Thu, Feb 18, 2016 at 1:08 PM, Razvan Cojocaru <rcojocaru@bitdefender.com> wrote:

On 02/18/2016 09:35 PM, Corneliu ZUZU wrote:
> This patch adds ARM support for guest-request monitor vm-events.
>
> Summary of changes:
> =3D=3D Moved to common-side:
>=C2=A0 =C2=A0* XEN_DOMCTL_MONITOR_EVENT_GUEST_REQUEST handling (moved from X86
>=C2=A0 =C2=A0 =C2=A0 =C2=A0arch_monitor_domctl_event to common monitor_domctl)
>=C2=A0 =C2=A0* hvm_event_guest_request, hvm_event_traps (also added target vcpu as param)
>=C2=A0 =C2=A0* guest-request bits from X86 'struct arch_domain' (to common 'struct domain')
> =3D=3D ARM implementations:
>=C2=A0 =C2=A0* do_hvm_op now handling of HVMOP_guest_request_vm_event =3D> calls
>=C2=A0 =C2=A0 =C2=A0 =C2=A0hvm_event_guest_request (as on X86)
>=C2=A0 =C2=A0* arch_monitor_get_capabilities: updated to reflect support for
>=C2=A0 =C2=A0 =C2=A0 =C2=A0XEN_DOMCTL_MONITOR_EVENT_GUEST_REQUEST
>=C2=A0 =C2=A0* vm_event_init_domain (does nothing), vm_event_cleanup_domain
> =3D=3D Misc:
>=C2=A0 =C2=A0* hvm_event_fill_regs renamed to arch_hvm_event_fill_regs, no longer
>=C2=A0 =C2=A0 =C2=A0 =C2=A0X86-specific. ARM-side implementation of this function currently does
>=C2=A0 =C2=A0 =C2=A0 =C2=A0nothing, that will be added in a separate patch.

We should probably take into account what happens with Tamas' "vm_event:
consolidate hvm_event_fill_regs and p2m_vm_event_fill_regs" patch here.
That patch already affects hvm_event_fill_regs().

Well it seems one of us will have to rebase depending which patch gets accepted & merged first. The conflict is minimal so it's not a major issue. If my patch gets merged first then just have to introduce the empty function in the ARM header with the new name.

Tamas

Okay then, for me it's fine either way.

Corneliu.
--------------070102000803090305030605-- --===============2221293514771762579== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============2221293514771762579==--