From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1427730AbcBSLiF (ORCPT ); Fri, 19 Feb 2016 06:38:05 -0500 Received: from mail-wm0-f46.google.com ([74.125.82.46]:34862 "EHLO mail-wm0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750791AbcBSLiD (ORCPT ); Fri, 19 Feb 2016 06:38:03 -0500 Subject: Re: [PATCH v3 05/11] KVM: page track: introduce kvm_page_track_{add,remove}_page To: Xiao Guangrong References: <1455449503-20993-1-git-send-email-guangrong.xiao@linux.intel.com> <1455449503-20993-6-git-send-email-guangrong.xiao@linux.intel.com> Cc: gleb@kernel.org, mtosatti@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, kai.huang@linux.intel.com, jike.song@intel.com From: Paolo Bonzini Message-ID: <56C6FE97.3080806@redhat.com> Date: Fri, 19 Feb 2016 12:37:59 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <1455449503-20993-6-git-send-email-guangrong.xiao@linux.intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/02/2016 12:31, Xiao Guangrong wrote: > +static bool check_mode(enum kvm_page_track_mode mode) > +{ > + if (mode < 0 || mode >= KVM_PAGE_TRACK_MAX) > + return false; > + > + return true; > +} Oops, forgot about this; please rename to page_track_mode_is_valid and make it "static inline". Paolo