From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932732AbcBWIVX (ORCPT ); Tue, 23 Feb 2016 03:21:23 -0500 Received: from mailout2.w1.samsung.com ([210.118.77.12]:29137 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932551AbcBWIVV (ORCPT ); Tue, 23 Feb 2016 03:21:21 -0500 X-AuditID: cbfec7f5-f79b16d000005389-b8-56cc167e2fb7 Subject: Re: [PATCH] ARM: dts: add support for gpio buttons for exynos5422-odroidxu3 To: Anand Moon , Kukjin Kim , Javier Martinez Canillas , Marek Szyprowski References: <1456214467-3344-1-git-send-email-linux.amoon@gmail.com> Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org From: Krzysztof Kozlowski X-Enigmail-Draft-Status: N1110 Message-id: <56CC167A.8040303@samsung.com> Date: Tue, 23 Feb 2016 17:21:14 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-version: 1.0 In-reply-to: <1456214467-3344-1-git-send-email-linux.amoon@gmail.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrCLMWRmVeSWpSXmKPExsVy+t/xa7p1YmfCDNoey1vMP3KO1eLN2zVM Fq9fGFr0P37NbLHp8TVWi8u75rBZzDi/j8li3cZb7BZrj9xld+D02DnrLrvHplWdbB6bl9R7 bOkH8vq2rGL0+LxJLoAtissmJTUnsyy1SN8ugStj7ouljAVnhSrmTmxmbmB8x9fFyMkhIWAi sW3dUmYIW0ziwr31bF2MXBxCAksZJS7cbGGCcJ4ySrT+vMMKUiUsECZx+NcOsISIwEpGiU1H D7N0MXIAVblI7L8uAhJnFmhnlLjzdjYbSAObgLHE5uVL2CBWyEn0dk9iAbF5BbQkvl0+CBZn EVCVeHryBDuILSoQIXG4s4sdokZQ4sfke2D1nAKuEn82LWUF2cUsoCdx/6IWSJhZQF5i85q3 zBMYBWch6ZiFUDULSdUCRuZVjKKppckFxUnpuUZ6xYm5xaV56XrJ+bmbGCFx8XUH49JjVocY BTgYlXh4PbxOhwmxJpYVV+YeYpTgYFYS4XXgOxMmxJuSWFmVWpQfX1Sak1p8iFGag0VJnHfm rvchQgLpiSWp2ampBalFMFkmDk6pBkYv/g6+l0wrZ56Im9B25/S6hVeY5fc9u/26TPB95nN7 xv/1UnHPuha//8tmnP3maks5W5WyInPP3KY1CpdVAg8m/YnZ7r+t+0Ss+fa9mqLt7cVK8kdL v4h8WPOh3C4r6z1f+veJxosuZTtYxEXxVE5hOeiiqbok837tzcKJ4bdqXp02OOCkcUWJpTgj 0VCLuag4EQDHQlrihwIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23.02.2016 17:01, Anand Moon wrote: > Add support for gpio-based button on Odroid-XU3 boards > for reboot/poweroff feature. > > Signed-off-by: Anand Moon > --- > changes rebase based on linux next-20160222. > > Tested on Odroid-XU4 > > dmesg output. > [ 3.286068] of_get_named_gpiod_flags: parsed 'gpios' property of node '/gpio_keys/power_key[0]' - status (0) > [ 3.286206] gpio-11 (power key): gpiod_set_debounce: missing set() or set_debounce() operations > [ 3.286600] input: gpio_keys as /devices/platform/gpio_keys/input/input0 > --- > arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi > index 1bd507b..db9770b 100644 > --- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi > +++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi > @@ -11,6 +11,7 @@ > */ > > #include > +#include > #include > #include > #include > @@ -54,6 +55,22 @@ > #cooling-cells = <2>; > cooling-levels = <0 130 170 230>; > }; > + > + gpio_keys { > + compatible = "gpio-keys"; > + pinctrl-names = "default"; > + pinctrl-0 = <&gpio_power_key>; > + > + power_key { > + interrupt-parent = <&gpx0>; > + interrupts = <3 IRQ_TYPE_NONE>; Hmmm.... why you specify the interrupts? > + gpios = <&gpx0 3 GPIO_ACTIVE_LOW>; > + linux,code = ; > + label = "power key"; Just "power". > + debounce-interval = <10>; > + wakeup-source; > + }; > + }; > }; > > &clock_audss { > @@ -362,6 +379,11 @@ > }; > > &pinctrl_0 { > + gpio_power_key: power_key { The naming is mixed... Everything is GPIO here so don't add such prefix. Underscores only in label, not in name of node. power_key_irq: power-key-irq { > + samsung,pins = "gpx0-3"; > + samsung,pin-pud = <0>; Don't you want to set specific pin function? And what about drive strength? Best regards, Krzysztof > + }; > + > hdmi_hpd_irq: hdmi-hpd-irq { > samsung,pins = "gpx3-7"; > samsung,pin-function = <0>; > From mboxrd@z Thu Jan 1 00:00:00 1970 From: k.kozlowski@samsung.com (Krzysztof Kozlowski) Date: Tue, 23 Feb 2016 17:21:14 +0900 Subject: [PATCH] ARM: dts: add support for gpio buttons for exynos5422-odroidxu3 In-Reply-To: <1456214467-3344-1-git-send-email-linux.amoon@gmail.com> References: <1456214467-3344-1-git-send-email-linux.amoon@gmail.com> Message-ID: <56CC167A.8040303@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 23.02.2016 17:01, Anand Moon wrote: > Add support for gpio-based button on Odroid-XU3 boards > for reboot/poweroff feature. > > Signed-off-by: Anand Moon > --- > changes rebase based on linux next-20160222. > > Tested on Odroid-XU4 > > dmesg output. > [ 3.286068] of_get_named_gpiod_flags: parsed 'gpios' property of node '/gpio_keys/power_key[0]' - status (0) > [ 3.286206] gpio-11 (power key): gpiod_set_debounce: missing set() or set_debounce() operations > [ 3.286600] input: gpio_keys as /devices/platform/gpio_keys/input/input0 > --- > arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi > index 1bd507b..db9770b 100644 > --- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi > +++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi > @@ -11,6 +11,7 @@ > */ > > #include > +#include > #include > #include > #include > @@ -54,6 +55,22 @@ > #cooling-cells = <2>; > cooling-levels = <0 130 170 230>; > }; > + > + gpio_keys { > + compatible = "gpio-keys"; > + pinctrl-names = "default"; > + pinctrl-0 = <&gpio_power_key>; > + > + power_key { > + interrupt-parent = <&gpx0>; > + interrupts = <3 IRQ_TYPE_NONE>; Hmmm.... why you specify the interrupts? > + gpios = <&gpx0 3 GPIO_ACTIVE_LOW>; > + linux,code = ; > + label = "power key"; Just "power". > + debounce-interval = <10>; > + wakeup-source; > + }; > + }; > }; > > &clock_audss { > @@ -362,6 +379,11 @@ > }; > > &pinctrl_0 { > + gpio_power_key: power_key { The naming is mixed... Everything is GPIO here so don't add such prefix. Underscores only in label, not in name of node. power_key_irq: power-key-irq { > + samsung,pins = "gpx0-3"; > + samsung,pin-pud = <0>; Don't you want to set specific pin function? And what about drive strength? Best regards, Krzysztof > + }; > + > hdmi_hpd_irq: hdmi-hpd-irq { > samsung,pins = "gpx3-7"; > samsung,pin-function = <0>; >