From: Jon Hunter <jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
To: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
krzysztof.adamski-++hxYGjEMp0AvxtiuMwx3w@public.gmane.org,
"linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: RE: regulator: core: Request GPIO before creating sysfs entries
Date: Tue, 23 Feb 2016 13:22:38 +0000 [thread overview]
Message-ID: <56CC5D1E.6010101@nvidia.com> (raw)
In-Reply-To: <1456129440-28143-1-git-send-email-krzysztof.adamski-++hxYGjEMp0AvxtiuMwx3w@public.gmane.org>
Hi Mark, Krzysztof,
It appears that commit daad134d6649 ("regulator: core: Request GPIO
before creating sysfs entries") breaks boot on tegra124-nyan-big in
-next today.
Looking at the change, it does not appear that the exit path has been
updated correctly and so if a regulator is deferred then there is a
crash in the exit path. I am not sure that there is a simple way to
workaround this because of fix from commit 53032dafc6b9 ("regulator
core: fix double-free in regulator_register() error path") unless we
move regulator_ena_gpio_free() into regulator_dev_release().
Cheers
Jon
next prev parent reply other threads:[~2016-02-23 13:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-22 8:24 [PATCH] regulator: core: Request GPIO before creating sysfs entries Krzysztof Adamski
[not found] ` <1456129440-28143-1-git-send-email-krzysztof.adamski-++hxYGjEMp0AvxtiuMwx3w@public.gmane.org>
2016-02-23 13:22 ` Jon Hunter [this message]
[not found] ` <56CC5D1E.6010101-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-02-23 13:56 ` Krzysztof Adamski
2016-02-23 14:15 ` Jon Hunter
2016-02-23 14:34 ` Krzysztof Adamski
2016-02-23 14:47 ` [PATCH] regulator: core: fix error path of regulator_ena_gpio_free Krzysztof Adamski
2016-02-23 15:18 ` Jon Hunter
[not found] ` <56CC7863.4080202-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-02-24 8:26 ` Krzysztof Adamski
2016-02-24 8:26 ` Krzysztof Adamski
2016-02-24 9:03 ` Jon Hunter
2016-02-24 8:27 ` Krzysztof Adamski
2016-02-24 8:27 ` Krzysztof Adamski
2016-02-24 9:18 ` Jon Hunter
2016-02-24 10:52 ` [PATCH v3] regulator: core: fix crash in error path of regulator_register Krzysztof Adamski
[not found] ` <1456302479-14045-1-git-send-email-krzysztof.adamski-++hxYGjEMp0AvxtiuMwx3w@public.gmane.org>
2016-02-24 9:20 ` [PATCH] regulator: core: fix error path of regulator_ena_gpio_free Jon Hunter
2016-02-24 9:20 ` Jon Hunter
2016-02-25 1:46 ` Mark Brown
2016-02-24 3:48 ` regulator: core: Request GPIO before creating sysfs entries Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56CC5D1E.6010101@nvidia.com \
--to=jonathanh-ddmlm1+adcrqt0dzr+alfa@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=krzysztof.adamski-++hxYGjEMp0AvxtiuMwx3w@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.