From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Ostrovsky Subject: Re: [PATCH v5 1/6] x86/hvm: Collect information of TSC scaling ratio Date: Tue, 23 Feb 2016 09:00:20 -0500 Message-ID: <56CC65F4.4070803@oracle.com> References: <1456193104-12761-1-git-send-email-haozhong.zhang@intel.com> <1456193104-12761-2-git-send-email-haozhong.zhang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1456193104-12761-2-git-send-email-haozhong.zhang@intel.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Haozhong Zhang , xen-devel@lists.xen.org, Jan Beulich , Kevin Tian Cc: Jun Nakajima , Andrew Cooper , Keir Fraser , Aravind Gopalakrishnan , Suravee Suthikulpanit List-Id: xen-devel@lists.xenproject.org On 02/22/2016 09:04 PM, Haozhong Zhang wrote: > > + if ( cpu_has_tsc_ratio ) > + svm_function_table.tsc_scaling.ratio_frac_bits = 32; > + > > +#define hvm_tsc_scaling_supported \ > + (!!hvm_funcs.tsc_scaling.ratio_frac_bits) > + What is the difference (in usage) between cpu_has_tsc_ratio and hvm_tsc_scaling_supported? Isn't the first imply the second (and if yes then what's the reason for having the latter)? -boris