All of lore.kernel.org
 help / color / mirror / Atom feed
From: Felix Fietkau <nbd@openwrt.org>
To: Johannes Berg <johannes@sipsolutions.net>,
	Janusz Dziedzic <janusz.dziedzic@tieto.com>,
	linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/2] mac80211: add NEED_ALIGNED4_SKBS hw flag
Date: Tue, 23 Feb 2016 15:53:17 +0100	[thread overview]
Message-ID: <56CC725D.1080209@openwrt.org> (raw)
In-Reply-To: <1456237769.9910.20.camel@sipsolutions.net>

On 2016-02-23 15:29, Johannes Berg wrote:
> On Fri, 2016-02-19 at 11:01 +0100, Janusz Dziedzic wrote:
>> HW/driver should set NEED_ALIGNED4_SKBS flag in case
>> require aligned skbs to four-byte boundaries.
>> This affect only TX direction.
>> 
>> Padding is added after ieee80211_hdr, before IV/LLC.
> 
> I'm still not super happy with how invasive these patches are.
> 
> Perhaps we could live with this being done only for the fast-xmit case?
I don't think we should pass padded vs non-padded frames depending on
whether fast-xmit was used. The non-fast-xmit codepath could simply do
the memmove at the end of the tx handlers though.

- Felix

  reply	other threads:[~2016-02-23 14:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-19 10:01 [PATCH 1/2] mac80211: add hdrlen to ieee80211_tx_data Janusz Dziedzic
2016-02-19 10:01 ` [PATCH 2/2] mac80211: add NEED_ALIGNED4_SKBS hw flag Janusz Dziedzic
2016-02-23 14:29   ` Johannes Berg
2016-02-23 14:53     ` Felix Fietkau [this message]
2016-02-23 16:15       ` Johannes Berg
2016-04-05 12:26         ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56CC725D.1080209@openwrt.org \
    --to=nbd@openwrt.org \
    --cc=janusz.dziedzic@tieto.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.