From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jon Hunter Subject: Re: [PATCH] regulator: core: fix error path of regulator_ena_gpio_free Date: Wed, 24 Feb 2016 09:20:19 +0000 Message-ID: <56CD75D3.3070805@nvidia.com> References: <56CC7863.4080202@nvidia.com> <1456302479-14045-1-git-send-email-krzysztof.adamski@tieto.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1456302479-14045-1-git-send-email-krzysztof.adamski-++hxYGjEMp0AvxtiuMwx3w@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Krzysztof Adamski , Mark Brown , "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Linux Kernel Mailing List List-Id: linux-tegra@vger.kernel.org On 24/02/16 08:27, Krzysztof Adamski wrote: > This problem was introduced by: > commit daad134d6649 ("regulator: core: Request GPIO before creating > sysfs entries") > > The error path was not updated correctly and in case > regulator_ena_gpio_free failed, device_unregister was called even though > it was not registered yet. > > Signed-off-by: Krzysztof Adamski > Reported-by: Jon Hunter Make sure you tag the patch as V2, etc, so that Mark knows which version to pick up. Jon From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752150AbcBXJU2 (ORCPT ); Wed, 24 Feb 2016 04:20:28 -0500 Received: from hqemgate15.nvidia.com ([216.228.121.64]:3950 "EHLO hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751022AbcBXJUZ (ORCPT ); Wed, 24 Feb 2016 04:20:25 -0500 X-PGP-Universal: processed; by hqnvupgp07.nvidia.com on Wed, 24 Feb 2016 01:19:21 -0800 Subject: Re: [PATCH] regulator: core: fix error path of regulator_ena_gpio_free To: Krzysztof Adamski , Mark Brown , "linux-tegra@vger.kernel.org" , Linux Kernel Mailing List References: <56CC7863.4080202@nvidia.com> <1456302479-14045-1-git-send-email-krzysztof.adamski@tieto.com> From: Jon Hunter Message-ID: <56CD75D3.3070805@nvidia.com> Date: Wed, 24 Feb 2016 09:20:19 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1456302479-14045-1-git-send-email-krzysztof.adamski@tieto.com> X-Originating-IP: [10.21.132.159] X-ClientProxiedBy: UKMAIL101.nvidia.com (10.26.138.13) To UKMAIL102.nvidia.com (10.26.138.15) Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24/02/16 08:27, Krzysztof Adamski wrote: > This problem was introduced by: > commit daad134d6649 ("regulator: core: Request GPIO before creating > sysfs entries") > > The error path was not updated correctly and in case > regulator_ena_gpio_free failed, device_unregister was called even though > it was not registered yet. > > Signed-off-by: Krzysztof Adamski > Reported-by: Jon Hunter Make sure you tag the patch as V2, etc, so that Mark knows which version to pick up. Jon