From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35890) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aYedh-0002XH-Gv for qemu-devel@nongnu.org; Wed, 24 Feb 2016 13:58:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aYede-0001wI-C4 for qemu-devel@nongnu.org; Wed, 24 Feb 2016 13:58:21 -0500 Received: from mx1.redhat.com ([209.132.183.28]:39118) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aYede-0001uS-75 for qemu-devel@nongnu.org; Wed, 24 Feb 2016 13:58:18 -0500 References: <1456237112-32662-1-git-send-email-peter.maydell@linaro.org> <1456237112-32662-2-git-send-email-peter.maydell@linaro.org> From: Thomas Huth Message-ID: <56CDFD42.6050906@redhat.com> Date: Wed, 24 Feb 2016 19:58:10 +0100 MIME-Version: 1.0 In-Reply-To: <1456237112-32662-2-git-send-email-peter.maydell@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/4] slirp/slirp.h: Remove now-empty #ifdefs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , qemu-devel@nongnu.org Cc: patches@linaro.org On 23.02.2016 15:18, Peter Maydell wrote: > After automatic cleanup to remove unnecessary #includes of headers that > osdep.h provides, slirp.h has a few now unnecessary #ifdef/#endif pairs; > remove them. > > Signed-off-by: Peter Maydell > --- > slirp/slirp.h | 24 ------------------------ > 1 file changed, 24 deletions(-) > > diff --git a/slirp/slirp.h b/slirp/slirp.h > index 07c13b4..7cfcf63 100644 > --- a/slirp/slirp.h > +++ b/slirp/slirp.h ... > @@ -98,12 +80,6 @@ void free(void *ptr); > #include > #endif > > -#ifdef __STDC__ > -#else > -#include > -#endif That else branch isn't really empty ... OTOH, QEMU likely does not compile with a non-STDC-compliant compiler anyway, so I assume this is ok. Reviewed-by: Thomas Huth