From mboxrd@z Thu Jan 1 00:00:00 1970 From: Haggai Eran Subject: Re: [PATCHv6 1/3] rdmacg: Added rdma cgroup controller Date: Thu, 25 Feb 2016 16:42:01 +0200 Message-ID: <56CF12B9.5060709@mellanox.com> References: <1455966006-13774-1-git-send-email-pandit.parav@gmail.com> <1455966006-13774-2-git-send-email-pandit.parav@gmail.com> <56CDAC7A.6030206@mellanox.com> <56CEED81.7010507@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Parav Pandit Cc: cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Tejun Heo , lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org, Johannes Weiner , Doug Ledford , Liran Liss , "Hefty, Sean" , Jason Gunthorpe , Jonathan Corbet , james.l.morris-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org, serge-A9i7LUbDfNHQT0dZR+AlfA@public.gmane.org, Or Gerlitz , Matan Barak , raindel-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org, akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, linux-security-module-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rdma@vger.kernel.org On 25/02/2016 16:26, Parav Pandit wrote: >> Can we call kfree() with spin_lock held? All these years I tend to >> avoid doing so. > Also it doesn't look correct to hold the lock while freeing the memory > which is totally unrelated to the lock. > With that I think current code appears ok with exception that its > duplicated at two place for code readability around lock. > What say? Yes, the only thing that bothered me there was the duplication. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933080AbcBYOmT (ORCPT ); Thu, 25 Feb 2016 09:42:19 -0500 Received: from mail-am1on0069.outbound.protection.outlook.com ([157.56.112.69]:53057 "EHLO emea01-am1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1760610AbcBYOmP (ORCPT ); Thu, 25 Feb 2016 09:42:15 -0500 Authentication-Results: spf=pass (sender IP is 193.47.165.134) smtp.mailfrom=mellanox.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=pass action=none header.from=mellanox.com; Subject: Re: [PATCHv6 1/3] rdmacg: Added rdma cgroup controller To: Parav Pandit References: <1455966006-13774-1-git-send-email-pandit.parav@gmail.com> <1455966006-13774-2-git-send-email-pandit.parav@gmail.com> <56CDAC7A.6030206@mellanox.com> <56CEED81.7010507@mellanox.com> CC: , , , , Tejun Heo , , Johannes Weiner , Doug Ledford , Liran Liss , "Hefty, Sean" , Jason Gunthorpe , Jonathan Corbet , , , Or Gerlitz , Matan Barak , , , From: Haggai Eran Message-ID: <56CF12B9.5060709@mellanox.com> Date: Thu, 25 Feb 2016 16:42:01 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.0.52.254] X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CPI:193.47.165.134;IPV:NLI;CTRY:IL;EFV:NLI;SFV:NSPM;SFS:(10009020)(979002)(6009001)(2980300002)(189002)(24454002)(479174004)(199003)(50986999)(50466002)(230700001)(87266999)(36756003)(2906002)(54356999)(93886004)(76176999)(4326007)(65816999)(110136002)(97736004)(189998001)(4001350100001)(47776003)(1096002)(23676002)(80316001)(83506001)(77096005)(64126003)(586003)(1220700001)(2950100001)(5004730100002)(59896002)(92566002)(3846002)(33656002)(106466001)(6116002)(6806005)(86362001)(65806001)(65956001)(87936001)(11100500001)(5008740100001)(3940600001)(969003)(989001)(999001)(1009001)(1019001);DIR:OUT;SFP:1101;SCL:1;SRVR:DB5PR05MB1029;H:mtlcas13.mtl.com;FPR:;SPF:None;MLV:ovrnspm;MX:1;A:1;PTR:ErrorRetry;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;AM1FFO11FD047;1:5I7knsGsr1McDDsjNU4lk36y0X3z81PGInw0nE1rm4oVCrNDeu/hE4FvL5pYomrQoqq2kRF9PujETm3PwrigWN6iydEXrX2P6D8VhuHODUPskY7eNLNxxr3C4Kf4OEA/G7g3Gmj1jWUIe8RN9VjrVumWOf5qqJ0+lQlthEV9aLiYchPzqDvwZAsLI8adNhd3/XH6s75Mq3WOgj0fnHZ3UlGY27tKwTQwSN7jDDpquHa54mNsdJJ57XCqlEC5Ge7tPP/4HRSm1Og2CwshH+OfcVpc2U+4bz3YPFOivVlsUWL9k/J/XWOuGL4aoB3zOH7rw/QC5fFIjG4iv1GUq64XTt7stBWaX+T9rQ58MCyODkFEJNKiKqL9sFT+ypI4qrRFLf9gZjpuLVZG7EFHozPx99CBkZFlI4vXjTpyftEXXY9OeXA/CdnfPc9C4MLXvEUlDSUu3qFbeuK3vlMh4XiCW6O2ls/VURXumxBLdML+aATdLwU5D3qHoTMzWYtP36uG X-Microsoft-Exchange-Diagnostics: 1;DB5PR05MB1029;2:Y0Ngp8BLpxoUUuMs2RyGYa1619qYA1QaPNBk49slCSRwz/b6Rp+Nj/0FaxTCy2VJqKTzaJc6nvz1wmLkjw7RMtcYl7O5ctSh8Rs08NpwIbBQXJRi/tcarK1mHymFF+nbk/OyMzgA89AIdj1P/T/mBw==;3:bPrdAalJH9gzpG2v+w3N8lCER1vXn8POqLDYhfhjRBhpFeC2/6BcKdC0XFMKlDWg/REi4rPmHMtIXOXDo64QsOGWtDOZPk3hHNO7jruw+H6Fu7icL+xpTQSlKHPVIzExR+fLANMTH0Zx+d/zQ/yKJMtqtJQnHYJ6OjO9rsKsv0NXVaTDE4bL3xmBTXDg9k+nISZIukWCVQtrzIowpeMBBQ==;25:boTKo02QIP2xc7exdZDV+z4QCbvXOoW+izMXT98VrcYmojprL/GnMdVHnQh/h+TtunVTKDuf0FfgFOpHqauLtqPfPWbB3Gjsx5v/dklTtm3T/S+Npz+wrfptg66jzdL1pBIcf1IGE/ktHb0kET66oRXs8Mkl9NCUw7HYFxUS8Zz4OKbd27ofimkqWaarVxJV4W1QCDno37wlSJ/5xPLlmuWjcgqIM1SOHHzSENYB0eo2doar1ivpOrmPcqV+kMOxGUnn/fkNM6tu3wEriL8mPjHx+YibQjf9RzSBWVehM97Q0x16e/QEMvLncnaLDsUG8G8/+x+XETudPaIv8mkWag== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501001);SRVR:DB5PR05MB1029; X-MS-Office365-Filtering-Correlation-Id: 95dda142-9875-4fbd-c0dd-08d33df1d692 X-Microsoft-Exchange-Diagnostics: 1;DB5PR05MB1029;20:INWKNKURkuiJ3gkOwePBUCwjc6Fd5+bBTk5gYYHg7hTQTxhcPDeqCyMYszGNwY1DVxy4ljW6F+WBmkV00idtx1+gCX5umlLENLQNKnXIBC8UIl/rj1tdWdrgBmE2Inb38FBOlleOcrl9zN4aE37m9fmChScMje/b23kJWKmidQB2QT0+rNcRmlac4j/c6b7usBQk0Kbzv3raTGbJ6kLHL9S5Zq+ZIl4GxtqyNuvruSjhPt3sttCk7Zhv8YgID5mHwBkF01MhL4qLLnwAHktLPe7Ngcm+7yFPOFUXC1Fv6JT0BRbJX7+JSttvIRT4CU3LCEdVIxrVn37+J5t5l4xaVL0zTAB3TnNFKOciUOoPUmNDZgb9p8iVlgAfnAiTqVhxZBnp9wUXHWBT2F7+3TFxTyokyZSn3o8WMujMEAKz5HXd6ZrG2vfSirC1fW3fR/Tzb42SZbJz63iOD7q7UbdXu7BLmDnRDuv0gyxEvo4cXOVFfYW2DL0LedOJ6Zt4a5+h X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(13023025)(13017025)(13018025)(13024025)(13015025)(3002001)(10201501046);SRVR:DB5PR05MB1029;BCL:0;PCL:0;RULEID:;SRVR:DB5PR05MB1029; X-Microsoft-Exchange-Diagnostics: 1;DB5PR05MB1029;4:3Vu4u/fgfLZx4xxlJK8OPsnuwXMeXrfcL2IFytnqNANK0w1izIkyy7Yfrs+B33WXN4hPsczd1kC/TrzxN2qRnvny5+a09xGzwPiBrJFD39ffup8luvZ9WlHqIIYn1hyCqhm1Sw5xHSmLzHiG2T8lWscDxBdKZzPjigz2IVuYzaFYGYONxRHvqnPJtnMV5Mdwp8gyzKNgYaH67BzSYGOoZfdZqZzxfHqPxBvF2upED4fRAglGPD/zdfYkCeGUef6eLnkLeFSn+M/Rha82tnLoe2OlXQ9diKCYZMPwRfoRRqTv80VvNQC8HofUGTI5Am+CZOjfScQ0Q05k3d6EJnA80wR4BIsxCowgY9wGvzYLwv3jx4Ww4D7cKvfvjzb+ya8hZjfu/4TBb7TsA/4pSbtdiC21sJlg0j3iRNAgjqRI1zsC2YtESvlSQxiWUcbU8o3zUT1+tM4CQi9AZ/DdNL94qw== X-Forefront-PRVS: 08635C03D4 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtEQjVQUjA1TUIxMDI5OzIzOm83UXVLTy90TjNEZG1HNzk0UEg5LzNkakp1?= =?utf-8?B?S09ia1hQTUhBTTNDZDBVeTM2V0dST3pRWjdrd0o5WjJnK1ZnR3VhdmNPRVRT?= =?utf-8?B?ZGlTQjJJUm85Y1RPTGY0VlpXekpqaTJ2UFkzU2RKSUI0N2RNaXNpT1lLOWU2?= =?utf-8?B?WGhxZlNZcmt3ajUwUlJ6anN2WEh0ejJrdGVYMEJMU0xGdFUyWFdFWHh2WDlM?= =?utf-8?B?cXBxbDBWZzJ2Tnp4UyszQ3BuTXY3YmZXWDJTOFhIZmdHVzN5Q0xTQ2F3QVJF?= =?utf-8?B?dEVLd3ZmdUNtT1QwYUpRMFZVT1hwL3NaVmozcFh6WlRoUkhJNGZYZEt6UFRj?= =?utf-8?B?MW53MzIrOUszaVY0SGU5QThPYzkxYmtyMmhTc2lJR2kwaUdYOVllK2xqSk1w?= =?utf-8?B?K2hWYlhleWV3MEdLV0pIbmFrSDE4YXpIQmNrRmZsWWVzMm5LY2lCSmgwcW9X?= =?utf-8?B?QS9TTnZNMlBJdGNvRDlyODR2dDRBUFpKZWRYeFhOL0cyclRGUi9VaFdRUGYv?= =?utf-8?B?dnk3WG9ibWlPcSs4MXdrYmt5WCtmVUF0WDRpVUxVdVY1bEcwSFNRdko2RFBt?= =?utf-8?B?MXI4QzJOS2ZOcmZUaklmUDFCVzBiUXFTdlh1cjRKQnZ5SnhkSGR1NEV0ZjRh?= =?utf-8?B?ZVhhclN3VWRRV2hWTVNOWk51ZFRpOERkd1lnRHRzTFNFYmxqN3BDWWpFcVhT?= =?utf-8?B?VW8vU2xxc3kwbzlVVjc4N2xCVFdGSE1DOFdmUldSZktKeDhmVVUyU0x5Skhw?= =?utf-8?B?amN5Z0JTcEFPblowS3d1MTVkV3pjZjhXM3FVVnV4RXk2dlM3TU54OGZMak9r?= =?utf-8?B?d2tmRWZmakFoc0lOMzVvc1M2clZ2YjQ1RURuR2thQXk0d0VqeUgwWDM0VWNy?= =?utf-8?B?d1Z3OFFxTUY0K2VkMWpIOU01UGNwUTBCZFRQM25aUkdJaVQ0dituMjdjb3Bm?= =?utf-8?B?WUd3a2E0R1pObmRYa1JYZUgyb1ZzZVZPY1BmZWNxU2wvYTcrcytwNURQb0xT?= =?utf-8?B?bnhPSE5OcUFmSUtPVUN1Uml4WjlTK1JiL3VKSjA3TTA1aUMzS0xNdjJoWGRL?= =?utf-8?B?cXltajJXeVh0bDc1SVdEUWNONm03a0M0K2o0b0NEa01WM1g5aEN0dldZRVVs?= =?utf-8?B?S3Q5Q3IyTFdkaUlwaUFCTDNlWlpVS2d2UVlDLzF3QURIaGxETmYrbjkzMWNw?= =?utf-8?B?NUQzanQ4ajJXQjZuZVM4bmVXQVIzbDU0NXg4VXk0bEluTUhNTWlLSHcyQzZG?= =?utf-8?B?MlhLU1c2eTE4Wms4bWoxRFNpQ1FzeU4vOGpldHFPUEFETytXYkhKWFM3WC91?= =?utf-8?B?L0paKzZnUUtaZE9HTEZCYTd0Mks1aks5UVl6RHk5a0xhV0M1L1N4bytDbXp0?= =?utf-8?B?bzNjanhUTE5tTFRRS3NIaUtIYUdJcWFwNzFrOEJ5V0FNVHdpSGFCL3N0cThh?= =?utf-8?B?OTE0ejU2UHZkOHVWelpiNTNZU09nZ2xzRkQ4UVJkcHY0Wmt1K2R5RHpBZjN0?= =?utf-8?B?OHF0bHFMQzMxcFBBaFNUSjY3MnRZOWhub1R4NDFFOU5LM09ucDdoS1JSc25r?= =?utf-8?B?VW5GRHdXcjFhaUR6dS95RFljZExpQklXSWhzSXhqUWFYYlRlL3NrNWVzU0th?= =?utf-8?B?dlNFUVhqVXN3S3pjVmdvMEZocjgwWFpFV3RKTVlXUENzdlVZcXRRNitpUXJs?= =?utf-8?Q?Oe2T8yWvHfCuMjBGgsxt28MpY/vArgtT19PNODK?= X-Microsoft-Exchange-Diagnostics: 1;DB5PR05MB1029;5:gWyvQBNkmcAmejnIOPrJyKF/ncb50LsE08XlH+KIwBsBw9LyZGCGqi1PYWCSfZvGJlLiExjLjHKwAZGLK/I19g2uXmXarp4T06V5GMyfQEYDBMHJmJQ1S23H0Vw4GXP11udGOPlyKLUadCk/fqQNjQ==;24:1lHz/7bdmq1oObuVseJ4a/9YtyMDDEgLr6EOeJBKxKXhTFXgNwWjsAgk2+dJIG+/UwFIoIoXD2NpHlmg6v1ZEWzYHQMcZqkXAj65ka4Jpkc= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Feb 2016 14:42:08.3854 (UTC) X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=a652971c-7d2e-4d9b-a6a4-d149256f461b;Ip=[193.47.165.134];Helo=[mtlcas13.mtl.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR05MB1029 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25/02/2016 16:26, Parav Pandit wrote: >> Can we call kfree() with spin_lock held? All these years I tend to >> avoid doing so. > Also it doesn't look correct to hold the lock while freeing the memory > which is totally unrelated to the lock. > With that I think current code appears ok with exception that its > duplicated at two place for code readability around lock. > What say? Yes, the only thing that bothered me there was the duplication.