From: "YOSHIFUJI Hideaki/吉藤英明" <hideaki.yoshifuji@miraclelinux.com>
To: Deepa Dinamani <deepa.kernel@gmail.com>
Cc: hideaki.yoshifuji@miraclelinux.com,
Linux Network Devel Mailing List <netdev@vger.kernel.org>,
y2038@lists.linaro.org, Arnd Bergmann <arnd@arndb.de>,
John Stultz <john.stultz@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
"David S. Miller" <davem@davemloft.net>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
James Morris <jmorris@namei.org>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Patrick McHardy <kaber@trash.net>
Subject: Re: [PATCH 1/4] kernel: time: Add current_nw_timestamp() for network timestamps
Date: Fri, 26 Feb 2016 15:49:05 +0900 [thread overview]
Message-ID: <56CFF561.4050805@miraclelinux.com> (raw)
In-Reply-To: <CABeXuvpzFzj094YKhweoCO+BUaxGAP+dYjPZozA01z94=gVaMA@mail.gmail.com>
Hi,
Deepa Dinamani wrote:
>>> include/linux/ip.h | 2 ++
>>> include/linux/time64.h | 3 +++
>>> kernel/time/time.c | 26 ++++++++++++++++++++++++++
>>> 3 files changed, 31 insertions(+)
>>>
>> Since net/ipv4/* are the only users, it is enough to put
>> it in under net/ipv4/.
>
> time.c hosts functions that are used by individual subsystems like
> current_fs_time() used by filesystems
> (sometimes used by other subsystems also).
>
> The network timestamp function is used for both source route ip option
> and timestamp icmp messages.
> So it makes it difficult for it to be owned by a single layer.
> This is the reason it was chosen to include here.
>
> Another option is to include it in the lowest layer its used:
> af_inet.c. Is this what you were suggesting?
>
Yes, that's right.
--yoshfuji
> -Deepa
>
next prev parent reply other threads:[~2016-02-26 6:49 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-25 7:07 [PATCH 0/4] Convert network timestamps to be y2038 safe Deepa Dinamani
2016-02-25 7:07 ` Deepa Dinamani
2016-02-25 7:07 ` [PATCH 1/4] kernel: time: Add current_nw_timestamp() for network timestamps Deepa Dinamani
2016-02-25 8:49 ` YOSHIFUJI Hideaki
2016-02-25 9:45 ` Deepa Dinamani
2016-02-26 6:49 ` YOSHIFUJI Hideaki/吉藤英明 [this message]
2016-02-25 14:56 ` [Y2038] " Arnd Bergmann
2016-02-25 7:07 ` [PATCH 2/4] net: ipv4: Use y2038 safe functions and data structures Deepa Dinamani
2016-02-25 14:57 ` Arnd Bergmann
2016-02-25 7:07 ` [PATCH 3/4] net: ipv4: tcp_probe: Replace timespec with timespec64 Deepa Dinamani
2016-02-25 15:01 ` Arnd Bergmann
2016-02-27 2:56 ` Deepa Dinamani
2016-02-25 7:07 ` [PATCH 4/4] net: sctp: Convert log timestamps to be y2038 safe Deepa Dinamani
2016-02-25 7:07 ` Deepa Dinamani
2016-02-25 14:09 ` Neil Horman
2016-02-25 14:09 ` Neil Horman
2016-02-25 14:56 ` [Y2038] " Arnd Bergmann
2016-02-25 14:56 ` Arnd Bergmann
2016-02-26 20:19 ` [PATCH 0/4] Convert network " David Miller
2016-02-26 20:19 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56CFF561.4050805@miraclelinux.com \
--to=hideaki.yoshifuji@miraclelinux.com \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=deepa.kernel@gmail.com \
--cc=jmorris@namei.org \
--cc=john.stultz@linaro.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=y2038@lists.linaro.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.