From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48440) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aZEiq-0007x9-V8 for qemu-devel@nongnu.org; Fri, 26 Feb 2016 04:30:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aZEim-0001wr-0K for qemu-devel@nongnu.org; Fri, 26 Feb 2016 04:30:04 -0500 Received: from mail-wm0-x233.google.com ([2a00:1450:400c:c09::233]:34337) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aZEil-0001wT-PU for qemu-devel@nongnu.org; Fri, 26 Feb 2016 04:29:59 -0500 Received: by mail-wm0-x233.google.com with SMTP id b205so64410955wmb.1 for ; Fri, 26 Feb 2016 01:29:59 -0800 (PST) Sender: Paolo Bonzini References: <1456237462-3687-1-git-send-email-kraxel@redhat.com> <1456237462-3687-3-git-send-email-kraxel@redhat.com> From: Paolo Bonzini Message-ID: <56D01B13.9090407@redhat.com> Date: Fri, 26 Feb 2016 10:29:55 +0100 MIME-Version: 1.0 In-Reply-To: <1456237462-3687-3-git-send-email-kraxel@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PULL 2/8] configure: add dma-buf support detection. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann , qemu-devel@nongnu.org On 23/02/2016 15:24, Gerd Hoffmann wrote: > Set CONFIG_OPENGL_DMABUF in case both mesa and libepoxy are > new enough to have support for dma-buf import/export. > > Signed-off-by: Gerd Hoffmann > Reviewed-by: Marc-André Lureau > --- > configure | 20 +++++++++++++++++++- > 1 file changed, 19 insertions(+), 1 deletion(-) > > diff --git a/configure b/configure > index 0aa249b..0c0472a 100755 > --- a/configure > +++ b/configure > @@ -279,6 +279,7 @@ smartcard="" > libusb="" > usb_redir="" > opengl="" > +opengl_dmabuf="no" > zlib="yes" > lzo="" > snappy="" > @@ -3274,7 +3275,7 @@ libs_softmmu="$libs_softmmu $fdt_libs" > # opengl probe (for sdl2, gtk, milkymist-tmu2) > > if test "$opengl" != "no" ; then > - opengl_pkgs="epoxy" > + opengl_pkgs="epoxy libdrm gbm" This disables OpenGL entirely if libdrm or mesa-libgbm is unavailable. Is it intentional? Thanks, Paolo > if $pkg_config $opengl_pkgs x11; then > opengl_cflags="$($pkg_config --cflags $opengl_pkgs) $x11_cflags" > opengl_libs="$($pkg_config --libs $opengl_pkgs) $x11_libs" > @@ -3292,6 +3293,18 @@ if test "$opengl" != "no" ; then > fi > fi > > +if test "$opengl" = "yes"; then > + cat > $TMPC << EOF > +#include > +#ifndef EGL_MESA_image_dma_buf_export > +# error mesa/epoxy lacks support for dmabufs (mesa 10.6+) > +#endif > +int main(void) { return 0; } > +EOF > + if compile_prog "" "" ; then > + opengl_dmabuf=yes > + fi > +fi > > ########################################## > # archipelago probe > @@ -4752,6 +4765,7 @@ echo "smartcard support $smartcard" > echo "libusb $libusb" > echo "usb net redir $usb_redir" > echo "OpenGL support $opengl" > +echo "OpenGL dmabufs $opengl_dmabuf" > echo "libiscsi support $libiscsi" > echo "libnfs support $libnfs" > echo "build guest agent $guest_agent" > @@ -5050,6 +5064,7 @@ if test "$gtk" = "yes" ; then > echo "CONFIG_GTK=y" >> $config_host_mak > echo "CONFIG_GTKABI=$gtkabi" >> $config_host_mak > echo "GTK_CFLAGS=$gtk_cflags" >> $config_host_mak > + echo "GTK_LIBS=$gtk_libs" >> $config_host_mak > if test "$gtk_gl" = "yes" ; then > echo "CONFIG_GTK_GL=y" >> $config_host_mak > fi > @@ -5158,6 +5173,9 @@ if test "$opengl" = "yes" ; then > echo "CONFIG_OPENGL=y" >> $config_host_mak > echo "OPENGL_CFLAGS=$opengl_cflags" >> $config_host_mak > echo "OPENGL_LIBS=$opengl_libs" >> $config_host_mak > + if test "$opengl_dmabuf" = "yes" ; then > + echo "CONFIG_OPENGL_DMABUF=y" >> $config_host_mak > + fi > fi > > if test "$lzo" = "yes" ; then >