All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@suse.com>
To: Shannon Zhao <zhaoshenglong@huawei.com>
Cc: ian.campbell@citrix.com, "Rafael J. Wysocki" <rjw@rjwysocki.net>,
	peter.huangpeng@huawei.com, xen-devel@lists.xen.org,
	stefano.stabellini@citrix.com, shannon.zhao@linaro.org
Subject: Re: [PATCH v5 07/22] ACPI / table: Print GIC information when MADT is parsed
Date: Fri, 26 Feb 2016 02:39:34 -0700	[thread overview]
Message-ID: <56D02B6602000078000D68FA@prv-mh.provo.novell.com> (raw)
In-Reply-To: <1456467780-8476-8-git-send-email-zhaoshenglong@huawei.com>

>>> On 26.02.16 at 07:22, <zhaoshenglong@huawei.com> wrote:
> From: Hanjun Guo <hanjun.guo@linaro.org>
> 
> When MADT is parsed, print GIC information as debug message:
> 
> ACPI: GICC (acpi_id[0x0000] address[00000000e112f000] MPIDR[0x0] enabled)
> ACPI: GICC (acpi_id[0x0001] address[00000000e112f000] MPIDR[0x1] enabled)
> ...
> ACPI: GICC (acpi_id[0x0201] address[00000000e112f000] MPIDR[0x201] enabled)
> 
> This debug information will be very helpful to bring up early systems to
> see if acpi_id and MPIDR are matched or not as spec defined.
> 
> CC: Rafael J. Wysocki <rjw@rjwysocki.net>
> Tested-by: Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>
> Tested-by: Yijing Wang <wangyijing@huawei.com>
> Tested-by: Mark Langsdorf <mlangsdo@redhat.com>
> Tested-by: Jon Masters <jcm@redhat.com>
> Tested-by: Timur Tabi <timur@codeaurora.org>
> Tested-by: Robert Richter <rrichter@cavium.com>
> Acked-by: Robert Richter <rrichter@cavium.com>
> Acked-by: Sudeep Holla <sudeep.holla@arm.com>
> Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> Acked-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> Acked-by: Grant Likely <grant.likely@linaro.org>
> Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org>
> Signed-off-by: Tomasz Nowicki <tomasz.nowicki@linaro.org>
> Signed-off-by: Will Deacon <will.deacon@arm.com>
> [Linux commit 4c1c8d7a7ebc8b909493a14b21b233e5377b69aa]
> [Use container_of instead of cast and PRIx64 instead of %llx]
> Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org>

A note on this bazillion of tags: I think Tested-by should
unconditionally be dropped when coming from a Linux commit. I
also think retaining Acked-by doesn't make much sense (and may
be actively misleading if it came from a person who is maintainer
of parts of our code). Same would go for Reviewed-by, which we
don't have here. And for the Signed-off-by I think only the original
author's and yours are relevant, unless the others mean actual
changes were done (i.e. they didn't just get added because the
patch passed their hands). This may not always be easy to tell, so
I don't take this last aspect very strictly, but when pulling in Linux
changes myself, I usually try to guess.

No reason to re-submit, though, I'll take care of stripping what I
think should be stripped when committing.

> V5: port this change from Linux

I much appreciate that while doing so you converted to container_of().

Thanks, Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  reply	other threads:[~2016-02-26  9:39 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-26  6:22 [PATCH v5 00/22] Add ACPI support for Xen itself on ARM64 Shannon Zhao
2016-02-26  6:22 ` [PATCH v5 01/22] arm/acpi: Emulate io ports for arm Shannon Zhao
2016-02-26 12:00   ` Stefano Stabellini
2016-02-26  6:22 ` [PATCH v5 02/22] arm/acpi: Add arm specific acpi header file Shannon Zhao
2016-02-26  6:22 ` [PATCH v5 03/22] arm/acpi: Add __acpi_map_table function for ARM Shannon Zhao
2016-02-26 14:12   ` Stefano Stabellini
2016-02-26 16:29     ` Jan Beulich
2016-02-26 16:30       ` Stefano Stabellini
2016-02-27  6:29   ` [PATCH v6 " Shannon Zhao
2016-02-29 10:54     ` Stefano Stabellini
2016-02-29 11:38       ` Jan Beulich
2016-02-29 11:43         ` Stefano Stabellini
2016-02-29 11:53           ` Jan Beulich
2016-02-29 11:56             ` Stefano Stabellini
2016-02-29 12:05               ` Jan Beulich
2016-02-29 20:29     ` [PATCH v7 " Shannon Zhao
2016-03-01 10:08       ` Jan Beulich
2016-02-26  6:22 ` [PATCH v5 04/22] arm/acpi: Add basic ACPI initialization Shannon Zhao
2016-02-26 13:39   ` Stefano Stabellini
2016-02-26  6:22 ` [PATCH v5 05/22] arm/acpi: Move end_boot_allocator after acpi_boot_table_init Shannon Zhao
2016-02-26 12:08   ` Stefano Stabellini
2016-02-26  6:22 ` [PATCH v5 06/22] arm/acpi: Parse FADT table and get PSCI flags Shannon Zhao
2016-02-26 12:10   ` Stefano Stabellini
2016-02-26  6:22 ` [PATCH v5 07/22] ACPI / table: Print GIC information when MADT is parsed Shannon Zhao
2016-02-26  9:39   ` Jan Beulich [this message]
2016-02-26  6:22 ` [PATCH v5 08/22] arm/acpi: Parse MADT to map logical cpu to MPIDR and get cpu_possible_map Shannon Zhao
2016-02-26  9:49   ` Jan Beulich
2016-02-26 10:18     ` Shannon Zhao
2016-02-26 12:18   ` Stefano Stabellini
2016-02-27  6:33   ` [PATCH v6 " Shannon Zhao
2016-02-29 12:38     ` Jan Beulich
2016-02-26  6:22 ` [PATCH v5 09/22] arm/acpi: Add ACPI support for SMP initialization Shannon Zhao
2016-02-26  6:22 ` [PATCH v5 10/22] acpi/table: Introduce acpi_table_get_entry_madt to get specified entry Shannon Zhao
2016-02-26  9:59   ` Jan Beulich
2016-02-27  6:37   ` [PATCH v6 " Shannon Zhao
2016-02-29 12:39     ` Jan Beulich
2016-02-26  6:22 ` [PATCH v5 11/22] arm: Introduce a generic way to use a device from acpi Shannon Zhao
2016-02-26  6:22 ` [PATCH v5 12/22] arm/irq: Drop the DT prefix of the irq line type Shannon Zhao
2016-02-26  6:22 ` [PATCH v5 13/22] arm/gic-v2: Add ACPI boot support for GICv2 Shannon Zhao
2016-02-26  6:22 ` [PATCH v5 14/22] arm/gic-v3: Add ACPI boot support for GICv3 Shannon Zhao
2016-02-26  6:22 ` [PATCH v5 15/22] arm/gic: Add ACPI support for GIC preinit Shannon Zhao
2016-02-26  6:22 ` [PATCH v5 16/22] arm/irq: Add helper function for setting interrupt type Shannon Zhao
2016-02-26  6:22 ` [PATCH v5 17/22] arm/acpi: Parse GTDT to initialize timer Shannon Zhao
2016-02-26  6:22 ` [PATCH v5 18/22] arm/acpi: Add a new ACPI initialized function for UART Shannon Zhao
2016-02-26 13:46   ` Stefano Stabellini
2016-02-26  6:22 ` [PATCH v5 19/22] ACPICA: Headers: Add support for CSRT and DBG2 ACPI tables Shannon Zhao
2016-02-26  6:22 ` [PATCH v5 20/22] arm/acpi: Initialize serial port from ACPI SPCR table Shannon Zhao
2016-02-26 10:04   ` Jan Beulich
2016-02-26 10:20     ` Shannon Zhao
2016-02-26 11:10       ` Shannon Zhao
2016-02-26 12:32         ` Jan Beulich
2016-02-26  6:22 ` [PATCH v5 21/22] arm/fdt: Export device_tree_for_each_node Shannon Zhao
2016-02-26  6:23 ` [PATCH v5 22/22] arm/acpi: Add acpi parameter to enable/disable acpi Shannon Zhao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56D02B6602000078000D68FA@prv-mh.provo.novell.com \
    --to=jbeulich@suse.com \
    --cc=ian.campbell@citrix.com \
    --cc=peter.huangpeng@huawei.com \
    --cc=rjw@rjwysocki.net \
    --cc=shannon.zhao@linaro.org \
    --cc=stefano.stabellini@citrix.com \
    --cc=xen-devel@lists.xen.org \
    --cc=zhaoshenglong@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.