From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754603AbcBZPRd (ORCPT ); Fri, 26 Feb 2016 10:17:33 -0500 Received: from mailapp01.imgtec.com ([195.59.15.196]:55511 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752174AbcBZPRc (ORCPT ); Fri, 26 Feb 2016 10:17:32 -0500 Subject: Re: [PATCH v3 07/52] mtd: nand: core: use mtd_ooblayout_xxx() helpers where appropriate To: Boris Brezillon References: <1456448280-27788-1-git-send-email-boris.brezillon@free-electrons.com> <1456448280-27788-8-git-send-email-boris.brezillon@free-electrons.com> <56D0629C.9080805@imgtec.com> <20160226161054.3477cd4b@bbrezillon> CC: David Woodhouse , Brian Norris , , Daniel Mack , Haojian Zhuang , "Robert Jarzmik" , Kukjin Kim , "Krzysztof Kozlowski" , , , Ralf Baechle , , Nicolas Ferre , Jean-Christophe Plagniol-Villard , Alexandre Belloni , Wenyou Yang , Josh Wu , Ezequiel Garcia , Maxime Ripard , Chen-Yu Tsai , , Stefan Agner , Kyungmin Park , Greg Kroah-Hartman , , , "punnaiah choudary kalluri" , Priit Laes , "Kamal Dasu" , , From: Harvey Hunt Message-ID: <56D06C88.9080608@imgtec.com> Date: Fri, 26 Feb 2016 15:17:28 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160226161054.3477cd4b@bbrezillon> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.154.40] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Boris, On 26/02/16 15:10, Boris Brezillon wrote: > Hi Harvey, > > On Fri, 26 Feb 2016 14:35:08 +0000 > Harvey Hunt wrote: > >> [...] >> I'll look into this more later today, but wanted to run it by you in >> case you have any thoughts. > > Can you apply this patch [1], and let me know if you see the additional > trace? I applied the patch, the following is the (unchanged) output: [ 0.256375] nand: device found, Manufacturer ID: 0x2c, Chip ID: 0x88 [ 0.262887] nand: Micron MT29F64G08CBAAAWP [ 0.266995] nand: 8192 MiB, MLC, erase size: 2048 KiB, page size: 8192, OOB size: 448 [ 0.274881] jz4780-nand 1b000000.nand-controller: using hardware BCH (strength 24, size 1024, bytes 42) [ 0.289046] Bad block table not found for chip 0 [ 0.297769] Bad block table not found for chip 0 [ 0.302425] Scanning device for bad blocks [ 0.320239] Bad eraseblock 90 at 0x00000b400000 [ 0.324934] Bad eraseblock 91 at 0x00000b600000 [ 0.931054] Bad eraseblock 4092 at 0x0001ff800000 [ 0.935917] Bad eraseblock 4093 at 0x0001ffa00000 [ 0.944660] nand_bbt: error while writing bad block table -34 [ 0.950448] jz4780-nand: probe of 1b000000.nand-controller failed with error -34 [ 0.958079] UBI error: cannot open mtd 3, error -19 [ 0.962788] UBI error: cannot open mtd 4, error -19[ 0.970229] clk: Not disabling unused clocks > > Thanks, > > Boris > > [1]http://code.bulix.org/l2hkl1-91947 > Thanks, Harvey From mboxrd@z Thu Jan 1 00:00:00 1970 From: Harvey Hunt Subject: Re: [PATCH v3 07/52] mtd: nand: core: use mtd_ooblayout_xxx() helpers where appropriate Date: Fri, 26 Feb 2016 15:17:28 +0000 Message-ID: <56D06C88.9080608@imgtec.com> References: <1456448280-27788-1-git-send-email-boris.brezillon@free-electrons.com> <1456448280-27788-8-git-send-email-boris.brezillon@free-electrons.com> <56D0629C.9080805@imgtec.com> <20160226161054.3477cd4b@bbrezillon> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160226161054.3477cd4b@bbrezillon> Sender: linux-samsung-soc-owner@vger.kernel.org To: Boris Brezillon Cc: David Woodhouse , Brian Norris , linux-mtd@lists.infradead.org, Daniel Mack , Haojian Zhuang , Robert Jarzmik , Kukjin Kim , Krzysztof Kozlowski , linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Ralf Baechle , linux-mips@linux-mips.org, Nicolas Ferre , Jean-Christophe Plagniol-Villard , Alexandre Belloni , Wenyou Yang , Josh Wu , Ezequiel Garcia , Maxime Ripard , Chen-Yu Tsai , linux-sunxi@googlegroups.com, Stefan Agner List-Id: linux-api@vger.kernel.org Hi Boris, On 26/02/16 15:10, Boris Brezillon wrote: > Hi Harvey, > > On Fri, 26 Feb 2016 14:35:08 +0000 > Harvey Hunt wrote: > >> [...] >> I'll look into this more later today, but wanted to run it by you in >> case you have any thoughts. > > Can you apply this patch [1], and let me know if you see the additional > trace? I applied the patch, the following is the (unchanged) output: [ 0.256375] nand: device found, Manufacturer ID: 0x2c, Chip ID: 0x88 [ 0.262887] nand: Micron MT29F64G08CBAAAWP [ 0.266995] nand: 8192 MiB, MLC, erase size: 2048 KiB, page size: 8192, OOB size: 448 [ 0.274881] jz4780-nand 1b000000.nand-controller: using hardware BCH (strength 24, size 1024, bytes 42) [ 0.289046] Bad block table not found for chip 0 [ 0.297769] Bad block table not found for chip 0 [ 0.302425] Scanning device for bad blocks [ 0.320239] Bad eraseblock 90 at 0x00000b400000 [ 0.324934] Bad eraseblock 91 at 0x00000b600000 [ 0.931054] Bad eraseblock 4092 at 0x0001ff800000 [ 0.935917] Bad eraseblock 4093 at 0x0001ffa00000 [ 0.944660] nand_bbt: error while writing bad block table -34 [ 0.950448] jz4780-nand: probe of 1b000000.nand-controller failed with error -34 [ 0.958079] UBI error: cannot open mtd 3, error -19 [ 0.962788] UBI error: cannot open mtd 4, error -19[ 0.970229] clk: Not disabling unused clocks > > Thanks, > > Boris > > [1]http://code.bulix.org/l2hkl1-91947 > Thanks, Harvey From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailapp01.imgtec.com ([195.59.15.196]:23314 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S27006830AbcBZPRfbj6B5 (ORCPT ); Fri, 26 Feb 2016 16:17:35 +0100 Subject: Re: [PATCH v3 07/52] mtd: nand: core: use mtd_ooblayout_xxx() helpers where appropriate References: <1456448280-27788-1-git-send-email-boris.brezillon@free-electrons.com> <1456448280-27788-8-git-send-email-boris.brezillon@free-electrons.com> <56D0629C.9080805@imgtec.com> <20160226161054.3477cd4b@bbrezillon> From: Harvey Hunt Message-ID: <56D06C88.9080608@imgtec.com> Date: Fri, 26 Feb 2016 15:17:28 +0000 MIME-Version: 1.0 In-Reply-To: <20160226161054.3477cd4b@bbrezillon> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Return-Path: Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: To: Boris Brezillon Cc: David Woodhouse , Brian Norris , linux-mtd@lists.infradead.org, Daniel Mack , Haojian Zhuang , Robert Jarzmik , Kukjin Kim , Krzysztof Kozlowski , linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Ralf Baechle , linux-mips@linux-mips.org, Nicolas Ferre , Jean-Christophe Plagniol-Villard , Alexandre Belloni , Wenyou Yang , Josh Wu , Ezequiel Garcia , Maxime Ripard , Chen-Yu Tsai , linux-sunxi@googlegroups.com, Stefan Agner , Kyungmin Park , Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, punnaiah choudary kalluri , Priit Laes , Kamal Dasu , bcm-kernel-feedback-list@broadcom.com, linux-api@vger.kernel.org Message-ID: <20160226151728.OTiHn_kx-fVoInDwCCa1wm_ehY3p-tzXyp02lthBW2s@z> Hi Boris, On 26/02/16 15:10, Boris Brezillon wrote: > Hi Harvey, > > On Fri, 26 Feb 2016 14:35:08 +0000 > Harvey Hunt wrote: > >> [...] >> I'll look into this more later today, but wanted to run it by you in >> case you have any thoughts. > > Can you apply this patch [1], and let me know if you see the additional > trace? I applied the patch, the following is the (unchanged) output: [ 0.256375] nand: device found, Manufacturer ID: 0x2c, Chip ID: 0x88 [ 0.262887] nand: Micron MT29F64G08CBAAAWP [ 0.266995] nand: 8192 MiB, MLC, erase size: 2048 KiB, page size: 8192, OOB size: 448 [ 0.274881] jz4780-nand 1b000000.nand-controller: using hardware BCH (strength 24, size 1024, bytes 42) [ 0.289046] Bad block table not found for chip 0 [ 0.297769] Bad block table not found for chip 0 [ 0.302425] Scanning device for bad blocks [ 0.320239] Bad eraseblock 90 at 0x00000b400000 [ 0.324934] Bad eraseblock 91 at 0x00000b600000 [ 0.931054] Bad eraseblock 4092 at 0x0001ff800000 [ 0.935917] Bad eraseblock 4093 at 0x0001ffa00000 [ 0.944660] nand_bbt: error while writing bad block table -34 [ 0.950448] jz4780-nand: probe of 1b000000.nand-controller failed with error -34 [ 0.958079] UBI error: cannot open mtd 3, error -19 [ 0.962788] UBI error: cannot open mtd 4, error -19[ 0.970229] clk: Not disabling unused clocks > > Thanks, > > Boris > > [1]http://code.bulix.org/l2hkl1-91947 > Thanks, Harvey From mboxrd@z Thu Jan 1 00:00:00 1970 From: harvey.hunt@imgtec.com (Harvey Hunt) Date: Fri, 26 Feb 2016 15:17:28 +0000 Subject: [PATCH v3 07/52] mtd: nand: core: use mtd_ooblayout_xxx() helpers where appropriate In-Reply-To: <20160226161054.3477cd4b@bbrezillon> References: <1456448280-27788-1-git-send-email-boris.brezillon@free-electrons.com> <1456448280-27788-8-git-send-email-boris.brezillon@free-electrons.com> <56D0629C.9080805@imgtec.com> <20160226161054.3477cd4b@bbrezillon> Message-ID: <56D06C88.9080608@imgtec.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Boris, On 26/02/16 15:10, Boris Brezillon wrote: > Hi Harvey, > > On Fri, 26 Feb 2016 14:35:08 +0000 > Harvey Hunt wrote: > >> [...] >> I'll look into this more later today, but wanted to run it by you in >> case you have any thoughts. > > Can you apply this patch [1], and let me know if you see the additional > trace? I applied the patch, the following is the (unchanged) output: [ 0.256375] nand: device found, Manufacturer ID: 0x2c, Chip ID: 0x88 [ 0.262887] nand: Micron MT29F64G08CBAAAWP [ 0.266995] nand: 8192 MiB, MLC, erase size: 2048 KiB, page size: 8192, OOB size: 448 [ 0.274881] jz4780-nand 1b000000.nand-controller: using hardware BCH (strength 24, size 1024, bytes 42) [ 0.289046] Bad block table not found for chip 0 [ 0.297769] Bad block table not found for chip 0 [ 0.302425] Scanning device for bad blocks [ 0.320239] Bad eraseblock 90 at 0x00000b400000 [ 0.324934] Bad eraseblock 91 at 0x00000b600000 [ 0.931054] Bad eraseblock 4092 at 0x0001ff800000 [ 0.935917] Bad eraseblock 4093 at 0x0001ffa00000 [ 0.944660] nand_bbt: error while writing bad block table -34 [ 0.950448] jz4780-nand: probe of 1b000000.nand-controller failed with error -34 [ 0.958079] UBI error: cannot open mtd 3, error -19 [ 0.962788] UBI error: cannot open mtd 4, error -19[ 0.970229] clk: Not disabling unused clocks > > Thanks, > > Boris > > [1]http://code.bulix.org/l2hkl1-91947 > Thanks, Harvey