From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrei Borzenkov Subject: Re: [PATCH v2 4/4] arm64: update the introduction of xen boot commands in docs/grub.texi Date: Sun, 28 Feb 2016 08:10:33 +0300 Message-ID: <56D28149.30907@gmail.com> References: <1456382355-24614-2-git-send-email-fu.wei@linaro.org> <1456382355-24614-5-git-send-email-fu.wei@linaro.org> <56CF3B24.6030605@gmail.com> <20160227203341.GM31035@char.us.oracle.com> Reply-To: The development of GNU GRUB Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20160227203341.GM31035@char.us.oracle.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: grub-devel-bounces+gcbgd-grub-devel=m.gmane.org@gnu.org Sender: grub-devel-bounces+gcbgd-grub-devel=m.gmane.org@gnu.org To: Konrad Rzeszutek Wilk , The development of GNU GRUB Cc: "xen-devel@lists.xensource.com" , Ian Campbell , Vladimir Serbinenko , Julien Grall , Leif Lindholm , Linaro UEFI Mailman List , Jon Masters List-Id: xen-devel@lists.xenproject.org MjcuMDIuMjAxNiAyMzozMywgS29ucmFkIFJ6ZXN6dXRlayBXaWxrINC/0LjRiNC10YI6Cj4gT24g RnJpLCBGZWIgMjYsIDIwMTYgYXQgMDc6MTU6NTJQTSArMDgwMCwgRnUgV2VpIHdyb3RlOgo+PiBI aSBBbmRyZWksCj4+Cj4+IE9uIDI2IEZlYnJ1YXJ5IDIwMTYgYXQgMTg6NTAsIEFuZHJlaSBCb3J6 ZW5rb3YgPGFydmlkamFhckBnbWFpbC5jb20+IHdyb3RlOgo+Pj4gT24gRnJpLCBGZWIgMjYsIDIw MTYgYXQgODo1OSBBTSwgRnUgV2VpIDxmdS53ZWlAbGluYXJvLm9yZz4gd3JvdGU6Cj4+Pj4+Pj4+ ICtAc3Vic2VjdGlvbiB4ZW5fbW9kdWxlCj4+Pj4+Pj4+Cj4+Pj4+Pj4+IC1AZGVmZm4gQ29tbWFu ZCB4ZW5fbGludXggZmlsZSBbYXJndW1lbnRzXQo+Pj4+Pj4+PiAtTG9hZCBhIGRvbTAga2VybmVs IGltYWdlIGZvciB4ZW4gaHlwZXJ2aXNvciBhdCB0aGUgYm9vdGluZyBwcm9jZXNzIG9mIHhlbi4K Pj4+Pj4+Pj4gK0BkZWZmbiBDb21tYW5kIHhlbl9tb2R1bGUgWy0tbm91bnppcF0gZmlsZSBbYXJn dW1lbnRzXQo+Pj4+Pj4+PiArTG9hZCBhIG1vZHVsZSBmb3IgeGVuIGh5cGVydmlzb3IgYXQgdGhl IGJvb3RpbmcgcHJvY2VzcyBvZiB4ZW4uCj4+Pj4+Pj4+IFRoZSByZXN0IG9mIHRoZSBsaW5lIGlz IHBhc3NlZCB2ZXJiYXRpbSBhcyB0aGUgbW9kdWxlIGNvbW1hbmQgbGluZS4KPj4+Pj4+Pj4gK0Vh Y2ggbW9kdWxlIHdpbGwgYmUgaWRlbnRpZmllZCBieSB0aGUgb3JkZXIgaW4gd2hpY2ggdGhlIG1v ZHVsZXMgYXJlIGFkZGVkLgo+Pj4+Pj4+PiArVGhlIDFzdCBtb2R1bGU6IGRvbTAga2VybmVsIGlt YWdlCj4+Pj4+Pj4+ICtUaGUgMm5kIG1vZHVsZTogZG9tMCByYW1kaXNrCj4+Pj4+Pj4+ICtBbGwg c3Vic2VxdWVudCBtb2R1bGVzOiBVTktOT1cKPj4+Pj4+Pj4gQGVuZCBkZWZmbgo+Pj4+Pj4+Cj4+ Pj4+Pj4gSG1tIC4uLiBmcm9tIHByZXZpb3VzIGRpc2N1c3Npb24gSSBnYXRoZXJlZCB0aGF0IFhl biBjYW4gZGV0ZWN0IG1vZHVsZQo+Pj4+Pj4+IHR5cGUuIFdoYXQgaWYgdGhlcmUgaXMgbm8gaW5p dHJkIGZvciBkb20wPyBIb3cgY2FuIHN1YnNlcXVlbnQgbW9kdWxlcyBiZQo+Pj4+Pj4KPj4+Pj4+ IE5vdyAsIFhlbiBkZXRlY3QgbW9kdWxlIHR5cGUgYnkgdGhlIG9yZGVyLiAoYXQgbGVhc3Qgb24g QVJNNjQpLgo+Pj4+Pj4gSSB0aGluayBpMzg2IGlzIHVzaW5nIE11bHRpYm9vdCgyKSBwcm90b2Nv bCwgc28gbWF5YmUgdGhpcyBvcmRlciBpcwo+Pj4+Pj4gbm90aGluZyB0byBkbyB3aXRoIGkzODYu Cj4+Pj4+Pgo+Pj4+Pgo+Pj4+PiBUaGVuIHdlIGhhdmUgb2J2aW91cyBwcm9ibGVtIHdpdGggeW91 ciBYU00gcGF0Y2ggKGh0dHA6Ly9zYXZhbm5haC5nbnUub3JnL2J1Z3MvPzQzNDIwKSAtIFhTTSBt YXkgbGFuZCBhcyB0aGUgZmlyc3QgbW9kdWxlLiBUaGF0J3MgYWN0dWFsbHkgc29tZXRoaW5nIHRv IHNvbHZlIG9uIFhlbiBzaWRlIEkgdGhpbmsuIEl0J3MganVzdCB0aGF0IHNvIGZhciB3ZSBoYWQg anVzdCBrZXJuZWwgYW5kIGluaXRyZCwgc28gdGhhdCB3YXMgbm9uIGlzc3VlLgo+Pj4+Cj4+Pj4g T2gsIGRpZCB5b3UgbWVhbiBXZWkgTGl1J3MgcGF0Y2g/Cj4+Pj4KPj4+PiBJIGd1ZXNzIFhTTSBt YXkgbGFuZCBhcyB0aGUgdGhpcmQgbW9kdWxlIChvciB0aGUgbW9kdWxlIGFmdGVyIGxpbnV4Cj4+ Pj4ga2VybmVsLCBpZiB5b3UgZG9uJ3QgaGF2ZSBpbml0cmQpCj4+Pj4KPj4+PiBZZXMsIGFncmVl LiAoVGhhdCdzIGFjdHVhbGx5IHNvbWV0aGluZyB0byBzb2x2ZSBvbiBYZW4gc2lkZSkKPj4+Pgo+ Pj4+IEkgZ3Vlc3MgeGVuIGNhbiBnZXQgeHNtIGZyb20gYSBzcGVjaWFsIGluaXRyZC4gc28gZm9y IG5vdyB0aGVyZSBpcyBub3QKPj4+PiBiaWcgcHJvYmxlbSBvbiB4c20uCj4+Pj4KPj4+PiBQbGVh c2UgY29ycmVjdCBtZSBpZiBJIG1pc3VuZGVyc3RhbmQgc29tZXRoaW5nLiA6LSkKPj4+Pgo+Pj4+ IFRoYW5rcyEKPj4+Pgo+Pj4+IEJhY2sgdG8gdGhpcyBwYXRjaCwgaXMgdGhhdCBPSyBmb3IgeW91 LCBvciBhbnkgc3VnZ2VzdGlvbj8gIFRoYW5rcyAhCj4+Pj4KPj4+Cj4+PiBZZXMsIGFzIHRoaXMg aXMgZGVkaWNhdGVkIFhlbiBsb2FkZXIgd2Ugc2hvdWxkIGRvY3VtZW50IHRoaXMgbWFuZGF0b3J5 Cj4+PiBvcmRlciAtIGZpcnN0IG1vZHVsZSBtdXN0IGJlIGtlcm5lbCBpbWFnZSwgc2Vjb25kIG1v ZHVsZSBtdXN0IGJlCj4+PiBpbml0cmQuIEkgZG8gbm90IHRoaW5rIHdlIG5lZWQgdG8gbWVudGlv biBwb3NzaWJpbGl0eSB0byBsb2FkIG1vcmUKPj4+IHRoYW4gdHdvIG1vZHVsZXMgdW50aWwgdGhl cmUgaXMgY2xlYXIgdW5kZXJzdGFuZGluZyBob3cgaXQgY2FuIGJlIGRvbmUKPj4+IHdpdGhvdXQg aW5pdHJkLgo+Pgo+PiBHcmVhdCB0aGFua3MgZm9yIHlvdXIgcmV2aWV3LCBJIGhhdmUgdXBkYXRl ZCBhbmQgc2VudCB0aGUgdjMgcGF0Y2hzZXQsCj4+IEhvcGUgSSB1bmRlcnN0b29kIHlvdXIgc3Vn Z2VzdGlvbiBjb3JyZWN0bHksIFBsZWFzZSBjaGVjay4gIDotKQo+IAo+IFdoYXQgaWYgdGhlIGlu aXRyZCBpcyBjYXR0ZWQgdG8gdGhlIGtlcm5lbCBpbWFnZSAod2hpY2ggeW91IGNhbgo+IGRvIG9u IHg4Nik/IEFuZCB0aGVuIHRoZSAxc3QgbW9kdWxlIGlzIHlvdXIgWFNNPwo+IAoKT24geDg2IFhl biBjYW4gZGV0ZWN0IG1pY3JvY29kZSBhbmQgeHNtIG1vZHVsZXM7IHRoZSBmaXJzdCB1bmtub3du Cm1vZHVsZSBhZnRlciB0aGF0IGlzIGFzc3VtZWQgdG8gYmUgaW5pdHJkIChkb20wIGtlcm5lbCBh bHdheXMgbXVzdCBiZQp0aGUgdmVyeSBmaXJzdCBtb2R1bGUgcHJvdmlkZWQpLgoKT24gYXJtIHRo ZXJlIGlzIG5vIGRldGVjdGlvbiAtIG1vZHVsZSB0eXBlIGlzIHRha2VuIGZyb20gRkRUOyBpZiBu bwptb2R1bGUgdHlwZSBpcyBwcm92aWRlZCwgdGhlIGZpcnN0IHVua25vd24gbW9kdWxlIGlzIGFz c3VtZWQgdG8gYmUKa2VybmVsLCB0aGUgc2Vjb25kIC0gaW5pdHJkLgoKU2VlIGFsc28gaHR0cDov L2xpc3RzLmdudS5vcmcvYXJjaGl2ZS9odG1sL2dydWItZGV2ZWwvMjAxNi0wMi9tc2cwMDMzMy5o dG1sCgo+IElzIHRoaXMgLi4gb3JkZXIgZGVwZW5kZW5jeSB3cml0dGVuIHNvbWV3aGVyZSBpbiBh IGRvY3VtZW50PyBJbiB0aGUKPiBYZW4gY29kZS1iYXNlIHRoYXQgaXM/Cj4gCgoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KR3J1Yi1kZXZlbCBtYWlsaW5n IGxpc3QKR3J1Yi1kZXZlbEBnbnUub3JnCmh0dHBzOi8vbGlzdHMuZ251Lm9yZy9tYWlsbWFuL2xp c3RpbmZvL2dydWItZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1aZtcy-0007JX-PB for mharc-grub-devel@gnu.org; Sun, 28 Feb 2016 00:10:44 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46418) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aZtcw-0007IY-4K for grub-devel@gnu.org; Sun, 28 Feb 2016 00:10:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aZtcs-0005u9-3o for grub-devel@gnu.org; Sun, 28 Feb 2016 00:10:42 -0500 Received: from mail-lb0-x236.google.com ([2a00:1450:4010:c04::236]:33162) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aZtcr-0005u3-Iv for grub-devel@gnu.org; Sun, 28 Feb 2016 00:10:37 -0500 Received: by mail-lb0-x236.google.com with SMTP id ep2so32652970lbb.0 for ; Sat, 27 Feb 2016 21:10:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=hb92FS6nUvZ6BM9iP63jfgywBB3esKFlkpvJbMlBbNw=; b=Wh+kDNCPoNDEcnDEz14Wd3fhG2kQbsHPcQVDXwtL4XET8/FjQ8rkYnJxyBmCrVvMIa ZciZQpbP8i/XuUOk25iEC6fZWj9xQ1/dCeHuQjwI7o5aPoby/ATIbysFwtimb0AuyTHD GiMk2g7a2Ee4Iy2zeNZORLkYcuvt/FAS02cxR1Vl3ST/S4Xg2Bdq1nU2Rx34xU2oq+uq LjPMCuEGXmjYhYh4WBOKkEJTAclqtXOx8Sj8LbGxWR1IuX2aHa0m7lUr46s5JE5ZNQyr 3V+oDvO5cQgEfFIpCB9nwcWaIRnvD/FCGXy9HBCxAVqHDSfYHZTM6f2BeL/C9eL9/gVJ 3gLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=hb92FS6nUvZ6BM9iP63jfgywBB3esKFlkpvJbMlBbNw=; b=XEmwaz76Vh6zb9hWhworf7QKsZGDFnOV4bysPQLzvA7kjfmi3+JDG7DzIrd6D940lk T59GzfCevwu1MQQsUDryQCn0fcs2MeNpbfPBsN0/azGFUMfcO0eOivb/1663RCwaEYyA YMhYPE+Vs/i+ckoDF3mJhafXp+2yMPH5lWL2xAG5/6hVTA/MDGsTueIfb+SvcY7ETR5C v9T8l5fueq1vJJdhrC72KACOLAGjyXv71XgVX0dkyu+Csopfum5AxFED6CUZWhTtX4UQ 1zJ0/2v59WQY5kE5gYUmCTY+fjvPDilXKLORB7cluQzEVcu2+vLX+mx7dE3DmHvN9zL+ RCIA== X-Gm-Message-State: AD7BkJJeXYm4EPR/ms1ukpzOZ7tIob07UGmeMZzI5bgQioJVZJxgzp01KLpjPzO/HYrMjg== X-Received: by 10.112.205.69 with SMTP id le5mr3183616lbc.62.1456636236286; Sat, 27 Feb 2016 21:10:36 -0800 (PST) Received: from [192.168.1.41] (ppp109-252-76-159.pppoe.spdop.ru. [109.252.76.159]) by smtp.gmail.com with ESMTPSA id h75sm2943060lfi.2.2016.02.27.21.10.33 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 27 Feb 2016 21:10:35 -0800 (PST) Subject: Re: [PATCH v2 4/4] arm64: update the introduction of xen boot commands in docs/grub.texi To: Konrad Rzeszutek Wilk , The development of GNU GRUB References: <1456382355-24614-2-git-send-email-fu.wei@linaro.org> <1456382355-24614-5-git-send-email-fu.wei@linaro.org> <56CF3B24.6030605@gmail.com> <20160227203341.GM31035@char.us.oracle.com> From: Andrei Borzenkov Message-ID: <56D28149.30907@gmail.com> Date: Sun, 28 Feb 2016 08:10:33 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160227203341.GM31035@char.us.oracle.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:4010:c04::236 Cc: "xen-devel@lists.xensource.com" , Ian Campbell , Vladimir Serbinenko , Julien Grall , Leif Lindholm , Linaro UEFI Mailman List , Jon Masters X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Feb 2016 05:10:43 -0000 27.02.2016 23:33, Konrad Rzeszutek Wilk пишет: > On Fri, Feb 26, 2016 at 07:15:52PM +0800, Fu Wei wrote: >> Hi Andrei, >> >> On 26 February 2016 at 18:50, Andrei Borzenkov wrote: >>> On Fri, Feb 26, 2016 at 8:59 AM, Fu Wei wrote: >>>>>>>> +@subsection xen_module >>>>>>>> >>>>>>>> -@deffn Command xen_linux file [arguments] >>>>>>>> -Load a dom0 kernel image for xen hypervisor at the booting process of xen. >>>>>>>> +@deffn Command xen_module [--nounzip] file [arguments] >>>>>>>> +Load a module for xen hypervisor at the booting process of xen. >>>>>>>> The rest of the line is passed verbatim as the module command line. >>>>>>>> +Each module will be identified by the order in which the modules are added. >>>>>>>> +The 1st module: dom0 kernel image >>>>>>>> +The 2nd module: dom0 ramdisk >>>>>>>> +All subsequent modules: UNKNOW >>>>>>>> @end deffn >>>>>>> >>>>>>> Hmm ... from previous discussion I gathered that Xen can detect module >>>>>>> type. What if there is no initrd for dom0? How can subsequent modules be >>>>>> >>>>>> Now , Xen detect module type by the order. (at least on ARM64). >>>>>> I think i386 is using Multiboot(2) protocol, so maybe this order is >>>>>> nothing to do with i386. >>>>>> >>>>> >>>>> Then we have obvious problem with your XSM patch (http://savannah.gnu.org/bugs/?43420) - XSM may land as the first module. That's actually something to solve on Xen side I think. It's just that so far we had just kernel and initrd, so that was non issue. >>>> >>>> Oh, did you mean Wei Liu's patch? >>>> >>>> I guess XSM may land as the third module (or the module after linux >>>> kernel, if you don't have initrd) >>>> >>>> Yes, agree. (That's actually something to solve on Xen side) >>>> >>>> I guess xen can get xsm from a special initrd. so for now there is not >>>> big problem on xsm. >>>> >>>> Please correct me if I misunderstand something. :-) >>>> >>>> Thanks! >>>> >>>> Back to this patch, is that OK for you, or any suggestion? Thanks ! >>>> >>> >>> Yes, as this is dedicated Xen loader we should document this mandatory >>> order - first module must be kernel image, second module must be >>> initrd. I do not think we need to mention possibility to load more >>> than two modules until there is clear understanding how it can be done >>> without initrd. >> >> Great thanks for your review, I have updated and sent the v3 patchset, >> Hope I understood your suggestion correctly, Please check. :-) > > What if the initrd is catted to the kernel image (which you can > do on x86)? And then the 1st module is your XSM? > On x86 Xen can detect microcode and xsm modules; the first unknown module after that is assumed to be initrd (dom0 kernel always must be the very first module provided). On arm there is no detection - module type is taken from FDT; if no module type is provided, the first unknown module is assumed to be kernel, the second - initrd. See also http://lists.gnu.org/archive/html/grub-devel/2016-02/msg00333.html > Is this .. order dependency written somewhere in a document? In the > Xen code-base that is? >