From mboxrd@z Thu Jan 1 00:00:00 1970 From: Haggai Eran Subject: Re: [PATCHv6 3/3] rdmacg: Added documentation for rdmacg Date: Sun, 28 Feb 2016 10:55:06 +0200 Message-ID: <56D2B5EA.5090701@mellanox.com> References: <1455966006-13774-1-git-send-email-pandit.parav@gmail.com> <1455966006-13774-4-git-send-email-pandit.parav@gmail.com> <56CDBD8B.4050503@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-doc-owner@vger.kernel.org To: Parav Pandit Cc: cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, Tejun Heo , lizefan@huawei.com, Johannes Weiner , Doug Ledford , Liran Liss , "Hefty, Sean" , Jason Gunthorpe , Jonathan Corbet , james.l.morris@oracle.com, serge@hallyn.com, Or Gerlitz , Matan Barak , raindel@mellanox.com, akpm@linux-foundation.org, linux-security-module@vger.kernel.org List-Id: linux-rdma@vger.kernel.org On 24/02/2016 17:21, Parav Pandit wrote: > On Wed, Feb 24, 2016 at 7:56 PM, Haggai Eran wrote: >> On 20/02/2016 13:00, Parav Pandit wrote: >>> Added documentation for v1 and v2 version describing high >>> level design and usage examples on using rdma controller. >>> >>> Signed-off-by: Parav Pandit >> >> I think you might want to mention that resource limits are reflected >> in the results returned from ib_uverbs_query_device/ibv_query_device >> or printed from "ibv_devinfo -v". >> > Its valid point. > Since this documentation is for rdma controller, I was wondering > should I have it this documentation or should I add the uverbs_cmds.c? I was thinking it should be in the documentation because an application developer might look there first, without reading uverbs_cmd.c. Haggai From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757145AbcB1I4K (ORCPT ); Sun, 28 Feb 2016 03:56:10 -0500 Received: from mail-db3on0053.outbound.protection.outlook.com ([157.55.234.53]:32366 "EHLO emea01-db3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756981AbcB1I4F (ORCPT ); Sun, 28 Feb 2016 03:56:05 -0500 Authentication-Results: spf=pass (sender IP is 193.47.165.134) smtp.mailfrom=mellanox.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=pass action=none header.from=mellanox.com; Subject: Re: [PATCHv6 3/3] rdmacg: Added documentation for rdmacg To: Parav Pandit References: <1455966006-13774-1-git-send-email-pandit.parav@gmail.com> <1455966006-13774-4-git-send-email-pandit.parav@gmail.com> <56CDBD8B.4050503@mellanox.com> CC: , , , , Tejun Heo , , Johannes Weiner , Doug Ledford , Liran Liss , "Hefty, Sean" , Jason Gunthorpe , Jonathan Corbet , , , Or Gerlitz , Matan Barak , , , From: Haggai Eran Message-ID: <56D2B5EA.5090701@mellanox.com> Date: Sun, 28 Feb 2016 10:55:06 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.0.52.254] X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CPI:193.47.165.134;IPV:NLI;CTRY:IL;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(24454002)(479174004)(189002)(199003)(377454003)(5004730100002)(36756003)(86362001)(64126003)(19580395003)(19580405001)(2950100001)(23676002)(50986999)(1096002)(87936001)(33656002)(76176999)(1220700001)(3846002)(6116002)(5008740100001)(110136002)(65956001)(6806005)(65816999)(4001350100001)(87266999)(54356999)(189998001)(65806001)(11100500001)(47776003)(106466001)(4326007)(93886004)(77096005)(586003)(2906002)(92566002)(230700001)(3940600001);DIR:OUT;SFP:1101;SCL:1;SRVR:DB5PR05MB1445;H:mtlcas13.mtl.com;FPR:;SPF:Pass;MLV:sfv;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;DB3FFO11FD022;1:WY+ercWY2SgnNdvpqNFFtMdL+Qu/0FgvDegDo4UyLPw1AXsMlP7XyP2USWvrN+1rBOgYwD1GUURq4h58rmQpaqfxcAdDnDPrdlIfwPEMQGBd8VHDkTsujAgru1b/w7QLAYDh4Qa9O7rWp5peuCny+hljhbOKAB8M07G/JP7Nb9OmWObCG4cjFhHDteRl/JBikLU4rbqiGvunO3F5lLO7fb3ZtAZzFzevR+tlrFkk77qWJpTd9Uo0MbU3VnwUiFthigDO3qqRn3I3LUdusxTxhFA/ZqtNfYqgsM0/yDf6ED7CHKpDEARCp4TbqA4ENhDwi9p9HFLmalREpmV4yQX52YD0K0k1I/JI1m6Nm6MUAs3k2LHwGQSRb0AuRGO045V1rtXGQWhEz6JUhoCQ2VEdjiSnkmvBf4iSpQrykzyYfssoKAkOg46pYZBs/jB6Xx/1mony0IstqKJlm2dowQPQXtzDXH5fgPJOWBafE8VNJMIvLw4Krpj+oFWmRWfC04Rn X-Microsoft-Exchange-Diagnostics: 1;DB5PR05MB1445;2:0dOLE5DrMvkjwpRZwwODMaxndneWWPHBR3yhvjZZdT0QdhZovNy2E4Fc7mtlYHDidgntMZ6aHcYylrPuPjzIkDclirRsyqXrOd/6ukt3L7k049XnZaCRr9HfRlkBvkPnb25QHxZKwmdfemdkXv7gXQ==;3:bcETtAdpYcmccJzgLVcbbalud5v/NqwoLXvKRNizX/SX7eGDhCvE4rr+8WRj74CzcnqFeq4XaPn8g+dpcFMOskq/QPFa7OgJKdA7nmLHSLRF0vmcLJPBcPy/KBTN9AGTtcy1dPsTOmnQO9BaMpcR2LuGenOhdcmRn6UzG8f0WxuYwX7A04pz2TVQrxr7pdsb3yYr93m9u/7lDFHZ3KppPA==;25:7m3Xyh3x9ai635VGnhTINJekqcW0HjqibOnIXkTtbtXQ9qyjnGVKIV0LndTaxifmlCvuuSjlU9OHFqm/on9iQPbea2sqWeYkoQbcckHyUqE49UFycemJZIKLk6VqZBEKhhW0tRXSI0HORwnGfgZiIJJeOa25lQWm7vwPQXQctnxDtLaJX57AKZtGK4U38WP6EB/DjdkqhhciYCDXYxsk8udFlNdX/LHeueyui5m9FSf21xafUTFVUtuSAtUCyvI54MOs4ureFCY+hYkUEoTgaOE72EnGIOebcwWLGMqrkFfjNubXInMkWcoi81es/lkTNdQY+u8wXyF9GRfz0zhKFA== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501001);SRVR:DB5PR05MB1445; X-MS-Office365-Filtering-Correlation-Id: d0ec5693-2cb8-476a-9512-08d3401cf925 X-Microsoft-Exchange-Diagnostics: 1;DB5PR05MB1445;20:1nqsVAbHjjGz9m0Y83BaSngDfW1+QZJUePe+KjCGIDKyjlIDW99uY0Q9iZufVhlERy9I1IF2g6rrfJ3Ah6MhBP746gB8TsdTpRO3kHsbDmPTm5DNz4zvVp4A1kxECf/EnqK9DkxjajTJLpNK7iP4lFNbrIGIacJTM2pxcbCLT/Zz1DMUxBl0h2D+A9qYxGKmeEf9s8MF1D1MfGdi5s4vcw0HYlW0QQGR1O0xGrYmuJhhO4puES1BTaiGOUFVHKjAEUdofJ6ot8u4+PmZoEUFXlz7moYAFLusyFUu+RKREWWUmfH461VhAsx2Ukr/jhVA2QWpwMZ+rY0ofbU3ZkqpCAuIAprUipSrG78o5IY7dlHPMAJiC9/xSb3Sf3KAerRMhzy6YoGf8ZGEqjLDW79Dm6Tzspa6hqg5P59KzsFcd2YRFzuwYQyCIKqZoPi5NkppX27PC9YUw1H0ajIpGU1kNtR1lylgQVKgG2QRM8kkNTDtuusG/bR96M2qzos+eLAd X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(13015025)(8121501046)(13023025)(13024025)(13018025)(13017025)(10201501046)(3002001);SRVR:DB5PR05MB1445;BCL:0;PCL:0;RULEID:;SRVR:DB5PR05MB1445; X-Microsoft-Exchange-Diagnostics: 1;DB5PR05MB1445;4:1Kc1ZmNWyr0kk/LTTBEd4M6hURGj9tfYdcojXNm5KREuu0XsvVmWiAHHJsBfa7CIVYe7XL5dv5DKsCz4OnC3mul//QghhFfQRrAIuI6MHGxxOg9qbsrhJBJnA7JU5PhZzgveIejHZR7fZT5rZFlgbl+PebQJQDNkFsbV71Rxfg0NVYVa3BOTxghpOjb3iy3FEFXPbKk5ifpZtoekvn8w8CioErL8c3Mq7ssJla/IN7xEOMId0AEjRawoD+JZLgJ10z9Sk5je1PCi/4H5hr7Jbc3nK1xoYwR4sa+k5N1gaZ4EGgX9/aLnLELG/78JbcrRusU+kxC/tjggtTgDV0MH4boUmmEwx8x/z0Hk0OMNjrk75n4XSdHq5bSA0PYK+IXIZCqwM0ba9Ph0dPOmVBGrTBa1exJQG2S5s80yf0LurnHzlEe6UcNtUDk/7Whjto6a9I6q4vIs/8TEzlZsoHZzTw== X-Forefront-PRVS: 08660C8631 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtEQjVQUjA1TUIxNDQ1OzIzOm1BcWdyT0k4N29qa1JwNkZsUW1LRm1adTI5?= =?utf-8?B?ejUxVVlaU3VWUnR2YTlOTVZJdENkQTRyVDZmVStLV2Q4Y21GcmRROHJlTEJX?= =?utf-8?B?b3MxNWZwcHhvbDFkeTRlOGpuWFJoMHV2WmJtV2IvTXdVa0MrV1VUVlZFekRw?= =?utf-8?B?TUdLN1JmT0duNC9IS2FpODlwaGp4TVlWMk4xZTFNbDk0L0kwR0V2T3BIOXhQ?= =?utf-8?B?bEFiQlZJKzdyZ3MxaGtHWFExVUpPM1Q5TzlqOEJrV3p4ZkhhTkhJZE1BczJ5?= =?utf-8?B?R1N1MitReEl1TVl6VFZsZlk4ZERpeDU4d0R1clozNjBRSjRlRlQzNU5yQ2hG?= =?utf-8?B?RUJBTENwcDgzVUQrU28yMFdTbnk2Y3ZPRWRvQm9oOG9BSWJuRmNSWXNtRGp1?= =?utf-8?B?bHlwOVZPcXoyLy9STE43T2ZMRys1bkFqSlhYQ3VwZERId1kyK3RkUkdhNEpv?= =?utf-8?B?WUtKS0hOandrVlhpV0dvL0h6SThBWERYN3NGMTI5TFhBQVBiYkVBTnFHcUNp?= =?utf-8?B?WFVrYmVmckpUTlJhWGIxTE5qR3I5VkRKOTdHWXJIdWU1NFpwcVhzbVJKa0Jz?= =?utf-8?B?cFZUcDhCb2JXZkNJK29XaUlVZStTdXFvM2ZXN2FRdUdUaVJhUlhqbkp4UFJs?= =?utf-8?B?dk5ENHNmR3FxVXI2NG51MzE0MUhyWGMrNzBnN2FSYkYwL2U1SktVNTNVNWMz?= =?utf-8?B?MUE0VkhLZVJ2WDJ0b3B0L0VISlpOQXd2d3N4Y05RMWljVGkybnVxeHVhUFRP?= =?utf-8?B?QW5VN3k0Z1lMQk9lbDlMaHNST1BXcDVtSW5TQUtRZDFSSUg0Z2Fwd1ArbzZt?= =?utf-8?B?R3FTekQzdXpFbGhyNlhMMlRvWkordVBEeml1UW9IbEdJV1VScDBySmViNFN3?= =?utf-8?B?c08wVTk4azl3TE9oOWJQY2dKOFpDdUp3ZS9tNFN6d20wZEI1V1g4bTk3bitU?= =?utf-8?B?WWNveXdEeW56N3FTNlFlL2tBWTRYUTRHSUNaRlU0eTVIOU02Q2pWbHZLV0Fq?= =?utf-8?B?VVJabklNVGNkL2NyT1dUbEZpbEloY0s1aENEckpjWHBsTFN5TmhRVkVKL044?= =?utf-8?B?cUw2c01IUnhsQloxRHlLSGRyR09WT3JOZitoK3ord3BFU3o1dSsyVmpRdito?= =?utf-8?B?eGpPRlZCSkF6c3ovc1BFR3hReTg1VW9uK3pFWjdZMEhCTHltZk1LMjBBZkxT?= =?utf-8?B?Z3AvTE5VRC8xRE54c1ZPMmw3eDVIOHVidzFUbTlqbEJNbHNNWE1PNkIrSXp2?= =?utf-8?B?SW5LRVhYL2I2c200N0hzaHhxTEY3czM5cUFZWnNuSm9rUDNKdUo4Mk9KNmdj?= =?utf-8?B?dDRDZFFIWmxjZEdkSkV5OG5qdER2MHQxWVV0WTFsZzRIakhELy80U24xVWpB?= =?utf-8?B?eXd2bkFHNUdEd2djT1VObzM5RU41dkhTMWRRa0lqUmtvSTdya0MreWVPbWxT?= =?utf-8?B?b2ltME9HY0NLYlV4VDh3STNJeVVnTnlFb3RlMzZ6Q3RrSk0wR01aWnd6bnRt?= =?utf-8?Q?eeWB54F2CecslqAwYPg0CDiIDxrfFfaI0l6/0yryMy9s8O?= X-Microsoft-Exchange-Diagnostics: 1;DB5PR05MB1445;5:AFClgR2uub9nyQzBG2XaPltfxzHzEdAx8bm8N/OgimQaWsBzDGKteW08f3zGOB2qSvBSwHAvj7LHOcULV8gqyJqg+2g/DhGgWjwsxXtlSkKWvQpmGOmMEC+xqlAFZUkyuHFib456fDyBjc20b0PAmA==;24:d2wuPUBFFxRjR5Q7Xo1O2+2bJ6KvbsQbgkAC5WxDNINcCu/jE4O0Q81gXaPiLK2ap2C/S7lVTGsurlht3R1JvgtEZQHYqtSBAmGO+lvDv48= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2016 08:55:56.9503 (UTC) X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=a652971c-7d2e-4d9b-a6a4-d149256f461b;Ip=[193.47.165.134];Helo=[mtlcas13.mtl.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR05MB1445 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24/02/2016 17:21, Parav Pandit wrote: > On Wed, Feb 24, 2016 at 7:56 PM, Haggai Eran wrote: >> On 20/02/2016 13:00, Parav Pandit wrote: >>> Added documentation for v1 and v2 version describing high >>> level design and usage examples on using rdma controller. >>> >>> Signed-off-by: Parav Pandit >> >> I think you might want to mention that resource limits are reflected >> in the results returned from ib_uverbs_query_device/ibv_query_device >> or printed from "ibv_devinfo -v". >> > Its valid point. > Since this documentation is for rdma controller, I was wondering > should I have it this documentation or should I add the uverbs_cmds.c? I was thinking it should be in the documentation because an application developer might look there first, without reading uverbs_cmd.c. Haggai