From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752825AbcB2Ib2 (ORCPT ); Mon, 29 Feb 2016 03:31:28 -0500 Received: from mga14.intel.com ([192.55.52.115]:33440 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751992AbcB2IbZ (ORCPT ); Mon, 29 Feb 2016 03:31:25 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,519,1449561600"; d="scan'208";a="661027760" Subject: Re: [PATCH v4 3/5] staging/android: remove redundant comments on sync_merge_data To: Gustavo Padovan , Greg Kroah-Hartman References: <1456511507-2534-1-git-send-email-gustavo@padovan.org> <1456511507-2534-3-git-send-email-gustavo@padovan.org> Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, dri-devel@lists.freedesktop.org, Daniel Stone , =?UTF-8?Q?Arve_Hj=c3=b8nnev=c3=a5g?= , Riley Andrews , Daniel Vetter , Rob Clark , Greg Hackmann , John Harrison , Gustavo Padovan From: Maarten Lankhorst Message-ID: <56D401D6.7030002@linux.intel.com> Date: Mon, 29 Feb 2016 09:31:18 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <1456511507-2534-3-git-send-email-gustavo@padovan.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Op 26-02-16 om 19:31 schreef Gustavo Padovan: > From: Gustavo Padovan > > struct sync_merge_data already have documentation on top of the > struct definition. No need to duplicate it. > > Signed-off-by: Gustavo Padovan > --- > drivers/staging/android/uapi/sync.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/android/uapi/sync.h b/drivers/staging/android/uapi/sync.h > index dd0dd84..f0b41ce 100644 > --- a/drivers/staging/android/uapi/sync.h > +++ b/drivers/staging/android/uapi/sync.h > @@ -21,9 +21,9 @@ > * @fence: returns the fd of the new fence to userspace > */ > struct sync_merge_data { > - __s32 fd2; /* fd of second fence */ > - char name[32]; /* name of new fence */ > - __s32 fence; /* fd on newly created fence */ > + __s32 fd2; > + char name[32]; > + __s32 fence; > }; > > /** For the first 3 patches: Reviewed-by: Maarten Lankhorst From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maarten Lankhorst Subject: Re: [PATCH v4 3/5] staging/android: remove redundant comments on sync_merge_data Date: Mon, 29 Feb 2016 09:31:18 +0100 Message-ID: <56D401D6.7030002@linux.intel.com> References: <1456511507-2534-1-git-send-email-gustavo@padovan.org> <1456511507-2534-3-git-send-email-gustavo@padovan.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1456511507-2534-3-git-send-email-gustavo@padovan.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: Gustavo Padovan , Greg Kroah-Hartman Cc: devel@driverdev.osuosl.org, Rob Clark , Daniel Stone , Daniel Vetter , Riley Andrews , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, =?UTF-8?Q?Arve_Hj=c3=b8nnev=c3=a5g?= , Greg Hackmann , Gustavo Padovan , John Harrison List-Id: dri-devel@lists.freedesktop.org Op 26-02-16 om 19:31 schreef Gustavo Padovan: > From: Gustavo Padovan > > struct sync_merge_data already have documentation on top of the > struct definition. No need to duplicate it. > > Signed-off-by: Gustavo Padovan > --- > drivers/staging/android/uapi/sync.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/android/uapi/sync.h b/drivers/staging/android/uapi/sync.h > index dd0dd84..f0b41ce 100644 > --- a/drivers/staging/android/uapi/sync.h > +++ b/drivers/staging/android/uapi/sync.h > @@ -21,9 +21,9 @@ > * @fence: returns the fd of the new fence to userspace > */ > struct sync_merge_data { > - __s32 fd2; /* fd of second fence */ > - char name[32]; /* name of new fence */ > - __s32 fence; /* fd on newly created fence */ > + __s32 fd2; > + char name[32]; > + __s32 fence; > }; > > /** For the first 3 patches: Reviewed-by: Maarten Lankhorst