From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [kvm-unit-tests PATCH v2 2/2] powerpc: select endianness Date: Mon, 29 Feb 2016 17:06:53 +0100 Message-ID: <56D46C9D.9050908@redhat.com> References: <1456506526-10803-1-git-send-email-lvivier@redhat.com> <1456506526-10803-3-git-send-email-lvivier@redhat.com> <20160226184502.35oadt5jw2ck46la@hawk.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, thuth@redhat.com, dgibson@redhat.com, agraf@suse.de To: Andrew Jones , Laurent Vivier Return-path: Received: from mx1.redhat.com ([209.132.183.28]:53308 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754725AbcB2QG6 (ORCPT ); Mon, 29 Feb 2016 11:06:58 -0500 In-Reply-To: <20160226184502.35oadt5jw2ck46la@hawk.localdomain> Sender: kvm-owner@vger.kernel.org List-ID: On 26/02/2016 19:45, Andrew Jones wrote: >> > + LOAD_REG_ADDR(r10,rtas_return_loc) >> > + mtlr r10 >> > + >> > LOAD_REG_ADDR(r10, rtas_blob) >> > -//FIXME: change this bctrl to an rtas-prep, rfid, rtas-return sequence >> > - mtctr r10 >> > - nop >> > - bctrl >> > + B_BE(r10) Note that this doesn't apply. I've applied patch 1 though. Paolo >> > + >> > +rtas_return_loc: >> > + RETURN_FROM_BE >> > ld r0, 16(r1) >> > mtlr r0 >> > blr > Besides my earlier comment about always needing rfid to prep for the > rtas call (which my FIXUP comment here poorly indicated), then this > looks good to me. Although I'm not sure I like the name RETURN_FROM_BE, > as sometimes we're returning to LE, and sometimes we're not. In the > not case, it's a bit confusing. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Date: Mon, 29 Feb 2016 16:06:53 +0000 Subject: Re: [kvm-unit-tests PATCH v2 2/2] powerpc: select endianness Message-Id: <56D46C9D.9050908@redhat.com> List-Id: References: <1456506526-10803-1-git-send-email-lvivier@redhat.com> <1456506526-10803-3-git-send-email-lvivier@redhat.com> <20160226184502.35oadt5jw2ck46la@hawk.localdomain> In-Reply-To: <20160226184502.35oadt5jw2ck46la@hawk.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Andrew Jones , Laurent Vivier Cc: kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, thuth@redhat.com, dgibson@redhat.com, agraf@suse.de On 26/02/2016 19:45, Andrew Jones wrote: >> > + LOAD_REG_ADDR(r10,rtas_return_loc) >> > + mtlr r10 >> > + >> > LOAD_REG_ADDR(r10, rtas_blob) >> > -//FIXME: change this bctrl to an rtas-prep, rfid, rtas-return sequence >> > - mtctr r10 >> > - nop >> > - bctrl >> > + B_BE(r10) Note that this doesn't apply. I've applied patch 1 though. Paolo >> > + >> > +rtas_return_loc: >> > + RETURN_FROM_BE >> > ld r0, 16(r1) >> > mtlr r0 >> > blr > Besides my earlier comment about always needing rfid to prep for the > rtas call (which my FIXUP comment here poorly indicated), then this > looks good to me. Although I'm not sure I like the name RETURN_FROM_BE, > as sometimes we're returning to LE, and sometimes we're not. In the > not case, it's a bit confusing.