From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Tan, Jianfeng" <jianfeng.tan@intel.com>
Subject: Re: [PATCH v5 01/11] ethdev: add API to query packet
 type filling info
Date: Tue, 1 Mar 2016 16:00:06 +0800
Message-ID: <56D54C06.4020503@intel.com>
References: <1451544799-70776-1-git-send-email-jianfeng.tan@intel.com>
 <1456472067-2721-1-git-send-email-jianfeng.tan@intel.com>
 <1456472067-2721-2-git-send-email-jianfeng.tan@intel.com>
 <56D42CC4.4000100@redhat.com> <56D474C0.9090300@intel.com>
 <56D536B3.3080104@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
To: Panu Matilainen <pmatilai@redhat.com>, dev@dpdk.org,
 Thomas Monjalon <thomas.monjalon@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 8E1A22A6C
 for <dev@dpdk.org>; Tue,  1 Mar 2016 09:00:13 +0100 (CET)
In-Reply-To: <56D536B3.3080104@redhat.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



On 3/1/2016 2:29 PM, Panu Matilainen wrote:
> On 02/29/2016 06:41 PM, Tan, Jianfeng wrote:
>> Hi Panu,
>>
>> On 2/29/2016 7:34 PM, Panu Matilainen wrote:
> [...]
>>>
>>> More importantly, to export a function you need to add an entry for it
>>> in rte_ether_version.map.
>>
>> Oh, yes, thanks for pointing out this, I'll change this and update
>> rte_ether_version.map.
>>
>> Is it like this? Before or after DPDK_2.2 {}?
>> DPDK_2.3 {
>>      global:
>>
>>      rte_eth_dev_get_ptype_info;
>>
>>      local: *;
>> };
>
> Sorry I didn't have a chance to reply to this yesterday and I see you 
> already posted a v6 with the above, which is almost but not quite 
> there: it needs to inherit from DPDK_2.2, ie
>
> DPDK_2.3 {
>      global:
>
>      rte_eth_dev_get_ptype_info;
>
>      local: *;
> } DPDK_2.2;
>
> ...but if there are no other reasons to respin the series perhaps 
> Thomas can fixup that while applying.

OK, thanks. Should I add this new API into _API Changes_ section in 
doc/guides/rel_notes/release_16_04.rst?

>
> Then there's the actual version, which should optimally be DPDK_16.04 
> but that's purely cosmetical. There are a number of patches floating 
> around with DPDK_2.3 {} and librte_eal actually has one on board, so 
> clearly the dust from versioning change has not yet settled.

Maybe Thomas can give some advice here? DPDK_2.3 or DPDK_16.04 be used here?

Thanks,
Jianfeng

>
>     - Panu -
>
>>
>> Thanks,
>> Jianfeng
>>
>>>
>>>     - Panu -
>>>
>>>
>>
>