From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCH 4/6] spi: davinci: set new SPI_FC_* flags References: <56D448E1.6090006@de.bosch.com> <1456843400-20696-1-git-send-email-linux@rempel-privat.de> <1456843400-20696-4-git-send-email-linux@rempel-privat.de> <20160302021616.GP18327@sirena.org.uk> From: fixed-term.Oleksij.Rempel Message-ID: <56D68EEC.8000901@de.bosch.com> Date: Wed, 2 Mar 2016 07:57:48 +0100 MIME-Version: 1.0 In-Reply-To: <20160302021616.GP18327@sirena.org.uk> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit To: Mark Brown , Oleksij Rempel Cc: geert@linux-m68k.org, dirk.behme@de.bosch.com, linux-spi@vger.kernel.org, devicetree@vger.kernel.org, robh+dt@kernel.org List-ID: -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Beside, this probably should be done by main patch. In other case this will brake compilation - ware bad for bisecting. On 02.03.2016 03:16, Mark Brown wrote: > On Tue, Mar 01, 2016 at 03:43:18PM +0100, Oleksij Rempel wrote: > >> - if (spi->mode & SPI_READY) { + if (spi->mode & SPI_FC_READY) >> { > > This isn't setting new flags, this is replacing old flags with new > ones which suggests that the patch renaming the flag needs to > rename the flag in all the drivers... > -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iF4EAREIAAYFAlbWjusACgkQHwImuRkmbWmj6QD/VWneJFfDJb4cq6e4mpM3AjER wA5p8k5RMwBr3/SaETcA/iPDHn1jstR1tgN2lQV4tRBmAVBz8U5cyKefJlmuvwu1 =8TBT -----END PGP SIGNATURE-----