Re: [Qemu-devel] [PULL 3/8] egl-helpers: add functions for render nodes and dma-buf passing

From: Paolo Bonzini <pbonzini@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PULL 3/8] egl-helpers: add functions for render nodes and dma-buf passing
Date: Wed, 2 Mar 2016 15:14:16 +0100	[thread overview]
Message-ID: <56D6F538.4090004@redhat.com> (raw)
In-Reply-To: <1456237462-3687-4-git-send-email-kraxel@redhat.com>

On 23/02/2016 15:24, Gerd Hoffmann wrote:
> +        if (strncmp(e->d_name, "renderD", 7)) {
> +            continue;
> +        }
> +
> +        r = asprintf(&p, "/dev/dri/%s", e->d_name);
> +        if (r < 0) {
> +            return -1;
> +        }

This leaks "dir" (due to skipping the closedir call).  Easier to just
use g_strdup_printf which ignores the possibility of a malloc failure.

Paolo