From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752461AbcCGJpq (ORCPT ); Mon, 7 Mar 2016 04:45:46 -0500 Received: from mx2.suse.de ([195.135.220.15]:39700 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751938AbcCGJph (ORCPT ); Mon, 7 Mar 2016 04:45:37 -0500 Subject: Re: [PATCH v2 4/5] mm, kswapd: replace kswapd compaction with waking up kcompactd To: Andrew Morton References: <1454938691-2197-1-git-send-email-vbabka@suse.cz> <1454938691-2197-5-git-send-email-vbabka@suse.cz> <20160302063322.GB32695@js1304-P5Q-DELUXE> <56D6BACB.7060005@suse.cz> <56D6F41D.9080107@suse.cz> <56D6FB77.2090801@suse.cz> <56D70543.60806@suse.cz> <20160304152507.18b1362f51b0860a1268a977@linux-foundation.org> Cc: Joonsoo Kim , Joonsoo Kim , Linux Memory Management List , LKML , Andrea Arcangeli , "Kirill A. Shutemov" , Rik van Riel , Mel Gorman , David Rientjes , Michal Hocko , Johannes Weiner From: Vlastimil Babka Message-ID: <56DD4DBC.5090705@suse.cz> Date: Mon, 7 Mar 2016 10:45:32 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160304152507.18b1362f51b0860a1268a977@linux-foundation.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/05/2016 12:25 AM, Andrew Morton wrote: > On Wed, 2 Mar 2016 16:22:43 +0100 Vlastimil Babka wrote: > >> On 03/02/2016 03:59 PM, Joonsoo Kim wrote: >>> 2016-03-02 23:40 GMT+09:00 Vlastimil Babka : >>>> On 03/02/2016 03:22 PM, Joonsoo Kim wrote: >>>> >>>> So I understand that patch 5 would be just about this? >>>> >>>> - if (compaction_restarting(zone, cc->order) && !current_is_kcompactd()) >>>> + if (compaction_restarting(zone, cc->order)) >>>> __reset_isolation_suitable(zone); >>> >>> Yeah, you understand correctly. :) >>> >>>> I'm more inclined to fold it in that case. >>> >>> Patch would be just simple, but, I guess it would cause some difference >>> in test result. But, I'm okay for folding. >> >> Thanks. Andrew, should I send now patch folding patch 4/5 and 5/5 with >> all the accumulated fixlets (including those I sent earlier today) and >> combined changelog, or do you want to apply the new fixlets separately >> first and let them sit for a week or so? In any case, sorry for the churn. > > Did I get everything? Yeah, thanks! I'll send the squash in few days (also with a vmstat typo fix that Hugh pointed out in another thread). > http://ozlabs.org/~akpm/mmots/broken-out/mm-kswapd-remove-bogus-check-of-balance_classzone_idx.patch > http://ozlabs.org/~akpm/mmots/broken-out/mm-compaction-introduce-kcompactd.patch > http://ozlabs.org/~akpm/mmots/broken-out/mm-compaction-introduce-kcompactd-fix.patch > http://ozlabs.org/~akpm/mmots/broken-out/mm-compaction-introduce-kcompactd-fix-2.patch > http://ozlabs.org/~akpm/mmots/broken-out/mm-compaction-introduce-kcompactd-fix-3.patch > http://ozlabs.org/~akpm/mmots/broken-out/mm-memory-hotplug-small-cleanup-in-online_pages.patch > http://ozlabs.org/~akpm/mmots/broken-out/mm-kswapd-replace-kswapd-compaction-with-waking-up-kcompactd.patch > http://ozlabs.org/~akpm/mmots/broken-out/mm-kswapd-replace-kswapd-compaction-with-waking-up-kcompactd-fix.patch > http://ozlabs.org/~akpm/mmots/broken-out/mm-compaction-adapt-isolation_suitable-flushing-to-kcompactd.patch > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50]) by kanga.kvack.org (Postfix) with ESMTP id 46B4C6B0254 for ; Mon, 7 Mar 2016 04:45:38 -0500 (EST) Received: by mail-wm0-f50.google.com with SMTP id l68so63198179wml.1 for ; Mon, 07 Mar 2016 01:45:38 -0800 (PST) Received: from mx2.suse.de (mx2.suse.de. [195.135.220.15]) by mx.google.com with ESMTPS id bo10si18077863wjb.163.2016.03.07.01.45.36 for (version=TLS1 cipher=AES128-SHA bits=128/128); Mon, 07 Mar 2016 01:45:36 -0800 (PST) Subject: Re: [PATCH v2 4/5] mm, kswapd: replace kswapd compaction with waking up kcompactd References: <1454938691-2197-1-git-send-email-vbabka@suse.cz> <1454938691-2197-5-git-send-email-vbabka@suse.cz> <20160302063322.GB32695@js1304-P5Q-DELUXE> <56D6BACB.7060005@suse.cz> <56D6F41D.9080107@suse.cz> <56D6FB77.2090801@suse.cz> <56D70543.60806@suse.cz> <20160304152507.18b1362f51b0860a1268a977@linux-foundation.org> From: Vlastimil Babka Message-ID: <56DD4DBC.5090705@suse.cz> Date: Mon, 7 Mar 2016 10:45:32 +0100 MIME-Version: 1.0 In-Reply-To: <20160304152507.18b1362f51b0860a1268a977@linux-foundation.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Andrew Morton Cc: Joonsoo Kim , Joonsoo Kim , Linux Memory Management List , LKML , Andrea Arcangeli , "Kirill A. Shutemov" , Rik van Riel , Mel Gorman , David Rientjes , Michal Hocko , Johannes Weiner On 03/05/2016 12:25 AM, Andrew Morton wrote: > On Wed, 2 Mar 2016 16:22:43 +0100 Vlastimil Babka wrote: > >> On 03/02/2016 03:59 PM, Joonsoo Kim wrote: >>> 2016-03-02 23:40 GMT+09:00 Vlastimil Babka : >>>> On 03/02/2016 03:22 PM, Joonsoo Kim wrote: >>>> >>>> So I understand that patch 5 would be just about this? >>>> >>>> - if (compaction_restarting(zone, cc->order) && !current_is_kcompactd()) >>>> + if (compaction_restarting(zone, cc->order)) >>>> __reset_isolation_suitable(zone); >>> >>> Yeah, you understand correctly. :) >>> >>>> I'm more inclined to fold it in that case. >>> >>> Patch would be just simple, but, I guess it would cause some difference >>> in test result. But, I'm okay for folding. >> >> Thanks. Andrew, should I send now patch folding patch 4/5 and 5/5 with >> all the accumulated fixlets (including those I sent earlier today) and >> combined changelog, or do you want to apply the new fixlets separately >> first and let them sit for a week or so? In any case, sorry for the churn. > > Did I get everything? Yeah, thanks! I'll send the squash in few days (also with a vmstat typo fix that Hugh pointed out in another thread). > http://ozlabs.org/~akpm/mmots/broken-out/mm-kswapd-remove-bogus-check-of-balance_classzone_idx.patch > http://ozlabs.org/~akpm/mmots/broken-out/mm-compaction-introduce-kcompactd.patch > http://ozlabs.org/~akpm/mmots/broken-out/mm-compaction-introduce-kcompactd-fix.patch > http://ozlabs.org/~akpm/mmots/broken-out/mm-compaction-introduce-kcompactd-fix-2.patch > http://ozlabs.org/~akpm/mmots/broken-out/mm-compaction-introduce-kcompactd-fix-3.patch > http://ozlabs.org/~akpm/mmots/broken-out/mm-memory-hotplug-small-cleanup-in-online_pages.patch > http://ozlabs.org/~akpm/mmots/broken-out/mm-kswapd-replace-kswapd-compaction-with-waking-up-kcompactd.patch > http://ozlabs.org/~akpm/mmots/broken-out/mm-kswapd-replace-kswapd-compaction-with-waking-up-kcompactd-fix.patch > http://ozlabs.org/~akpm/mmots/broken-out/mm-compaction-adapt-isolation_suitable-flushing-to-kcompactd.patch > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org