From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Hennerich Subject: Re: [PATCH v3] iio: dac: Add support for the AD5592R/AD5593R ADCs/DACs Date: Mon, 7 Mar 2016 13:26:59 +0100 Message-ID: <56DD7393.5070207@analog.com> References: <1457009883-4017-1-git-send-email-michael.hennerich@analog.com> <20160305042952.GA13525@rob-hp-laptop> Reply-To: Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-by2on0066.outbound.protection.outlook.com ([207.46.100.66]:55485 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750836AbcCGMem (ORCPT ); Mon, 7 Mar 2016 07:34:42 -0500 In-Reply-To: <20160305042952.GA13525@rob-hp-laptop> Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Rob Herring Cc: jic23@kernel.org, linus.walleij@linaro.org, gnurou@gmail.com, lars@metafoo.de, knaack.h@gmx.de, paul.cercueil@analog.com, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org On 03/05/2016 05:29 AM, Rob Herring wrote: > On Thu, Mar 03, 2016 at 01:58:03PM +0100, michael.hennerich@analog.com wrote: >> From: Paul Cercueil >> >> This patch adds support for the AD5592R (spi) and AD5593R (i2c) >> ADC/DAC devices. >> >> Signed-off-by: Paul Cercueil >> Signed-off-by: Michael Hennerich > > [...] > >> +AD5592R Example: >> + >> + #include >> + >> + vref: regulator-vref { >> + compatible = "regulator-fixed"; >> + regulator-name = "vref-ad559x"; >> + regulator-min-microvolt = <3300000>; >> + regulator-max-microvolt = <3300000>; >> + regulator-always-on; >> + }; >> + >> + ad5592r@0 { >> + #size-cells = <0>; >> + #address-cells = <1>; >> + compatible = "adi,ad5592r"; >> + reg = <0>; >> + spi-max-frequency = <1000000>; >> + spi-cpol; >> + >> + vref-supply = <&vref>; /* optional */ >> + reset-gpios = <&gpio0 86 0>; /* optional */ >> + >> + channel@0 { >> + reg = <0>; >> + mode = ; > > You are missing the vendor prefixes thoughout. > Thanks Right - I'll fix this ASAP. -- Greetings, Michael -- Analog Devices GmbH Wilhelm-Wagenfeld-Str. 6 80807 Muenchen Sitz der Gesellschaft: Muenchen; Registergericht: Muenchen HRB 40368; Geschaeftsfuehrer:Dr.Carsten Suckrow, Thomas Wessel, William A. Martin, Margaret Seif From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Reply-To: Subject: Re: [PATCH v3] iio: dac: Add support for the AD5592R/AD5593R ADCs/DACs References: <1457009883-4017-1-git-send-email-michael.hennerich@analog.com> <20160305042952.GA13525@rob-hp-laptop> To: Rob Herring CC: , , , , , , , , , , , From: Michael Hennerich Message-ID: <56DD7393.5070207@analog.com> Date: Mon, 7 Mar 2016 13:26:59 +0100 MIME-Version: 1.0 In-Reply-To: <20160305042952.GA13525@rob-hp-laptop> Content-Type: text/plain; charset="windows-1252"; format=flowed List-ID: On 03/05/2016 05:29 AM, Rob Herring wrote: > On Thu, Mar 03, 2016 at 01:58:03PM +0100, michael.hennerich@analog.com wrote: >> From: Paul Cercueil >> >> This patch adds support for the AD5592R (spi) and AD5593R (i2c) >> ADC/DAC devices. >> >> Signed-off-by: Paul Cercueil >> Signed-off-by: Michael Hennerich > > [...] > >> +AD5592R Example: >> + >> + #include >> + >> + vref: regulator-vref { >> + compatible = "regulator-fixed"; >> + regulator-name = "vref-ad559x"; >> + regulator-min-microvolt = <3300000>; >> + regulator-max-microvolt = <3300000>; >> + regulator-always-on; >> + }; >> + >> + ad5592r@0 { >> + #size-cells = <0>; >> + #address-cells = <1>; >> + compatible = "adi,ad5592r"; >> + reg = <0>; >> + spi-max-frequency = <1000000>; >> + spi-cpol; >> + >> + vref-supply = <&vref>; /* optional */ >> + reset-gpios = <&gpio0 86 0>; /* optional */ >> + >> + channel@0 { >> + reg = <0>; >> + mode = ; > > You are missing the vendor prefixes thoughout. > Thanks Right - I'll fix this ASAP. -- Greetings, Michael -- Analog Devices GmbH Wilhelm-Wagenfeld-Str. 6 80807 Muenchen Sitz der Gesellschaft: Muenchen; Registergericht: Muenchen HRB 40368; Geschaeftsfuehrer:Dr.Carsten Suckrow, Thomas Wessel, William A. Martin, Margaret Seif