From mboxrd@z Thu Jan 1 00:00:00 1970 From: Panu Matilainen Subject: Re: [PATCH] eal: add option --avail-cores to detect lcores Date: Tue, 8 Mar 2016 10:54:49 +0200 Message-ID: <56DE9359.1090705@redhat.com> References: <1453661393-85704-1-git-send-email-jianfeng.tan@intel.com> <1457085957-115339-1-git-send-email-jianfeng.tan@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit To: Jianfeng Tan , dev@dpdk.org Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id C49AD1396 for ; Tue, 8 Mar 2016 09:54:51 +0100 (CET) In-Reply-To: <1457085957-115339-1-git-send-email-jianfeng.tan@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 03/04/2016 12:05 PM, Jianfeng Tan wrote: > This patch adds option, --avail-cores, to use lcores which are available > by calling pthread_getaffinity_np() to narrow down detected cores before > parsing coremask (-c), corelist (-l), and coremap (--lcores). > > Test example: > $ taskset 0xc0000 ./examples/helloworld/build/helloworld \ > --avail-cores -m 1024 > > Signed-off-by: Jianfeng Tan > Acked-by: Neil Horman Hmm, to me this sounds like something that should be done always so there's no need for an option. Or if there's a chance it might do the wrong thing in some rare circumstance then perhaps there should be a disabler option instead? Or am I just missing something? - Panu -