From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753813AbcCHLD2 (ORCPT ); Tue, 8 Mar 2016 06:03:28 -0500 Received: from mx1.redhat.com ([209.132.183.28]:60564 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750791AbcCHLD1 (ORCPT ); Tue, 8 Mar 2016 06:03:27 -0500 Message-ID: <56DEB17C.9000201@redhat.com> Date: Tue, 08 Mar 2016 06:03:24 -0500 From: Prarit Bhargava User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Thomas Gleixner CC: linux-kernel@vger.kernel.org, Petr Mladek , John Stultz , Xunlei Pang , Baolin Wang , Andrew Morton , Greg Kroah-Hartman , Petr Mladek , Tejun Heo , Peter Hurley , Vasily Averin , Joe Perches Subject: Re: [PATCH 0/2 v6] printk, Add monotonic and real printk timestamps References: <1456250040-22351-1-git-send-email-prarit@redhat.com> In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Tue, 08 Mar 2016 11:03:26 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/08/2016 02:59 AM, Thomas Gleixner wrote: > On Tue, 23 Feb 2016, Prarit Bhargava wrote: > >> This patchset adds monotonic and real printk timestamps. The first patch >> changes CONFIG_PRINT_TIME from a bool to an int to allow for the additional >> timestamps that are added in patch 2. >> >> Changes from v6: Petr Mladek pointed out that the current patch >> fails to indicate to userspace programs which timestamp is being used. > > How is that solved? Hi Thomas, Userspace programs can now look at /sys/modules/printk/parameters/time which will contain [0-3] for the timestamp clock. The file is globally readable so it shouldn't cause any problems for userspace programs: [root@intel-wildcatpass-06 dummy-module]# ls -l /sys/module/printk/parameters/time -rw-r--r--. 1 root root 4096 Mar 8 06:01 /sys/module/printk/parameters/time P. > > Thanks, > > tglx >