From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751311AbcCKJ7o (ORCPT ); Fri, 11 Mar 2016 04:59:44 -0500 Received: from mx2.suse.de ([195.135.220.15]:59192 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750705AbcCKJ7g (ORCPT ); Fri, 11 Mar 2016 04:59:36 -0500 Subject: Re: [PATCH 02/18] mm: make vm_mmap killable To: Michal Hocko , LKML References: <1456752417-9626-1-git-send-email-mhocko@kernel.org> <1456752417-9626-3-git-send-email-mhocko@kernel.org> Cc: Andrew Morton , linux-mm@kvack.org, Alex Deucher , Alex Thorlton , Andrea Arcangeli , Andy Lutomirski , Benjamin LaHaise , =?UTF-8?Q?Christian_K=c3=b6nig?= , Daniel Vetter , Dave Hansen , David Airlie , Davidlohr Bueso , David Rientjes , "H . Peter Anvin" , Hugh Dickins , Ingo Molnar , Johannes Weiner , "Kirill A . Shutemov" , Konstantin Khlebnikov , linux-arch@vger.kernel.org, Mel Gorman , Oleg Nesterov , Peter Zijlstra , Petr Cermak , Thomas Gleixner , Michal Hocko , Al Viro From: Vlastimil Babka Message-ID: <56E29702.5030100@suse.cz> Date: Fri, 11 Mar 2016 10:59:30 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1456752417-9626-3-git-send-email-mhocko@kernel.org> Content-Type: text/plain; charset=iso-8859-2; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/29/2016 02:26 PM, Michal Hocko wrote: > From: Michal Hocko > > All the callers of vm_mmap seem to check for the failure already > and bail out in one way or another on the error which means that Hmm I'm not that sure about this one: 17 1071 fs/binfmt_elf.c <> Assigns result of vm_mmap() to "error" variable which is never checked. Shouldn't __must_check trigger here? From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vlastimil Babka Subject: Re: [PATCH 02/18] mm: make vm_mmap killable Date: Fri, 11 Mar 2016 10:59:30 +0100 Message-ID: <56E29702.5030100@suse.cz> References: <1456752417-9626-1-git-send-email-mhocko@kernel.org> <1456752417-9626-3-git-send-email-mhocko@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-2; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1456752417-9626-3-git-send-email-mhocko@kernel.org> Sender: owner-linux-mm@kvack.org To: Michal Hocko , LKML Cc: Andrew Morton , linux-mm@kvack.org, Alex Deucher , Alex Thorlton , Andrea Arcangeli , Andy Lutomirski , Benjamin LaHaise , =?UTF-8?Q?Christian_K=c3=b6nig?= , Daniel Vetter , Dave Hansen , David Airlie , Davidlohr Bueso , David Rientjes , "H . Peter Anvin" , Hugh Dickins , Ingo Molnar , Johannes Weiner , "Kirill A . Shutemov" , Konstantin Khlebnikov , linux-arch@vger.kernel.org, Mel Gorman , Oleg Nesterov , Peter Zijlstra , Petr List-Id: linux-arch.vger.kernel.org On 02/29/2016 02:26 PM, Michal Hocko wrote: > From: Michal Hocko > > All the callers of vm_mmap seem to check for the failure already > and bail out in one way or another on the error which means that Hmm I'm not that sure about this one: 17 1071 fs/binfmt_elf.c <> Assigns result of vm_mmap() to "error" variable which is never checked. Shouldn't __must_check trigger here? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41]) by kanga.kvack.org (Postfix) with ESMTP id 7EFC36B0005 for ; Fri, 11 Mar 2016 04:59:35 -0500 (EST) Received: by mail-wm0-f41.google.com with SMTP id p65so10949692wmp.1 for ; Fri, 11 Mar 2016 01:59:35 -0800 (PST) Subject: Re: [PATCH 02/18] mm: make vm_mmap killable References: <1456752417-9626-1-git-send-email-mhocko@kernel.org> <1456752417-9626-3-git-send-email-mhocko@kernel.org> From: Vlastimil Babka Message-ID: <56E29702.5030100@suse.cz> Date: Fri, 11 Mar 2016 10:59:30 +0100 MIME-Version: 1.0 In-Reply-To: <1456752417-9626-3-git-send-email-mhocko@kernel.org> Content-Type: text/plain; charset=iso-8859-2; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Michal Hocko , LKML Cc: Andrew Morton , linux-mm@kvack.org, Alex Deucher , Alex Thorlton , Andrea Arcangeli , Andy Lutomirski , Benjamin LaHaise , =?UTF-8?Q?Christian_K=c3=b6nig?= , Daniel Vetter , Dave Hansen , David Airlie , Davidlohr Bueso , David Rientjes , "H . Peter Anvin" , Hugh Dickins , Ingo Molnar , Johannes Weiner , "Kirill A . Shutemov" , Konstantin Khlebnikov , linux-arch@vger.kernel.org, Mel Gorman , Oleg Nesterov , Peter Zijlstra , Petr Cermak , Thomas Gleixner , Michal Hocko , Al Viro On 02/29/2016 02:26 PM, Michal Hocko wrote: > From: Michal Hocko > > All the callers of vm_mmap seem to check for the failure already > and bail out in one way or another on the error which means that Hmm I'm not that sure about this one: 17 1071 fs/binfmt_elf.c <> Assigns result of vm_mmap() to "error" variable which is never checked. Shouldn't __must_check trigger here? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org