From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christian Borntraeger Subject: Re: [PATCH] Replacing (and removing) get_ticks_per_sec() function with NANOSECONDS_PER_SECOND Signed-off-by: Rutuja Shah Date: Fri, 11 Mar 2016 13:12:25 +0100 Message-ID: <56E2B629.7080405@de.ibm.com> References: <1457638209-14218-1-git-send-email-rutu.shah.26@gmail.com> <56E2AFA1.5010201@de.ibm.com> <56E2B4EA.4050305@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: peter.maydell@linaro.org, kvm@vger.kernel.org, mst@redhat.com, jasowang@redhat.com, mark.cave-ayland@ilande.co.uk, lcapitulino@redhat.com, kraxel@redhat.com, qemu-block@nongnu.org, agraf@suse.de, samuel.thibault@ens-lyon.org, balrogg@gmail.com, alistair.francis@xilinx.com, qemu-arm@nongnu.org, stefanha@redhat.com, cornelia.huck@de.ibm.com, rth@twiddle.net, kwolf@redhat.com, crosthwaite.peter@gmail.com, armbru@redhat.com, blauwirbel@gmail.co, qemu-ppc@nongnu.org, imammedo@redhat.com To: Paolo Bonzini , rutu.shah.26@gmail.com, qemu-devel@nongnu.org Return-path: In-Reply-To: <56E2B4EA.4050305@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-block-bounces+gceqb-qemu-block=m.gmane.org@nongnu.org Sender: qemu-block-bounces+gceqb-qemu-block=m.gmane.org@nongnu.org List-Id: kvm.vger.kernel.org On 03/11/2016 01:07 PM, Paolo Bonzini wrote: > > > On 11/03/2016 12:44, Christian Borntraeger wrote: >>> - s->tick_offset_vmstate = s->tick_offset + delta / get_ticks_per_sec(); >>>> + s->tick_offset_vmstate = s->tick_offset + delta / NANOSECONDS_PER_SECOND; >> [...] >> >> While technically correct, I do not like these changes. The interfaces expect "ticks", >> and the fact that this happens to be a nanosecond does not help regarding >> readability. > > Actually, I think usage of "tick" in this file is just for historical > reasons. So in essence the patch is ok and we should try to get rid of the "tick" word in future patches? Christian From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59956) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aeLvv-00028b-5B for qemu-devel@nongnu.org; Fri, 11 Mar 2016 07:12:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aeLvr-0001Ij-LH for qemu-devel@nongnu.org; Fri, 11 Mar 2016 07:12:43 -0500 Received: from e06smtp14.uk.ibm.com ([195.75.94.110]:49531) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aeLvr-0001Hj-9x for qemu-devel@nongnu.org; Fri, 11 Mar 2016 07:12:39 -0500 Received: from localhost by e06smtp14.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 11 Mar 2016 12:12:37 -0000 References: <1457638209-14218-1-git-send-email-rutu.shah.26@gmail.com> <56E2AFA1.5010201@de.ibm.com> <56E2B4EA.4050305@redhat.com> From: Christian Borntraeger Message-ID: <56E2B629.7080405@de.ibm.com> Date: Fri, 11 Mar 2016 13:12:25 +0100 MIME-Version: 1.0 In-Reply-To: <56E2B4EA.4050305@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Replacing (and removing) get_ticks_per_sec() function with NANOSECONDS_PER_SECOND Signed-off-by: Rutuja Shah List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , rutu.shah.26@gmail.com, qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, kvm@vger.kernel.org, mst@redhat.com, jasowang@redhat.com, mark.cave-ayland@ilande.co.uk, lcapitulino@redhat.com, kraxel@redhat.com, qemu-block@nongnu.org, agraf@suse.de, samuel.thibault@ens-lyon.org, alistair.francis@xilinx.com, qemu-arm@nongnu.org, stefanha@redhat.com, cornelia.huck@de.ibm.com, jsnow@redhat.com, rth@twiddle.net, kwolf@redhat.com, crosthwaite.peter@gmail.com, armbru@redhat.com, blauwirbel@gmail.co, qemu-ppc@nongnu.org, imammedo@redhat.com On 03/11/2016 01:07 PM, Paolo Bonzini wrote: > > > On 11/03/2016 12:44, Christian Borntraeger wrote: >>> - s->tick_offset_vmstate = s->tick_offset + delta / get_ticks_per_sec(); >>>> + s->tick_offset_vmstate = s->tick_offset + delta / NANOSECONDS_PER_SECOND; >> [...] >> >> While technically correct, I do not like these changes. The interfaces expect "ticks", >> and the fact that this happens to be a nanosecond does not help regarding >> readability. > > Actually, I think usage of "tick" in this file is just for historical > reasons. So in essence the patch is ok and we should try to get rid of the "tick" word in future patches? Christian