From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oliver Hartkopp Subject: Re: [PATCH v2] can: rcar_canfd: Add Renesas R-Car CAN FD driver Date: Sat, 12 Mar 2016 19:49:22 +0100 Message-ID: <56E464B2.5050303@hartkopp.net> References: <1456824849-7987-1-git-send-email-ramesh.shanmugasundaram@bp.renesas.com> <1457019515-21158-1-git-send-email-ramesh.shanmugasundaram@bp.renesas.com> <56DC1561.9060306@hartkopp.net> <56DD36F5.2000308@pengutronix.de> <56DE8345.50901@hartkopp.net> <56DEC49D.4@hartkopp.net> <56DF0900.6090906@hartkopp.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-renesas-soc-owner@vger.kernel.org To: Ramesh Shanmugasundaram , Marc Kleine-Budde , "wg@grandegger.com" , "robh+dt@kernel.org" , "pawel.moll@arm.com" , "mark.rutland@arm.com" , "ijc+devicetree@hellion.org.uk" , "galak@codeaurora.org" , "corbet@lwn.net" Cc: "linux-renesas-soc@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-can@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-doc@vger.kernel.org" , "geert+renesas@glider.be" , Chris Paterson List-Id: linux-can.vger.kernel.org Hi Ramesh, On 03/11/2016 08:14 AM, Ramesh Shanmugasundaram wrote: > As we are fixing this issue in CAN dev.c, I'll remove this check in ndo_open and set CAN_CTRLMODE_FD flag in ctrlmode & remove the flag in ctrlmode_supported in the next v3 version of the patch. I posted a V2 version of that fix some minutes ago. It also adds some documentation and a new variable ctrlmode_static which makes it clear how to specify static/fixed control modes. Please use the new can_set_static_ctrlmode() helper as suggested in the changes for m_can.c. A feedback is welcome whether this new fix fits your expectations. > Are there any further comments on v2 patch please? Besides the stuff I wrote above: No :-) Best regards, Oliver