From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933597AbcCNF1H (ORCPT ); Mon, 14 Mar 2016 01:27:07 -0400 Received: from mail-by2on0070.outbound.protection.outlook.com ([207.46.100.70]:36321 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933477AbcCNF02 (ORCPT ); Mon, 14 Mar 2016 01:26:28 -0400 Authentication-Results: lists.linux-foundation.org; dkim=none (message not signed) header.d=none;lists.linux-foundation.org; dmarc=none action=none header.from=amd.com; Subject: Re: [PATCH V5 02/10] perf/amd/iommu: Consolidate and move perf_event_amd_iommu header To: Peter Zijlstra References: <1456236764-1569-1-git-send-email-Suravee.Suthikulpanit@amd.com> <1456236764-1569-3-git-send-email-Suravee.Suthikulpanit@amd.com> <20160312132224.GI6344@twins.programming.kicks-ass.net> CC: , , , , , , , , From: Suravee Suthikulpanit Message-ID: <56E64B68.3090505@amd.com> Date: Mon, 14 Mar 2016 12:26:00 +0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160312132224.GI6344@twins.programming.kicks-ass.net> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [124.121.8.20] X-ClientProxiedBy: HKXPR03CA0079.apcprd03.prod.outlook.com (25.163.104.37) To BLUPR12MB0436.namprd12.prod.outlook.com (25.162.92.141) X-MS-Office365-Filtering-Correlation-Id: 46da3201-f30d-4ba2-c05f-08d34bc92cfc X-Microsoft-Exchange-Diagnostics: 1;BLUPR12MB0436;2:ewCSZBnl4H1d896RLMCvfZI1k/cJmy2Gg2qjkcl30vUhwDpkWN+9zUSY46bbNITScJpzXBUsV+oipllWkx8NEI9z2NPSYIHM2pxaiz4OMFhs13of+AUjfpd7XxMrNG0l5FvewxYLcm19JaoC03+gFfWAwbzUt7MFpHdlmw8PXhRNH2dYbLiMxKu8ZQXFJrGO;3:ziGEethx/MkcKqq7l7v/3Dy8VSU71SqqZmYpMOvN71uONg8UCG9mGTCY7Z1kpt7aYWtG1I3Ys3pLelwdCXH2dH2Nxd9g/Cq74mjtJG0SISjaqtNS1beZBTTazrdz90gv;25:vbzTiPf1UJer7VikMkbEaztCovPzNaIwTgIgkXyW8phvZqC0ah9Uk2gOfycP9TOQRF2pDPZC93FSHbtfLOHtsNdI41wRIx+R218G13SeqmaTg8Up0ZORf7RHWfJC8ADqnSKvlDOszDTAMyAu5DWZVQNXEwIvdGSjmEckxNWZa+ksjP+9iW+Q0pYmFXmLPwHPFfIrfIO+TgefepFMp+WFh2IibWzkXaHZNTTY3IGM22X7r5sXwiitGEzaOoDa/1ijWScf1hK0z74JF0tmzOtEbMH0BBni3eSk84YfVllED5MKEJP8IU8rUtxfCqxCHj7DCKv87O7Jc4aCMXn4mMsgSA== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR12MB0436; X-Microsoft-Exchange-Diagnostics: 1;BLUPR12MB0436;20:BPMgdLTExfuJn96KaHkNjZI3GZ5dnInjKeGULVdKnQIwBs5yhbJejfNskKApO6KDFy0ht1B09EBYJBmYR7WwhdCLDkxi9XvJ64rCaLIRIO6+maXaBencyzkeTghXBxAGUb7NunFr0+Zf4ZjFcBokrMNFwTw93RlgOIL9LhwCBkihJjwqedvNU2w6LGe3TI570bwzpn2k1FPD+jy6hdxmLnIFQ9LbLfAIA9WPw/nKICtQG5g4/j0DfZGkRnqbjDn+7fxJLqbw1xmDcDKnbVx/ZtGIw+NvI+oHjf3Wkn13XixWgRB7oZsfETwlLwPyP81FUV/Ob0crBMDGFfPJFiNAA3WsdDWF4Cj4Wz1zyAVHI+JFFsp0VCYemdLFDcndQKp23pAWAlKrIrVZn/96wN+dVzoi+a2CRmmg1FJyHtwuHLNdIWC1Mna5x/CoutqI4GxBR4m4HdVekojYxVCWBBbnlwFJVe3l13UckoRAiDSHpzuXZKv0EfOXMYKwqJXWr42s;4:ouKF3077+mrWHCKQ2Ll4H2IxkpPpU9YBviEnYf105PwwhcORi+4DPzxCVNO4xpvN4M4Z/BhqSUdzp1OnvSVlkq3XUBSHvP35JHNrTG9kei5pc7FMx7+1vPs56qXW42Q3C1Qn6nmmq4QdOLw8ICs0PkrQwXowOAJgsyyZ0PNCyGY441mcFHkCR82FDIlKXW07Uv+SiKs2I8ZxHzTudZ4Tj8jHVdo4BjQNPWO4zrerox6/uPOofzWvWWi04F/tJxmL+g2UPaaF8vUQmLEbM3NeLNyDdjSScG3f5JDfaUnm0GE2PD5a+T/K8kicu9JDnKrZZ7Gxvy7nyrvX9PBx3+keDs7FYIN4AQtEr1R60jMDfJFAu1kFJqeaBnuBqf+6SsCA X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046);SRVR:BLUPR12MB0436;BCL:0;PCL:0;RULEID:;SRVR:BLUPR12MB0436; X-Forefront-PRVS: 0881A7A935 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(6049001)(24454002)(164054003)(377454003)(479174004)(92566002)(2950100001)(77096005)(586003)(3846002)(1096002)(50986999)(110136002)(66066001)(42186005)(81166005)(59896002)(117156001)(50466002)(189998001)(230700001)(36756003)(4001350100001)(80316001)(19580395003)(2906002)(86362001)(64126003)(23746002)(65956001)(87266999)(65806001)(47776003)(4326007)(6116002)(19580405001)(5008740100001)(54356999)(33656002)(83506001)(76176999);DIR:OUT;SFP:1101;SCL:1;SRVR:BLUPR12MB0436;H:[192.168.0.19];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BLUPR12MB0436;23:saiyCBnGsi0N/l59Xf+cWCvpL61y6dra4L9OP?= =?Windows-1252?Q?Nlg7i58C7FgYfS+afNbpn5ssgTwwvHZHOQgnaivcgN3zbamVJFDhz8yM?= =?Windows-1252?Q?+vF8abtvmhinw07mHOE0f5ic6nWctVnZ7XEsGEjxphIYSfwQRmbULx7O?= =?Windows-1252?Q?HWWxSnJ7MmEHkVsOZk5bYiA+2ExFM1NGVLi590VkVOoWoelO+KMrWoqZ?= =?Windows-1252?Q?9GJnqOC2nWeXQnVQpGPI9Y9B0pL6w5itQ9rpG5SF36b22DaoSvIGykCO?= =?Windows-1252?Q?v4VLY0nia/LgCHqGaSI4w0KFWIqeX/vVAoqf5J5lBqfKFDPrBR7tbanF?= =?Windows-1252?Q?i/oINItBJ35qQEIXlxXprVkdJcIuU8MWe7cfQAo72LGG2dUfnYEmBnPg?= =?Windows-1252?Q?x/4uHdOu2O4qVKYUNqymJptDDh19bM+nnowmkf5TuQdQbGlHTSfVcjRp?= =?Windows-1252?Q?pG7KNPN9IwsnNM8qy5Xcp2lKg+LOnOQCdGxkjay3tyhiZBcrXvaq2y1N?= =?Windows-1252?Q?Zz7Vr1YW0a4pF98R7P9Xbmdtgfqp6Z9Fd7swuuF/+szfh4pH6jyovPwe?= =?Windows-1252?Q?c/lcTak3OluB7hJE7F1BSHsbeuoKTVml4ETSd+9/81GBnTptLljNUNL8?= =?Windows-1252?Q?pb9xFxZhaVZuvpRUfIwTAOQ4NfVoxLQuCu3T0TxsT5I9hVTNGUWWrdx4?= =?Windows-1252?Q?w+0GUTe+JQ4ErxKRR35ivPZQFgLs163RMw7UFKlWfNSvmw4ev/Bc2iQ1?= =?Windows-1252?Q?rgtxXIUY3g63XP5+KFN03E4GHjb/pC1bIAEK9bV/QdRx4SUSKWOPVwXM?= =?Windows-1252?Q?+MLB2mJtVlPAhUyooQ74uJjaOVHdVXYB9e1nvATtkJkidMzaWm7Cszut?= =?Windows-1252?Q?Q0wCrpsNRWC3B9s04opaiAAofMQngaTqd2OCqa1GV4Kc4GIxRYnjtmL4?= =?Windows-1252?Q?fmM1UopnAwgnMS5BNhmd7pcw0ClggpjIwe8y3basSAFyKtT18lI/sVeq?= =?Windows-1252?Q?h8xm++NMwCZABNHvC2rYcJxAtxjFlh6znJdtTysYIQA9cKwF0pAGDopN?= =?Windows-1252?Q?f3iHA6TpxEMZsgSgeN8vmq5G+jSgnRLOj6l1HPQpM14opY9pEDRdJhnF?= =?Windows-1252?Q?rmC0Arw2ed4mY7Whc2NBRU2T7OD6eEsEpgcKADhxi+r76oSGOvB4XaG+?= =?Windows-1252?Q?6+lSPTgovPT31qW+/hlbRgy4binAYs=3D?= X-Microsoft-Exchange-Diagnostics: 1;BLUPR12MB0436;5:ARVvYwyHbegUD9o7yf+w8UKemXgWV4Rf0mwjs98OVwhZBG1oHbETRrTfImbyIqeLAUcpHSIktXWIP+WQ7q/xujFYL3tYUJOCY67njX5feCXlhngovV4hwJ6I7vjoFq8RYh1XeQ1RZ9F08fOU0iDIYQ==;24:jeeT5AkUJ8hzv8zyTKZQYVzaqyY2urirrDDEnc5Wa76o/n4oIaO2aUmcbaVvXE2qCxMwpAdCmKuIglIcXHhRNkeL3cVVHUEzAehSkTFQ0BE=;20:Qi5cqYXC0kAoSgAa0pUBeV5OiLA8Cbz+NAfpxf0uIl5ZJtGsWiB/iRB4bIJ2EYRj/LrZ5Gdw4I2ELtqm28UC0iGPbke+LduKB9a3zFxt3NSu2r6OfrZSqKDftjJ9hULXF98Ob3FNK4bijxyOIFjLYBdq+IS7jaP/Ox3RNdLw+G4RVe+3Q8GUbzqy8+XdUqkE5sRvJw0kTz9zzMsdVSDbvhVB6O90KdSkA+2eVXlCTbd3M2eWEIbUJOEbU5FGWMHo SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2016 05:26:17.0735 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR12MB0436 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 03/12/2016 08:22 PM, Peter Zijlstra wrote: > On Tue, Feb 23, 2016 at 08:12:36AM -0600, Suravee Suthikulpanit wrote: >> From: Suravee Suthikulpanit >> >> First, this patch move arch/x86/events/amd/iommu.h to >> arch/x86/include/asm/perf/amd/iommu.h so that we easily include >> it in both perf-amd-iommu and amd-iommu drivers. >> >> Then, we consolidate declaration of AMD IOMMU performance counter >> APIs into one file. > > These seem two independent thingies; should this therefore not be 2 > patches? > >> Reviewed-by: Joerg Roedel >> Signed-off-by: Suravee Suthikulpanit >> --- >> arch/x86/events/amd/iommu.c | 2 +- >> arch/x86/events/amd/iommu.h | 40 --------------------------------- >> arch/x86/include/asm/perf/amd/iommu.h | 42 +++++++++++++++++++++++++++++++++++ > > That seems somewhat excessive. Not only do you create > arch/x86/include/asm/perf/ you then put another directory on top of > that. > The original header files (arch/x86/events/amd/iommu.h and drivers/iommu/amd_iommu_proto.h) has duplicate function declarations. So, with the new header file being in the arch/x86/include/asm/perf/amd/iommu.h, we can just have one function declaration. So, you just want to separate the file moving part and the part that removes of the duplication? Thanks, Suravee From mboxrd@z Thu Jan 1 00:00:00 1970 From: Suravee Suthikulpanit Subject: Re: [PATCH V5 02/10] perf/amd/iommu: Consolidate and move perf_event_amd_iommu header Date: Mon, 14 Mar 2016 12:26:00 +0700 Message-ID: <56E64B68.3090505@amd.com> References: <1456236764-1569-1-git-send-email-Suravee.Suthikulpanit@amd.com> <1456236764-1569-3-git-send-email-Suravee.Suthikulpanit@amd.com> <20160312132224.GI6344@twins.programming.kicks-ass.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160312132224.GI6344-ndre7Fmf5hadTX5a5knrm8zTDFooKrT+cvkQGrU6aU0@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Peter Zijlstra Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, acme-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, andihartmann-KuiJ5kEpwI6ELgA04lAiVw@public.gmane.org, mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org, labbott-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org List-Id: iommu@lists.linux-foundation.org Hi, On 03/12/2016 08:22 PM, Peter Zijlstra wrote: > On Tue, Feb 23, 2016 at 08:12:36AM -0600, Suravee Suthikulpanit wrote: >> From: Suravee Suthikulpanit >> >> First, this patch move arch/x86/events/amd/iommu.h to >> arch/x86/include/asm/perf/amd/iommu.h so that we easily include >> it in both perf-amd-iommu and amd-iommu drivers. >> >> Then, we consolidate declaration of AMD IOMMU performance counter >> APIs into one file. > > These seem two independent thingies; should this therefore not be 2 > patches? > >> Reviewed-by: Joerg Roedel >> Signed-off-by: Suravee Suthikulpanit >> --- >> arch/x86/events/amd/iommu.c | 2 +- >> arch/x86/events/amd/iommu.h | 40 --------------------------------- >> arch/x86/include/asm/perf/amd/iommu.h | 42 +++++++++++++++++++++++++++++++++++ > > That seems somewhat excessive. Not only do you create > arch/x86/include/asm/perf/ you then put another directory on top of > that. > The original header files (arch/x86/events/amd/iommu.h and drivers/iommu/amd_iommu_proto.h) has duplicate function declarations. So, with the new header file being in the arch/x86/include/asm/perf/amd/iommu.h, we can just have one function declaration. So, you just want to separate the file moving part and the part that removes of the duplication? Thanks, Suravee