From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755240AbcCNHda (ORCPT ); Mon, 14 Mar 2016 03:33:30 -0400 Received: from mx2.suse.de ([195.135.220.15]:55584 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755217AbcCNHdT (ORCPT ); Mon, 14 Mar 2016 03:33:19 -0400 Subject: Re: [PATCH 07/22] ncr5380: Remove BOARD_REQUIRES_NO_DELAY macro To: Finn Thain , "James E.J. Bottomley" , "Martin K. Petersen" , Michael Schmitz , linux-m68k@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org References: <20160314042700.596192247@telegraphics.com.au> <20160314042702.466021574@telegraphics.com.au> Cc: Ondrej Zary , Sam Creasey From: Hannes Reinecke Message-ID: <56E6693C.4020804@suse.de> Date: Mon, 14 Mar 2016 08:33:16 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160314042702.466021574@telegraphics.com.au> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/14/2016 05:27 AM, Finn Thain wrote: > The io_recovery_delay macro is intended to insert a microsecond delay > between the chip register accesses that begin a DMA operation. This > is reportedly needed for some ISA boards. > > Reverse the sense of the macro test so that in the common case, > where no delay is required, drivers need not define the macro. > > Signed-off-by: Finn Thain > > --- > drivers/scsi/NCR5380.c | 18 ++++++++---------- > drivers/scsi/dtc.h | 2 ++ > drivers/scsi/g_NCR5380.h | 2 ++ > drivers/scsi/t128.h | 2 ++ > 4 files changed, 14 insertions(+), 10 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)