From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S933770AbcCNHnT (ORCPT <rfc822;w@1wt.eu>);
	Mon, 14 Mar 2016 03:43:19 -0400
Received: from mx2.suse.de ([195.135.220.15]:56132 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S933638AbcCNHnR (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 14 Mar 2016 03:43:17 -0400
Subject: Re: [PATCH 14/22] ncr5380: Add MAX_LUN limit
To: Finn Thain <fthain@telegraphics.com.au>,
        "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Michael Schmitz <schmitzmic@gmail.com>, linux-m68k@vger.kernel.org,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20160314042700.596192247@telegraphics.com.au>
 <20160314042704.285983735@telegraphics.com.au>
Cc: Ondrej Zary <linux@rainbow-software.org>, Sam Creasey <sammy@sammy.net>
From: Hannes Reinecke <hare@suse.de>
Message-ID: <56E66B93.1030506@suse.de>
Date: Mon, 14 Mar 2016 08:43:15 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.6.0
MIME-Version: 1.0
In-Reply-To: <20160314042704.285983735@telegraphics.com.au>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 03/14/2016 05:27 AM, Finn Thain wrote:
> The driver has a limit of eight LUs because of the byte-sized bitfield
> that is used for busy flags. Reject commands with LUN > 7.
> 
> Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
> 
> ---
>  drivers/scsi/NCR5380.c |    6 ++++++
>  drivers/scsi/NCR5380.h |    2 ++
>  2 files changed, 8 insertions(+)
> 
> Index: linux/drivers/scsi/NCR5380.c
> ===================================================================
> --- linux.orig/drivers/scsi/NCR5380.c	2016-03-14 15:26:45.000000000 +1100
> +++ linux/drivers/scsi/NCR5380.c	2016-03-14 15:26:48.000000000 +1100
> @@ -661,6 +661,12 @@ static int NCR5380_queue_command(struct
>  	}
>  #endif /* (NDEBUG & NDEBUG_NO_WRITE) */
>  
> +	if (cmd->device->lun > MAX_LUN) {
> +		cmd->result = DID_NO_CONNECT << 16;
> +		cmd->scsi_done(cmd);
> +		return 0;
> +	}
> +
>  	cmd->result = 0;
>  
>  	if (!NCR5380_acquire_dma_irq(instance))
> Index: linux/drivers/scsi/NCR5380.h
> ===================================================================
> --- linux.orig/drivers/scsi/NCR5380.h	2016-03-14 15:26:45.000000000 +1100
> +++ linux/drivers/scsi/NCR5380.h	2016-03-14 15:26:48.000000000 +1100
> @@ -244,6 +244,8 @@ struct NCR5380_hostdata {
>  
>  #ifdef __KERNEL__
>  
> +#define MAX_LUN	7
> +
>  struct NCR5380_cmd {
>  	struct list_head list;
>  };
> 
> 
Why not simply use shost->max_lun ?

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		   Teamlead Storage & Networking
hare@suse.de			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)