From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964794AbcCNIAA (ORCPT ); Mon, 14 Mar 2016 04:00:00 -0400 Received: from mx2.suse.de ([195.135.220.15]:57412 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933781AbcCNH7u (ORCPT ); Mon, 14 Mar 2016 03:59:50 -0400 Subject: Re: [PATCH 22/22] mac_scsi: Fix pseudo DMA implementation To: Finn Thain , "James E.J. Bottomley" , "Martin K. Petersen" , Michael Schmitz , linux-m68k@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org References: <20160314042700.596192247@telegraphics.com.au> <20160314042706.346025449@telegraphics.com.au> Cc: Ondrej Zary , Sam Creasey From: Hannes Reinecke Message-ID: <56E66F73.5030402@suse.de> Date: Mon, 14 Mar 2016 08:59:47 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160314042706.346025449@telegraphics.com.au> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/14/2016 05:27 AM, Finn Thain wrote: > Fix various issues: Comments about bus errors are incorrect. The > PDMA asm must return the size of the memory access that faulted so the > transfer count can be adjusted accordingly. A phase change may cause a > bus error but should not be treated as failure. A bus error does not > always imply a phase change and generally the transfer may continue. > Scatter/gather can't be used with PDMA due to overruns (which is a pity > because peak throughput seems to double with SG_ALL). > > Signed-off-by: Finn Thain > > --- > drivers/scsi/NCR5380.h | 2 > drivers/scsi/mac_scsi.c | 210 ++++++++++++++++++++++++++---------------------- > 2 files changed, 118 insertions(+), 94 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)