From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755560AbcCNNh0 (ORCPT ); Mon, 14 Mar 2016 09:37:26 -0400 Received: from mail-bn1on0084.outbound.protection.outlook.com ([157.56.110.84]:63651 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754154AbcCNNhX (ORCPT ); Mon, 14 Mar 2016 09:37:23 -0400 Authentication-Results: lists.linux-foundation.org; dkim=none (message not signed) header.d=none;lists.linux-foundation.org; dmarc=none action=none header.from=amd.com; Subject: Re: [PATCH V5 02/10] perf/amd/iommu: Consolidate and move perf_event_amd_iommu header To: Peter Zijlstra References: <1456236764-1569-1-git-send-email-Suravee.Suthikulpanit@amd.com> <1456236764-1569-3-git-send-email-Suravee.Suthikulpanit@amd.com> <20160312132224.GI6344@twins.programming.kicks-ass.net> <56E64B68.3090505@amd.com> <20160314095856.GL6344@twins.programming.kicks-ass.net> CC: , , , , , , , , From: Suravee Suthikulpanit Message-ID: <56E6BE7E.8010807@amd.com> Date: Mon, 14 Mar 2016 20:37:02 +0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160314095856.GL6344@twins.programming.kicks-ass.net> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [58.10.104.205] X-ClientProxiedBy: SIXPR04CA0052.apcprd04.prod.outlook.com (25.162.171.42) To BLUPR12MB0434.namprd12.prod.outlook.com (25.162.92.14) X-MS-Office365-Filtering-Correlation-Id: 1a8eb4bb-8cbc-40c2-ee53-08d34c0dc43c X-Microsoft-Exchange-Diagnostics: 1;BLUPR12MB0434;2:jDGrm23jaarh1nRPpyljSWPNTGml6+rf8gbj4iq970o8TVxSDCxez82OskipiZHcsHOHOB4i3qCaNDogDujDlkjRfQZw+k43Cr/CjpTBmy/erUDIdQfeG5nLtJMIQr1Osq5Mj9u6mKV/fXjN1P9PLZCuBxs49vjZuhfj4VZkUbhKwrKlYdVfu9XjxAx58Jnf;3:q4He4vqTYYmkKSgLoYCkzpMm/dxBufcucy83T9H15DlJhSSX2bcmj6+/ciruSSkttz1ZfJw+pFGu/5PfLYShWyOINuKlNt0iU0ajf51Q72u/P2GAx2uZjJhJD6B3YYQJ;25:LgcKq3b7mC2L5U6qCbsW6JLSvOVVSFOIdITEgTgv+OzNhtYXsDeAlXaiGYzRJilyh7vyUI2+MExstNTp+QLTnO3bM1Oq4KSWc1dnEpk9/9BstSYj81I0q6ybQRM7OY68Kp4Oyf+p+lywDMYKoqymuY7TtOUT3yhKzAS05VfCcEUaQW/6CzXsu3GAPQ+qHX208EZVEmzqH0/s3smWSnA9D+gN5xHLqL5Og76H7qdyP8wYuex//HZRC7CMlU0loAIAvZOqQiVyDvcIQHNEHfEoroM4z/eHnsCSjQaqKY22qurL1JHjo5WhxCdGCazW/6t3nhN+ydOcy59Sy2WTkDtGkg== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR12MB0434; X-Microsoft-Exchange-Diagnostics: 1;BLUPR12MB0434;20:SIyRxWmgbJ08h5O6x8tJXFJFYoc5TmLES5Bx6Ye7bTs4nQ3KTKSF4kQZ6Qaq0MvT8ZDNpbdIUvX3DNkdoX/YczUH6TIV68l84Ud145Hd106lPSUuP36SNpf1Od0UP42iVTDeXlUtOjJazaJ1+1SSBvaQs4pUb4w15YLEtaFZssSsMQhVsidstV2e9zHlnqC8FHHwmR3QMlHGwY4/2IkBuOL9lbYTsk91mpPpv7TWl1KiIe4T4IZeZBn8OaIemIpUJzlxv3irKYLGLKcBfSAVwMsxGJ3eht7hHVhobqS/fHE6uO95hwQqOhhdf8JlDWdX1OHM+Ao8TYLr7Oz4u6PitMe/AkCKG/PGhCK/EHeGHRKB7kJAr0BlTyirqCGGsOM9ce+KSk0JdhSmYjRbqtdX9HbD9VDtLOyzPTSLzYnK6K0GcKeAT6bl3wConMxantcHFjJvq0gUxMiCUs6Xgvzx0KrvuEoLJqSvJ0QY11DYirr5Rx+zExJ3KLq2B5iB2Py5;4:FUWu+yVqXgvzGu6KcYDdRNKrtvhKXJJeMRH4JJlfOSZjMMosOXZWkUKU1aVkOWl6A23H+wZh/JFLPSgYu/jVLTnsMJcGFJG3YUKEONe/iWaOR9osYx40dqJgNBSTLeef6aiN/7shyTvwpggTbqCz6Na2aKraT4ExProyer+/9vGoPa8nW1K6AUS23lwnuFpNzesiUWgHKYV4b5ZH15P8shrkgcKmtA+lDS410gWD/qu/LQGRi1YbXrbFT7bjm2mVHZXazE/20mpT1cSRj+Neilf2E8OrtkuFpWDsvlfpoN+jR/zcKwkDfkHcPv8qdU8AJOrXpzGPbZBLwVU+mZF9Y5DlkFWUtOaJu3lH4u7RItHFgdjAPgbFGTBaAYAlp/Tb X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046);SRVR:BLUPR12MB0434;BCL:0;PCL:0;RULEID:;SRVR:BLUPR12MB0434; X-Forefront-PRVS: 0881A7A935 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(24454002)(164054003)(377454003)(479174004)(19580405001)(189998001)(86362001)(50986999)(4001350100001)(54356999)(1096002)(5008740100001)(110136002)(3846002)(6116002)(64126003)(76176999)(77096005)(36756003)(586003)(59896002)(2906002)(5004730100002)(19580395003)(87266999)(80316001)(83506001)(65816999)(2950100001)(93886004)(33656002)(23746002)(66066001)(65956001)(65806001)(92566002)(47776003)(50466002)(230700001)(81166005)(42186005);DIR:OUT;SFP:1101;SCL:1;SRVR:BLUPR12MB0434;H:Suravees-MacBook-Pro.local;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BLUPR12MB0434;23:BaLNIh3dLpL2di1fBCV41vRhqF10wH492YlGJ?= =?Windows-1252?Q?OqOoNI407b9au++dzRV/6RE1HDq+V/WTwLZm5Hz8j8J1P5wiXvwQHCUN?= =?Windows-1252?Q?EuYGDpWly6aRrqZIQX80eg/V2ripQUqa081IWhNzBYrKTru0ed1ljsH2?= =?Windows-1252?Q?tfT1Eb4XYfe7q95KBrIZzgdX5mWcRnMEyNVKQxqQce9kXXQ7SFeGETxG?= =?Windows-1252?Q?3PGzcxwK0TntAcPPqMUe1MtUkCPUpoU+ndZB5PjZfBboVGp/rVOJpxfD?= =?Windows-1252?Q?0MTaVqJQ7S+bpba23KiI/7mihMSmSUjLQuU1KcHyk23xmiYkbC4hAiJz?= =?Windows-1252?Q?xyyXfYye+YLUVCdGD2C7hw7sSc/sp2t5mks9eU1HI6xFCZc1vrNFYmUT?= =?Windows-1252?Q?Ziw0yiSZ1EQNlRc2bhrG4lnNoXEwKD2/6guQxmQMTcB0AXwHoIPABKjv?= =?Windows-1252?Q?AcOM5n6odzEOdJ3NzWHlc46VLN7r9BvCdGEAfYjap0Gq7Dg8VRhIwGqV?= =?Windows-1252?Q?xjPXg6weJr9yWEIO4wn5jX5WmjubLj2NqzSXldESIQhRNVQ48MPhpM/6?= =?Windows-1252?Q?r7xGWd0DbuNy7lzhy5I4kQYRKoJq+xHBy120X6oUx22v1JTVMFppxTb/?= =?Windows-1252?Q?aXJeeAtHj5EfWSLKXq72jKoFVtuLzMNRu4IR2G5Uyr2NJuY4TQ26X2rd?= =?Windows-1252?Q?6XCCLHwf1CusQUftZVDgTXeS9sY+MRrr/KRHkWufMO8sOgkWvOR49is4?= =?Windows-1252?Q?E2KjP1kUMJ4oa0Ph/KznmnTop8ombYKVCUiEgzzOa5/CBlcrvtWzZV1Y?= =?Windows-1252?Q?ma5T7tGRMdtv8/2dHMUX5UUmC4zRxv9thurpeq4snFg16FAuP06hVHEi?= =?Windows-1252?Q?ajXr2KqXsrDke9POxk95ByCOcBffsiHII8QaoNYf4hx9HsAvSo6L8Vo3?= =?Windows-1252?Q?QDu6IUiXYnoSpttstsFYgl3igKqzu/sJjKiDcDAbP4efreL8s0vlvmlq?= =?Windows-1252?Q?g3hq1UW/OCdwpHvbk4isYtW9t7ugRmtPHtXOGNM4bw29R+D3JXNlRU04?= =?Windows-1252?Q?4K1VOUgqYxbc4HkN2azaHzXj9ewL8KH+MlCoY2BEgQa1z/e4HPrwTWh7?= =?Windows-1252?Q?gHRi+9Qbx2eIQuvGgrWOd2qwAUajuSVYPYOBi+WTOkKR4AXwOqHJ94hV?= =?Windows-1252?Q?b+vrNPI83DbUOV2mzMfrGgrxRqLQU1Q3xi8u4AQI2Myk8w/rzM5?= X-Microsoft-Exchange-Diagnostics: 1;BLUPR12MB0434;5:z1JDyzS9FFrsHObF8tMbKoPrQ4g2gtB9ux2viZn5XBtIuzySNNzUq/4G5ftKMZ7vUWRWfOyteI3aLmIhE9cFMmF62ZT/MFo728DrPWl11Fo5gZF5podYjJNfysFQNKBNKWo7RCx+7JQhVWBxp0ZH/w==;24:9NAimu4ycn5AD9Sp38odTVFrjfcBvn0XDsU/MTGlFXQ0u9Dk0xo0jpercHuE2+wB9QZiXU5Esj++FE9wD75HP+rl3qzN9LiRh/cKHLhwJnM=;20:ngMnFbW7Cjuo8OejlCxvNXabg+XnRV3/jIea5ept7kLDmxLiGFmyT5MSWAzpdEUXeAgyH3P0LclWPz7YVmnNTA8oDS8pcTLc5NUjc2tvl4TYkdUiBY7/0Es5bzisRHwqnqGOe0ysizuh55oBqh3gCPnXsmnw/cgCDN0cse28NYCZWbmQWvsK52O7CYn+yfg8WnzZuZgrBimMEMRJAPvHISLJ2pJKVptelCfZ2jEMs5uvUvjrMwpZbWKUj+C/QXSz SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2016 13:37:16.6234 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR12MB0434 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 3/14/16 16:58, Peter Zijlstra wrote: > On Mon, Mar 14, 2016 at 12:26:00PM +0700, Suravee Suthikulpanit wrote: >> Hi, >> >> On 03/12/2016 08:22 PM, Peter Zijlstra wrote: >>> On Tue, Feb 23, 2016 at 08:12:36AM -0600, Suravee Suthikulpanit wrote: >>>> From: Suravee Suthikulpanit >>>> >>>> First, this patch move arch/x86/events/amd/iommu.h to >>>> arch/x86/include/asm/perf/amd/iommu.h so that we easily include >>>> it in both perf-amd-iommu and amd-iommu drivers. >>>> >>>> Then, we consolidate declaration of AMD IOMMU performance counter >>>> APIs into one file. >>> >>> These seem two independent thingies; should this therefore not be 2 >>> patches? >>> >>>> Reviewed-by: Joerg Roedel >>>> Signed-off-by: Suravee Suthikulpanit >>>> --- >>>> arch/x86/events/amd/iommu.c | 2 +- >>>> arch/x86/events/amd/iommu.h | 40 --------------------------------- >>>> arch/x86/include/asm/perf/amd/iommu.h | 42 +++++++++++++++++++++++++++++++++++ >>> >>> That seems somewhat excessive. Not only do you create >>> arch/x86/include/asm/perf/ you then put another directory on top of >>> that. >>> >> >> The original header files (arch/x86/events/amd/iommu.h and >> drivers/iommu/amd_iommu_proto.h) has duplicate function declarations. So, >> with the new header file being in the arch/x86/include/asm/perf/amd/iommu.h, >> we can just have one function declaration. >> >> So, you just want to separate the file moving part and the part that removes >> of the duplication? > > I'm fine with a new header, it just seems putting it in a two deep > direcotry hierarchy of its own that seems excessive. > Basically, we are trying to match the current Perf hierarchy for AMD IOMMU (arch/x86/events/amd/iommu.c). I can put it into arch/x86/include/asm/perf_amd_iommu.h. What would you prefer? Thanks, Suravee From mboxrd@z Thu Jan 1 00:00:00 1970 From: Suravee Suthikulpanit Subject: Re: [PATCH V5 02/10] perf/amd/iommu: Consolidate and move perf_event_amd_iommu header Date: Mon, 14 Mar 2016 20:37:02 +0700 Message-ID: <56E6BE7E.8010807@amd.com> References: <1456236764-1569-1-git-send-email-Suravee.Suthikulpanit@amd.com> <1456236764-1569-3-git-send-email-Suravee.Suthikulpanit@amd.com> <20160312132224.GI6344@twins.programming.kicks-ass.net> <56E64B68.3090505@amd.com> <20160314095856.GL6344@twins.programming.kicks-ass.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160314095856.GL6344-ndre7Fmf5hadTX5a5knrm8zTDFooKrT+cvkQGrU6aU0@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Peter Zijlstra Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, acme-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, andihartmann-KuiJ5kEpwI6ELgA04lAiVw@public.gmane.org, mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org, labbott-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org List-Id: iommu@lists.linux-foundation.org Hi, On 3/14/16 16:58, Peter Zijlstra wrote: > On Mon, Mar 14, 2016 at 12:26:00PM +0700, Suravee Suthikulpanit wrote: >> Hi, >> >> On 03/12/2016 08:22 PM, Peter Zijlstra wrote: >>> On Tue, Feb 23, 2016 at 08:12:36AM -0600, Suravee Suthikulpanit wrote: >>>> From: Suravee Suthikulpanit >>>> >>>> First, this patch move arch/x86/events/amd/iommu.h to >>>> arch/x86/include/asm/perf/amd/iommu.h so that we easily include >>>> it in both perf-amd-iommu and amd-iommu drivers. >>>> >>>> Then, we consolidate declaration of AMD IOMMU performance counter >>>> APIs into one file. >>> >>> These seem two independent thingies; should this therefore not be 2 >>> patches? >>> >>>> Reviewed-by: Joerg Roedel >>>> Signed-off-by: Suravee Suthikulpanit >>>> --- >>>> arch/x86/events/amd/iommu.c | 2 +- >>>> arch/x86/events/amd/iommu.h | 40 --------------------------------- >>>> arch/x86/include/asm/perf/amd/iommu.h | 42 +++++++++++++++++++++++++++++++++++ >>> >>> That seems somewhat excessive. Not only do you create >>> arch/x86/include/asm/perf/ you then put another directory on top of >>> that. >>> >> >> The original header files (arch/x86/events/amd/iommu.h and >> drivers/iommu/amd_iommu_proto.h) has duplicate function declarations. So, >> with the new header file being in the arch/x86/include/asm/perf/amd/iommu.h, >> we can just have one function declaration. >> >> So, you just want to separate the file moving part and the part that removes >> of the duplication? > > I'm fine with a new header, it just seems putting it in a two deep > direcotry hierarchy of its own that seems excessive. > Basically, we are trying to match the current Perf hierarchy for AMD IOMMU (arch/x86/events/amd/iommu.c). I can put it into arch/x86/include/asm/perf_amd_iommu.h. What would you prefer? Thanks, Suravee