From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755246AbcCOGuG (ORCPT ); Tue, 15 Mar 2016 02:50:06 -0400 Received: from mx2.suse.de ([195.135.220.15]:50629 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754843AbcCOGuA (ORCPT ); Tue, 15 Mar 2016 02:50:00 -0400 Subject: Re: [PATCH 09/22] ncr5380: Adopt uniform DMA setup convention To: Finn Thain References: <20160314042700.596192247@telegraphics.com.au> <20160314042702.976019738@telegraphics.com.au> <56E669F6.8070407@suse.de> Cc: "James E.J. Bottomley" , "Martin K. Petersen" , Michael Schmitz , linux-m68k@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Russell King , linux-arm-kernel@lists.infradead.org, Ondrej Zary , Sam Creasey From: Hannes Reinecke Message-ID: <56E7B094.3000301@suse.de> Date: Tue, 15 Mar 2016 07:49:56 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/15/2016 04:19 AM, Finn Thain wrote: > > On Mon, 14 Mar 2016, Hannes Reinecke wrote: > >>> @@ -1555,8 +1555,7 @@ static int NCR5380_transfer_dma(struct S >>> NCR5380_read(RESET_PARITY_INTERRUPT_REG); >>> *data = d + c; >>> *count = 0; >>> - *phase = NCR5380_read(STATUS_REG) & PHASE_MASK; >>> - return foo; >>> + return result; >>> } >>> >>> /* >> >> Don't you miss a phase update here? > > I guess I missed explaining the change in the commit log. > > The *phase assignment is redundant because after NCR5380_transfer_dma() > returns control to NCR5380_information_transfer(), the latter routine then > also returns, and so *phase is dead. > Right. Please add this to the commit message. Otherwise: Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) From mboxrd@z Thu Jan 1 00:00:00 1970 From: hare@suse.de (Hannes Reinecke) Date: Tue, 15 Mar 2016 07:49:56 +0100 Subject: [PATCH 09/22] ncr5380: Adopt uniform DMA setup convention In-Reply-To: References: <20160314042700.596192247@telegraphics.com.au> <20160314042702.976019738@telegraphics.com.au> <56E669F6.8070407@suse.de> Message-ID: <56E7B094.3000301@suse.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 03/15/2016 04:19 AM, Finn Thain wrote: > > On Mon, 14 Mar 2016, Hannes Reinecke wrote: > >>> @@ -1555,8 +1555,7 @@ static int NCR5380_transfer_dma(struct S >>> NCR5380_read(RESET_PARITY_INTERRUPT_REG); >>> *data = d + c; >>> *count = 0; >>> - *phase = NCR5380_read(STATUS_REG) & PHASE_MASK; >>> - return foo; >>> + return result; >>> } >>> >>> /* >> >> Don't you miss a phase update here? > > I guess I missed explaining the change in the commit log. > > The *phase assignment is redundant because after NCR5380_transfer_dma() > returns control to NCR5380_information_transfer(), the latter routine then > also returns, and so *phase is dead. > Right. Please add this to the commit message. Otherwise: Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare at suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg GF: F. Imend?rffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG N?rnberg)