From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48546)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <clg@fr.ibm.com>) id 1afjyl-0005cn-LG
	for qemu-devel@nongnu.org; Tue, 15 Mar 2016 04:05:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <clg@fr.ibm.com>) id 1afjyi-0000AI-KS
	for qemu-devel@nongnu.org; Tue, 15 Mar 2016 04:05:23 -0400
Received: from e06smtp13.uk.ibm.com ([195.75.94.109]:39263)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <clg@fr.ibm.com>) id 1afjyi-00007Z-AS
	for qemu-devel@nongnu.org; Tue, 15 Mar 2016 04:05:20 -0400
Received: from localhost
	by e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <clg@fr.ibm.com>;
	Tue, 15 Mar 2016 08:05:17 -0000
References: <1457974600-13828-1-git-send-email-clg@fr.ibm.com>
	<1457974600-13828-13-git-send-email-clg@fr.ibm.com>
	<56E71E8E.4090800@redhat.com>
From: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= <clg@fr.ibm.com>
Message-ID: <56E7C234.9060005@fr.ibm.com>
Date: Tue, 15 Mar 2016 09:05:08 +0100
MIME-Version: 1.0
In-Reply-To: <56E71E8E.4090800@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 12/17] ppc: Fix writing to AMR/UAMOR
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Thomas Huth <thuth@redhat.com>, David Gibson <david@gibson.dropbear.id.au>
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org

On 03/14/2016 09:26 PM, Thomas Huth wrote:
>> > @@ -8093,7 +8137,7 @@ static void init_proc_book3s_64(CPUPPCState *env, int version)
>> >      case BOOK3S_CPU_POWER7:
>> >      case BOOK3S_CPU_POWER8:
>> >          gen_spr_book3s_ids(env);
>> > -        gen_spr_amr(env);
>> > +        gen_spr_amr(env, version >= BOOK3S_CPU_POWER8);
>> >          gen_spr_book3s_purr(env);
>> >          env->ci_large_pages = true;
>> >          break;
> I think this last hunk (and thus the "has_iamr" parameter of that
> function) rather belong to the next patch, since it is not used here yet.

Yes. I fixed a compile break but I moved the hunk in the wrong patch.

Thanks,

C.