From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45786)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1aflSm-0004at-2A
	for qemu-devel@nongnu.org; Tue, 15 Mar 2016 05:40:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1aflSi-0001Wq-1p
	for qemu-devel@nongnu.org; Tue, 15 Mar 2016 05:40:28 -0400
Received: from mail-wm0-x236.google.com ([2a00:1450:400c:c09::236]:36462)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1aflSh-0001Wm-RN
	for qemu-devel@nongnu.org; Tue, 15 Mar 2016 05:40:23 -0400
Received: by mail-wm0-x236.google.com with SMTP id l124so3202341wmf.1
	for <qemu-devel@nongnu.org>; Tue, 15 Mar 2016 02:40:23 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
References: <87wpp4m6n1.fsf@blackfin.pond.sub.org>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <56E7D884.902@redhat.com>
Date: Tue, 15 Mar 2016 10:40:20 +0100
MIME-Version: 1.0
In-Reply-To: <87wpp4m6n1.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] Our use of #include is undisciplined,
	and what to do about it
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>, Stefan Hajnoczi <stefanha@redhat.com>



On 15/03/2016 10:29, Markus Armbruster wrote:
> NEED_CPU_H further adds
> 
>     include/disas/bfd.h
>     include/exec/cpu-all.h
>     include/exec/cpu-common.h
>     include/exec/cpu-defs.h
>     include/exec/exec-all.h
>     include/exec/hwaddr.h
>     include/exec/memattrs.h
>     include/exec/memory.h
>     include/hw/hotplug.h
>     include/hw/i386/apic.h
>     include/hw/irq.h
>     include/hw/qdev-core.h
>     include/qemu/bitmap.h
>     include/qemu/bitops.h
>     include/qemu/int128.h
>     include/qemu/log.h
>     include/qemu/notify.h
>     include/qemu/rcu.h
>     include/qemu/thread-posix.h
>     include/qemu/thread.h
>     include/qom/cpu.h
>     include/qom/object.h
>     include/standard-headers/asm-x86/hyperv.h
>     include/standard-headers/linux/types.h
>     target-i386/cpu-qom.h
>     target-i386/cpu.h
>     target-i386/svm.h
>     tcg/i386/tcg-target.h
>     x86_64-softmmu/config-target.h

FWIW, I'm going to do something about this in 2.7.  I have patches to
remove cpu.h inclusion from qemu-common.h.

Generally though qemu-common.h needs to go. :)
Paolo