From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matej Vido Subject: Re: [PATCH 4/4] szedata2: add 100G link speed Date: Tue, 15 Mar 2016 14:47:30 +0100 Message-ID: <56E81272.7070800@stud.fit.vutbr.cz> References: <1457992546-32230-1-git-send-email-thomas.monjalon@6wind.com> <1458047529-6522-1-git-send-email-vido@cesnet.cz> <1458047529-6522-5-git-send-email-vido@cesnet.cz> <8527284.jAONBlNGsn@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable To: dev@dpdk.org Return-path: Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41]) by dpdk.org (Postfix) with ESMTP id A7541558F for ; Tue, 15 Mar 2016 14:47:31 +0100 (CET) Received: by mail-wm0-f41.google.com with SMTP id l68so151531545wml.0 for ; Tue, 15 Mar 2016 06:47:31 -0700 (PDT) Received: from ?IPv6:2001:67c:1220:8b2:e849:51b9:b39f:4866? ([2001:67c:1220:8b2:e849:51b9:b39f:4866]) by smtp.gmail.com with ESMTPSA id v5sm20991517wmg.16.2016.03.15.06.47.30 for (version=TLSv1/SSLv3 cipher=OTHER); Tue, 15 Mar 2016 06:47:30 -0700 (PDT) In-Reply-To: <8527284.jAONBlNGsn@xps13> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" D=C5=88a 15.03.2016 o 14:41 Thomas Monjalon nap=C3=ADsal(a): > Thanks for the series completing the ethdev rework with the same splitt= ing. > > 2016-03-15 14:12, Matej Vido: >> Temporary 10G constant is replaced with 100G constant. >> Item speed_capa from struct rte_eth_dev_info is set with 100G flag. > [...] >> @@ -1161,7 +1162,7 @@ eth_link_update(struct rte_eth_dev *dev, >> * will be changed to support 100Gbps speed change >> * this value to 100G. >> */ >> - link.link_speed =3D ETH_SPEED_NUM_10G; >> + link.link_speed =3D ETH_SPEED_NUM_100G; > Shouldn't we remove the above comment? Yes, I forgot