From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matej Vido Subject: Re: [PATCH 4/4] szedata2: add 100G link speed Date: Tue, 15 Mar 2016 14:50:52 +0100 Message-ID: <56E8133C.2020307@cesnet.cz> References: <1457992546-32230-1-git-send-email-thomas.monjalon@6wind.com> <1458047529-6522-1-git-send-email-vido@cesnet.cz> <1458047529-6522-5-git-send-email-vido@cesnet.cz> <8527284.jAONBlNGsn@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Cc: marcdevel@gmail.com, dev@dpdk.org To: Thomas Monjalon Return-path: Received: from office2.cesnet.cz (office2.cesnet.cz [195.113.144.244]) by dpdk.org (Postfix) with ESMTP id C1BA9532C for ; Tue, 15 Mar 2016 14:50:52 +0100 (CET) In-Reply-To: <8527284.jAONBlNGsn@xps13> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" D=C5=88a 15.03.2016 o 14:41 Thomas Monjalon nap=C3=ADsal(a): > Thanks for the series completing the ethdev rework with the same splitt= ing. > > 2016-03-15 14:12, Matej Vido: >> Temporary 10G constant is replaced with 100G constant. >> Item speed_capa from struct rte_eth_dev_info is set with 100G flag. > [...] >> @@ -1161,7 +1162,7 @@ eth_link_update(struct rte_eth_dev *dev, >> * will be changed to support 100Gbps speed change >> * this value to 100G. >> */ >> - link.link_speed =3D ETH_SPEED_NUM_10G; >> + link.link_speed =3D ETH_SPEED_NUM_100G; > Shouldn't we remove the above comment? Yes, I forgot. Should I remove the comment and send again or could you=20 do it when merging with original series? Matej