From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46751)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1ag6eq-0004Rt-PW
	for qemu-devel@nongnu.org; Wed, 16 Mar 2016 04:18:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1ag6el-0002bN-Pl
	for qemu-devel@nongnu.org; Wed, 16 Mar 2016 04:18:20 -0400
Received: from mx1.redhat.com ([209.132.183.28]:54495)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1ag6el-0002bH-JI
	for qemu-devel@nongnu.org; Wed, 16 Mar 2016 04:18:15 -0400
References: <1458036214-867-1-git-send-email-zhangchen.fnst@cn.fujitsu.com>
From: Jason Wang <jasowang@redhat.com>
Message-ID: <56E916BE.5060706@redhat.com>
Date: Wed, 16 Mar 2016 16:18:06 +0800
MIME-Version: 1.0
In-Reply-To: <1458036214-867-1-git-send-email-zhangchen.fnst@cn.fujitsu.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH V4 0/2] Introduce filter-redirector
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Zhang Chen <zhangchen.fnst@cn.fujitsu.com>, qemu devel <qemu-devel@nongnu.org>
Cc: Li Zhijian <lizhijian@cn.fujitsu.com>, Gui jianfeng <guijianfeng@cn.fujitsu.com>, "eddie.dong" <eddie.dong@intel.com>, zhanghailiang <zhang.zhanghailiang@huawei.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Yang Hongyang <hongyang.yang@easystack.cn>



On 03/15/2016 06:03 PM, Zhang Chen wrote:
> Filter-redirector is a netfilter plugin.
> It gives qemu the ability to redirect net packet.
> redirector can redirect filter's net packet to outdev.
> and redirect indev's packet to filter.
>
>                       filter
>                         +
>                         |
>                         |
>             redirector  |
>                +--------------+
>                |        |     |
>                |        |     |
>                |        |     |
>   indev +-----------+   +---------->  outdev
>                |    |         |
>                |    |         |
>                |    |         |
>                +--------------+
>                     |
>                     |
>                     v
>                   filter
>
>
> v4:
>  Address Jason's comments.
>  - remove redirector's incoming queue
>  - just pass packet come from in_dev to filter's next
>  - rework redirector_chr_read, most code is stolen from net_socket_send  
>  - fix comments error
>  - add some comments 
>
> v3:
>  -Address Jason's comments.
>
> v2:
>  - Address Jason's comments.
>  - Add filter-traffic.h to reuse parts of the codes
>  - Add unit test case
>
> v1:
>  initial patch.
>
>
> Zhang Chen (2):
>   net/filter-mirror: implement filter-redirector
>   tests/test-filter-redirector: Add unit test for filter-redirector
>
>  net/filter-mirror.c            | 236 +++++++++++++++++++++++++++++++++++++++++
>  qemu-options.hx                |   9 ++
>  tests/.gitignore               |   1 +
>  tests/Makefile                 |   2 +
>  tests/test-filter-redirector.c | 221 ++++++++++++++++++++++++++++++++++++++
>  vl.c                           |   3 +-
>  6 files changed, 471 insertions(+), 1 deletion(-)
>  create mode 100644 tests/test-filter-redirector.c
>

Looks good, just few comments, please see individual patches.