From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57872)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tubo@linux.vnet.ibm.com>) id 1agWwY-00088H-NJ
	for qemu-devel@nongnu.org; Thu, 17 Mar 2016 08:22:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <tubo@linux.vnet.ibm.com>) id 1agWwT-0003WY-MM
	for qemu-devel@nongnu.org; Thu, 17 Mar 2016 08:22:22 -0400
Received: from e36.co.us.ibm.com ([32.97.110.154]:55110)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tubo@linux.vnet.ibm.com>) id 1agWwT-0003WK-Ac
	for qemu-devel@nongnu.org; Thu, 17 Mar 2016 08:22:17 -0400
Received: from localhost
	by e36.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only!
	Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <tubo@linux.vnet.ibm.com>;
	Thu, 17 Mar 2016 06:22:15 -0600
References: <1458123018-18651-1-git-send-email-famz@redhat.com>
	<56E9355A.5070700@redhat.com> <56E93A22.1080102@de.ibm.com>
	<56E93ECE.10103@redhat.com> <56E9425C.8030201@de.ibm.com>
	<56E957AD.2050005@redhat.com> <56E961EA.4090908@de.ibm.com>
From: tu bo <tubo@linux.vnet.ibm.com>
Message-ID: <56EAA170.1000904@linux.vnet.ibm.com>
Date: Thu, 17 Mar 2016 20:22:08 +0800
MIME-Version: 1.0
In-Reply-To: <56E961EA.4090908@de.ibm.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 0/4] Tweaks around virtio-blk start/stop
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Christian Borntraeger <borntraeger@de.ibm.com>, Paolo Bonzini <pbonzini@redhat.com>, Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, cornelia.huck@de.ibm.com, Stefan Hajnoczi <stefanha@redhat.com>, qemu-block@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>


On 03/16/2016 09:38 PM, Christian Borntraeger wrote:
> On 03/16/2016 01:55 PM, Paolo Bonzini wrote:
>>
>>
>> On 16/03/2016 12:24, Christian Borntraeger wrote:
>>> On 03/16/2016 12:09 PM, Paolo Bonzini wrote:
>>>> On 16/03/2016 11:49, Christian Borntraeger wrote:
>>>>> #3  0x00000000800b713e in virtio_blk_data_plane_start (s=0xba232d80) at /home/cborntra/REPOS/qemu/hw/block/dataplane/virtio-blk.c:224
>>>>> #4  0x00000000800b4ea0 in virtio_blk_handle_output (vdev=0xb9eee7e8, vq=0xba305270) at /home/cborntra/REPOS/qemu/hw/block/virtio-blk.c:590
>>>>> #5  0x00000000800ef3dc in virtio_queue_notify_vq (vq=0xba305270) at /home/cborntra/REPOS/qemu/hw/virtio/virtio.c:1095
>>>>> #6  0x00000000800f1c9c in virtio_queue_host_notifier_read (n=0xba3052c8) at /home/cborntra/REPOS/qemu/hw/virtio/virtio.c:1785
>>
>> If you just remove the calls to virtio_queue_host_notifier_read, here
>> and in virtio_queue_aio_set_host_notifier_fd_handler, does it work
>> (keeping patches 2-4 in)?
>
> With these changes and patch 2-4 it does no longer locks up.
> I keep it running some hour to check if a crash happens.
>
> Tu Bo, your setup is currently better suited for reproducing. Can you also check?

remove the calls to virtio_queue_host_notifier_read, and keeping patches 
2-4 in,

I got same crash as before,
(gdb) bt
#0  bdrv_co_do_rw (opaque=0x0) at block/io.c:2172
#1  0x000002aa0c65d786 in coroutine_trampoline (i0=<optimized out>, 
i1=-2013204784) at util/coroutine-ucontext.c:79
#2  0x000003ff99ad150a in __makecontext_ret () from /lib64/libc.so.6


>
>>
>> Paolo
>>
>>>>> #7  0x00000000800f1e14 in virtio_queue_set_host_notifier_fd_handler (vq=0xba305270, assign=false, set_handler=false) at /home/cborntra/REPOS/qemu/hw/virtio/virtio.c:1817
>>>>> #8  0x0000000080109c50 in virtio_ccw_set_guest2host_notifier (dev=0xb9eed6a0, n=0, assign=false, set_handler=false) at /home/cborntra/REPOS/qemu/hw/s390x/virtio-ccw.c:97
>>>>> #9  0x0000000080109ef2 in virtio_ccw_stop_ioeventfd (dev=0xb9eed6a0) at /home/cborntra/REPOS/qemu/hw/s390x/virtio-ccw.c:154
>>
>