From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755119AbcCRKHA (ORCPT ); Fri, 18 Mar 2016 06:07:00 -0400 Received: from mail-bl2on0076.outbound.protection.outlook.com ([65.55.169.76]:15936 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752506AbcCRKGv (ORCPT ); Fri, 18 Mar 2016 06:06:51 -0400 Authentication-Results: lists.linux-foundation.org; dkim=none (message not signed) header.d=none;lists.linux-foundation.org; dmarc=none action=none header.from=amd.com; Subject: Re: [PATCH V5 02/10] perf/amd/iommu: Consolidate and move perf_event_amd_iommu header To: Borislav Petkov References: <20160314095856.GL6344@twins.programming.kicks-ass.net> <56E6BE7E.8010807@amd.com> <20160314141945.GE15800@pd.tnic> <20160314163913.GO6344@twins.programming.kicks-ass.net> <56E759C3.5040707@amd.com> <20160315104017.GA4559@pd.tnic> <20160315105318.GU6344@twins.programming.kicks-ass.net> <56EBA92D.7010906@amd.com> <20160318090441.GA7817@pd.tnic> <56EBC5CD.7070701@amd.com> <20160318092910.GC7817@pd.tnic> CC: Peter Zijlstra , , , , , , , , From: Suravee Suthikulpanit Message-ID: <56EBD31F.6050206@amd.com> Date: Fri, 18 Mar 2016 17:06:23 +0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160318092910.GC7817@pd.tnic> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [124.121.8.20] X-ClientProxiedBy: KL1PR02CA0009.apcprd02.prod.outlook.com (25.165.15.19) To SN1PR12MB0448.namprd12.prod.outlook.com (25.162.105.141) X-MS-Office365-Filtering-Correlation-Id: fd638331-82a8-41f9-1cef-08d34f150389 X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0448;2:aezmwZ6u6RSHYQRrpXbAFWrDTNqLZn6y3veVZThrWe/gNxxBXTMXothdfiew7g+WZC3gxpOfMoDokQhShIxbwL4AZ4XMbJ8UZkh+mttCHGzq0YWhUm4tgtePkmrneFXtDY9qjeg9Tjz8sIwaPtkD/jD3RhWq0/z9dN/kWebZ6OXoAhbx7JyqAxr5B7tcQXFd;3:Hb9574GDTss02IAKseNEOyvkqNX0WfleFNE6xQgRjpOA49+7vmjvI+6wz7TwEd5fkOB/E8mkk9ncp/9kxfodzukj8QgRIu1HDGNzLHMc6YWhddQyF6MQVZxBi3E/R7vL;25:TfsWI7IkppTtSQVm+4EqbHXRBT/lJ/KJlcqg5bT4ohd4LtotFzpg23SrlvRzKeQID0rIwRIDVFvVyriyeD9myNXLylJ83zxSqrzIps4z4kexrqHXLheGLn/ntfW78lHHi9WAyKgTf9PmASiQXdulBvo1hxQlKQrGUMXeGaZMYPslM0stp1TxtROrKMfDQ29AEODlj7DXz3SSOjkNFiUz5+lPiD+ZXK5xxmqasTAT3yB8oxaFWqAmGU/toU36YuWIUBlHj2P0anAbGajkDi6ZbVgw+6SedwQi0QidtH/poWew5F/xqhbwZGNCj+rTJkthU/vRWhDwNhgH4EtU43yhsKRj91KADC5vectRodDz8NM3JlqXD6OfINpj+Hl1ax9ZuH3JDt5xpFQg5gQ7F7ueT/8W274QV9bmnDVzM43gFax4JHwX9Gl9D/p7z+pETSSQm2pkna7iPVIxVuea3owuQutJsl9MVhvfL3Z5s2zaG7x/aMA4LHglIR3ehBrhLNJPPzo7LlgjtQLSAyXggr0Sdw== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:SN1PR12MB0448; X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0448;20:Sje0pjXgrPVIvydRV7FZ43VzKuf8pgPoTC2fH+yueSKaIqDL1rhjSNY9+dSRev+pVu0lqu4uoZ1cYRHvQBpy7EAM7j3I32nQuk42vBDSaipBnCmUZs21iuPquJqAKh2FYxebJrUyt18NYV550niAlt3x0ATt6HOvjewNzzSGrng6Nri/6Pkxh+V5NozxicnC3br2racBXMC3vjlIa6TZSQRMO8HwzYcnb4pogCgSbTgd6ckz3DHzud76GvfCvCCKAKQFSsbkniEAeUm/hyrQrV7AFAKARNkcJU0FZztsFnnk/tMX8fo841uvg2asylUbbu/0KYdmHpyXApdgTXMYZVYuGW7c83HiOqmZ11EtfTAuYORH+yjhjNhp1CCz7nAB7ieZyg7VqVdKHc7Tdb1+p7i6/YQYo2h7XLRvjEzxLhLN61p6XP36IzeNYiO/TUwwwS6JJcJwJZYrSjauBqZRxC3eHtNOtq3uQt8WsZtKc7/FSdmCgs4ks0M06j7a5+tO;4:dKmdeMThhHgfGBEWLp/o67CpWyuWibNz0vun8YG1+e4af5qJczHbG3eJqUC83ajIULoYfsule8IY3KOeZXMn4zSRsLUBOXAC4BsAKmH+RT/DGLIrsynLF5FoR2367fZJqGHvPlO+LP98zUPDSeO9KhLr2dnLXYzK/rRh0alpZZq+7qzbg7M4JZeBhzBwWCcJpT7jJn95J6YAfSGRK91Z3x7gAy3JifcNgAwusGtH+kI8Xo3gkRy3zaTV09ZIXcp8vWepp9IgGfJdOXIbivEvs9K1b8j1r++IXrWH41dWV6MSHwCh2DUZKlMFJQqdGsCg+8P4qjWKw64dSrvu0lnRoTp14wrKfh3Tgsru53CRzBDF6Z0DvKqiTpt5bUMnpu3H X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046);SRVR:SN1PR12MB0448;BCL:0;PCL:0;RULEID:;SRVR:SN1PR12MB0448; X-Forefront-PRVS: 088552DE73 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(6049001)(479174004)(377454003)(164054003)(24454002)(86362001)(5004730100002)(81166005)(6116002)(59896002)(3846002)(1096002)(230700001)(586003)(80316001)(93886004)(36756003)(83506001)(23676002)(50466002)(92566002)(76176999)(50986999)(4001350100001)(54356999)(110136002)(65816999)(189998001)(4326007)(47776003)(66066001)(65806001)(2950100001)(65956001)(64126003)(42186005)(77096005)(2906002)(5008740100001)(33656002);DIR:OUT;SFP:1101;SCL:1;SRVR:SN1PR12MB0448;H:[192.168.0.19];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtTTjFQUjEyTUIwNDQ4OzIzOlpUZnc4ZXAwNTAwRFZLZUVyUURoUHFQa3Jr?= =?utf-8?B?Z2dMQ2xyNlRTWE81VUZaa1pJSVlmVzkya3dKVStNeWY5UUJqR2ZOVVNsS0FV?= =?utf-8?B?Z0poSmgyWUw4ZlAyOW1qbFk1ZDlrSDBBRkx0MmhwajlpMHNxZ0lwVGFzclo0?= =?utf-8?B?N1E2Vzh6SWluWk5YMmlidENvSEJDb1lFSlMwZENXazZjWWw1a09NWTM1Qm9B?= =?utf-8?B?VktWMmlDOUFuSWZTMmRBN0xObWozTkpOU0FqWjllSm5JK1pYSEljbGxnZDZl?= =?utf-8?B?cVRkNGdGcUVLeWNiSHNDU0UvTjdSRUR1b1NNZTBYem9FbnpzeVd2TTFZNzA4?= =?utf-8?B?bjBPb1BjbjNYOUVRbC9UNDgydXpYd2dDV1ZMVGQrQkUyVlBtM0hOUjdjd0Zo?= =?utf-8?B?ak5TQUR0dlBrWVF6bEk1NDFvZWtFdTc3WUdZdnQ4WHBzMWRVNmxWeFMvY0hx?= =?utf-8?B?UmFxR2prMG92dEdZdXEyYTZHWGhJRUlsTVl0bEMwbUUrMFVDb3pVWTV0SitV?= =?utf-8?B?NzFHMkx3UHZIaE1jS0JyRjR1dGRXcFhJSlVhWUhrM0ZROGh0Q0VNTEppdmEv?= =?utf-8?B?VEs5d0JSK2QxL0UveW1HeXFmMUE4ZDZuMFhNc2R1bUhtVUFEcFJjWHNZQXVz?= =?utf-8?B?azcvK29OUzlWbVozTDFZQzFQQndHWEUremJmdmUwQnRWNUhKc3RzNkRsYUc5?= =?utf-8?B?NkhjUjlGaXV4TGdiTzZ1enRlOGtHSy9XaHMwZUk1NlQ5d0k1eXphZ1R0aFBo?= =?utf-8?B?NDVMb1dCQWJKckp6Z2E4U1hqLzIvVzNaYWROQWNQeTdXVU5SdksrUC83THBH?= =?utf-8?B?QXV1dVZONlU5S2xEQjA2RHREY3lmSU9ublUxSHFEeUJhTU9WSUtGblUxQzZ5?= =?utf-8?B?WkNxQTNLSCswUEVxOTF3WW5GMUpKUHJpYTdLcjJkK1AvWDlsZlNVNU1IRGNF?= =?utf-8?B?QWdSWjRsTWRUZER5Y2psV0ppZTFtV29PK2VhZTRZSUJxbmVYdXNwVzNlTUpO?= =?utf-8?B?UVRnRkFpaFp0WVd5UDJNdDVtdmFTQ2pTdTUxenE2MUhzZHJBalArNi9NZmZj?= =?utf-8?B?dURRYmtwaEFobjlwUXk3ekpVZVE4ZTcydlZKenhqSHRwT1ZhZzFnbXpnVFV4?= =?utf-8?B?UFhuaWgzMEpGTnRPbWl6bzZ3SUFHLzJUckFKYm9td2F3TUNjY2dmRjV1bkhl?= =?utf-8?B?RG1sT1o2aVl0T3IvNmFEVHA0N3N4ZXQrZE1raDBQZzYvaVVjWmY1ZUZnRnZZ?= =?utf-8?B?ZTRvTHhYUmRSa0hkK05xVG8vWXM0MHVUL2VlQXFNMW0xTjBXdjVLQjBrYTI2?= =?utf-8?B?YnNsT3F3akJWZUVwNGNITmRiQklQVk9xR0JZRFlIcXlhZm52R1E5TGFEQkdE?= =?utf-8?B?b1dJQTZoSDgrZGFhWkdYNFFYa2dGNjFwODVYbHpSMEpKU3V3MU9vNGdlYzFW?= =?utf-8?B?UDNsUWd5c3A5U3RYb0dEZnVLa1Q5VGpkcjVIelNOYVBDckpsVjhzRXkvU1di?= =?utf-8?B?TkhJQT09?= X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0448;5:vDfOdtZQoCboSVeURBLV7yfLvG3W76XpoSAeS6iDVYVjIkJi32XAA0QofboGKJJJVtJ9fPSVBnTIisy/aHgXbXo/l8pvQPqsLbFAcG++TE42/hwpVH+bfXOWgV0C3EsZgYWAvhH6qXXHYcmOdApIbQ==;24:uwdIWR3NkxiVs0bLcCK5dwLXmMnOfIwQWMIcr/0jOoI+ZQs6nR/W4Q0Ox3yykY/D8tFuGjpOGSnZIXlnNj83BIbMaHDgQL1pr+otgA1rl9E=;20:P0U61EFQ0JTPvLL6aezy3mSU5UjLuUCy9+DaamGldJZjsSUCDCSDQb1I33dyRkp1MvgFLtlMUQVtjAqLwnC0ucxo32cEnHVVtsPuy9H7Pq8bbjVSb8r6BYviy1uaC46TlH1KY4G1h2QFUp2Cd94EB/WUk9dgCOwSXe7TsItGYoriRHqlJwqXiA1Cgr3WsfexuWmA2rmkkCdCwLFk7h6Z5ixnTLbetP6UINpdk61LUDkmal7MkFbaAu/IBU+dTdJX SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Mar 2016 10:06:43.2376 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR12MB0448 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/18/2016 04:29 PM, Borislav Petkov wrote: > On Fri, Mar 18, 2016 at 04:09:33PM +0700, Suravee Suthikulpanit wrote: >> But the whole point is that since we are moving it to consolidate these >> duplicated declarations, I think we should just put it in the most common >> place. The include/linux/amd-iommu.h file is already there. It's not like we >> have to create a brand new file, and then having to move it later. > > Strictly speaking, it was wrong to put it there in the first place as it > is x86-specific. > If not here, where would you prefer? Consolidating it to arch/x86/include/asm/amd-iommu.h)? And if that's the case, should I also move include/linux/amd-iommu.h as well? Thanks, Suravee From mboxrd@z Thu Jan 1 00:00:00 1970 From: Suravee Suthikulpanit Subject: Re: [PATCH V5 02/10] perf/amd/iommu: Consolidate and move perf_event_amd_iommu header Date: Fri, 18 Mar 2016 17:06:23 +0700 Message-ID: <56EBD31F.6050206@amd.com> References: <20160314095856.GL6344@twins.programming.kicks-ass.net> <56E6BE7E.8010807@amd.com> <20160314141945.GE15800@pd.tnic> <20160314163913.GO6344@twins.programming.kicks-ass.net> <56E759C3.5040707@amd.com> <20160315104017.GA4559@pd.tnic> <20160315105318.GU6344@twins.programming.kicks-ass.net> <56EBA92D.7010906@amd.com> <20160318090441.GA7817@pd.tnic> <56EBC5CD.7070701@amd.com> <20160318092910.GC7817@pd.tnic> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160318092910.GC7817-fF5Pk5pvG8Y@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Borislav Petkov Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, Peter Zijlstra , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, acme-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, andihartmann-KuiJ5kEpwI6ELgA04lAiVw@public.gmane.org, mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, labbott-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org List-Id: iommu@lists.linux-foundation.org On 03/18/2016 04:29 PM, Borislav Petkov wrote: > On Fri, Mar 18, 2016 at 04:09:33PM +0700, Suravee Suthikulpanit wrote: >> But the whole point is that since we are moving it to consolidate these >> duplicated declarations, I think we should just put it in the most common >> place. The include/linux/amd-iommu.h file is already there. It's not like we >> have to create a brand new file, and then having to move it later. > > Strictly speaking, it was wrong to put it there in the first place as it > is x86-specific. > If not here, where would you prefer? Consolidating it to arch/x86/include/asm/amd-iommu.h)? And if that's the case, should I also move include/linux/amd-iommu.h as well? Thanks, Suravee